Destroyed AuthenticationActivity retained by CustomTabsController.authTabLauncher (4.1.0; unchanged in 5.0.0-beta.0)
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 28/100
- issue の種類
- バグ
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 領域
- authentication, mobile
調査の方向性
Start in CustomTabsController.java, specifically its authTabLauncher, TWA launcher and service-connection handling, and trace how AuthenticationActivity is referenced through ActivityResultRegistry. The issue has not been reproduced on a running build, so first reproduce the leak with LeakCanary on the 5.0.0-beta.0 sample or a consuming app. Done means the destroyed-activity chain no longer appears after sign-in and cancellation, and the existing controller tests still pass. Ask a maintainer to confirm the cleanup approach before you change it.
索引モデルが issue の本文から書いたものです。
説明
Description
CustomTabsController can retain a destroyed AuthenticationActivity through its authTabLauncher and activity result registry after browser authentication has ended and service unbinding has run.
Observed at runtime on Auth0.Android 4.1.0. Reporting for consideration in 5.0.0-beta.0 because its CustomTabsController.java is byte-identical to 4.1.0 (Git blob f8c484692ebcc0c4da307058244814a52bae2a64). We have not reproduced this on a running 5.0.0-beta.0 build.
Expected: destroyed authentication activities should become collectible after cleanup, even if native browser callbacks temporarily retain the service connection/controller.
Reproduction / observed workflow
Observed in an integrating Android application, not yet reduced to the official sample app. Exact minimal reproduction and frequency remain unconfirmed.
- Start hosted browser sign-in using
WebAuthProviderwith Chrome available. - Exercise browser cancellation and a subsequent sign-in, with portrait/landscape rotation in the native app and during browser authentication.
- Complete or cancel authentication, then background the app and inspect LeakCanary.
The baseline heap captured this chain after activity destruction:
GC root: global variable in native code
CustomTabsClient$3.this$0
-> CustomTabsServiceConnection$1.this$0
-> CustomTabsController.authTabLauncher
-> ActivityResultRegistry$register$2.this$0
-> ComponentActivity$activityResultRegistry$1.this$0
-> destroyed com.auth0.android.provider.AuthenticationActivity
Retained: 41,693 bytes / 603 objects
Retained duration: 505,682 ms
LeakCanary signature: e9b26f477f8329d40efcd1423486f13912bac553
The presence of authTabLauncher in the retained chain does not by itself mean the browser was launched in Auth Tab mode; the tested launch log reported the Custom Tabs path.
Proposed lifecycle cleanup and local verification
We tested a source-pinned 4.1.0 modification limited in production behavior to CustomTabsController:
- During the existing owner's destruction/unbind path, release the Auth Tab launcher, TWA launcher, session references, and weak context.
- Make teardown idempotent, balance service-binding attempts, and destroy the detached TWA launcher.
- Mark the controller closed and reject late service connections or queued browser launches after closure.
- Keep the existing activity lifecycle, callback recovery, PKCE, and token behavior intact. No reflection, forced browser termination, or suppression of leak detection.
After this modification, the same physical tablet passed browser-X cancellation, native rotation, browser rotation, and successful hosted sign-in returning to the native app. A fresh, user-requested LeakCanary heap analysis reported 0 application leaks, 0 library leaks, and 0 unreachable objects. The original one-leak report was retained in history.
Local automated verification: 25 controller tests plus 37 consuming-app authorization/setup tests passed; debug lint and APK assembly passed. This is bounded evidence, not a claim that every lifecycle path is leak-free.
Could maintainers confirm whether clearing these activity-owned references belongs in the controller's unbind/destruction cleanup and consider an upstream fix for this retention path?
Version comparison
- 5.0.0-beta.0 release PR #1081
- 4.1.0 to 5.0.0-beta.0 comparison
- The browser-provider change in that comparison only updates documentation links in
WebAuthProvider; the leaking controller is unchanged.
Environment
- Auth0.Android: 4.1.0 runtime reproduction; 5.0.0-beta.0 source comparison only.
- Android 14 / API 34, Samsung SM-T220 physical tablet.
- Browser: Chrome (exact browser version not captured in this report).
- LeakCanary 2.14.
No heap dump is attached because it may contain credentials or other sensitive application data. Open issues were searched for CustomTabsController and leak; no matching open issue was found. Official-sample reproduction and the remaining template checklist checks have not been completed.
- 主要言語
- Kotlin
- スター
- 301
- フォーク
- 183
- 平均マージ
- 1日 4時間
- マージ済み PR(30日)
- 14
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
auth0/Auth0.Android のほかの issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
auth0/Auth0.Android#1095 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
auth0/Auth0.Android の issue をすべて見る
似ている issue
-
[Submission] 悠悠有品オープンsubmit-adaption submit-adaption-pre
難易度 1/5 1時間未満 初心者へのやさしさ 75/100
BetterAndroid/android-notification-icon-project#763 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
bug good first issue
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
scarif-labs/horus#61 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 87/100
damontecres/Wholphin#2093 ·
メンテナーはふだん 1 日以内に返信
-
bug needs triage
難易度 2/5 1〜3時間 初心者へのやさしさ 83/100
FossifyOrg/Messages#929 ·
メンテナーはふだん 1 日以内に返信
-
cr:missing-repro cr:platform:android missing-repro platform:android
難易度 2/5 1〜3時間 初心者へのやさしさ 90/100
software-mansion/react-native-screens#4950 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信