Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

[Bug] notifyMasterOnline aborts the long-polling wake-up with a NullPointerException when an arrival drains a bucket first

オープン 初心者向け
  • 何か問題がありますか？
#11,441 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@iloveeyjafjalla がすでに取り組んでいます。

2026年10月14日 から。

  • #11442 @iloveeyjafjalla による — オープン

評価

難易度
2/5
見積もり時間
1〜3時間
初心者へのやさしさ
82/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
java
領域
backend

調査の方向性

PullRequestHoldService.notifyMasterOnline の約191行目から始めてください。ここでは pullRequestTable に対するループが mpr.cloneListAndClear() を呼び出し、その結果を直接反復しています。空のバケットに対して null を返す ManyPullRequest.cloneListAndClear() を読み、notifyMessageArriving の null チェックと比較してください。並行して空にされたバケットがスキップされ、かつ他のキューのリクエストが引き続き起こされたら完了です。

索引モデルが issue の本文から書いたものです。

説明

Describe the Bug

When the smallest broker of a group changes and this broker becomes the master, BrokerController#onMinBrokerChange ends with pullRequestHoldService.notifyMasterOnline(), whose job is to immediately re-execute every pull request that is currently suspended, so that clients do not have to wait for their own suspend timeout after a master comes online.

That sweep assumes a bucket it has just seen as non-empty still holds requests when it drains it:

for (ManyPullRequest mpr : this.pullRequestTable.values()) {
    if (mpr == null || mpr.isEmpty()) {
        continue;
    }
    for (PullRequest request : mpr.cloneListAndClear()) {

ManyPullRequest#cloneListAndClear() returns null (not an empty list) whenever the bucket is empty at drain time:

public synchronized List<PullRequest> cloneListAndClear() {
    if (!this.pullRequestList.isEmpty()) {
        ...
        return result;
    }
    return null;
}

The buckets are drained by the message-arrival path on the store's dispatch thread (NotifyMessageArrivingListener -> PullRequestHoldService#notifyMessageArriving, which drains the same bucket and replays the requests that did not match). An arrival that wins the race between the isEmpty() check above and the drain makes the loop iterable null, so the enhanced for throws a NullPointerException.

Impact
  1. The NullPointerException escapes notifyMasterOnline() into onMinBrokerChange. The sweep is over, so every bucket that had not yet been visited keeps its requests suspended: those clients sit out their full suspend timeout instead of being woken immediately - exactly the stall this method exists to prevent, and in exactly the failover window it is meant for.
  2. The exception is thrown on the thread that updates the min-broker state (including the UPDATE_MIN_BROKER admin path), so the caller sees a failure for an operation that has otherwise already been applied.

The same class shows what the intended contract is: notifyMessageArriving drains a bucket the same way and guards the result with if (requestList != null) before iterating, so the missing guard in notifyMasterOnline is an oversight rather than a documented behaviour.

How to Reproduce
  • Suspend a pull request on some topic@queueId (long polling enabled, i.e. the client sent the suspend flag and the pull returned PULL_NOT_FOUND longer than the max. offset).
  • Produce a message for that queue from another thread, so the dispatch thread drains the same bucket through notifyMessageArriving in the same instant as notifyMasterOnline().
  • The stricter, deterministic form of the race: the bucket reports itself as non-empty and is drained before notifyMasterOnline() drains it, which is what makes the sweep iterable null.
  • Result with the current code: java.lang.NullPointerException at org.apache.rocketmq.broker.longpolling.PullRequestHoldService.notifyMasterOnline(PullRequestHoldService.java:191), and the remaining buckets are not woken.
Expected Behavior

A bucket that lost that race is skipped; the sweep continues and still wakes the requests held for the other queues.

Proposed Fix

Read the drained list into a local variable and skip the bucket when it answers null, instead of iterating the call result directly:

List<PullRequest> requestList = mpr.cloneListAndClear();
if (requestList == null) {
    continue;
}
for (PullRequest request : requestList) {
Environment
  • 5.5.1-SNAPSHOT (develop, 0dd48c39db), all platforms
主要言語
Java
スター
22.6k
フォーク
12k
平均マージ
4日 13時間
マージ済み PR（30日）
20

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

apache/rocketmq のほかの issue

apache/rocketmq の issue をすべて見る

似ている issue

Java の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。