spec: is identify_by inherited through extends?

オープン
#692 コメント 2 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
45/100
issue の種類
ドキュメント
明瞭さ
おおむね明確
活発さ
活発
技術スタック
json, markdown, python

調査の方向性

Read ontology/ontology.md (especially “Identifiers” and the derived-subtype example), core-spec/spec.md, and ontology/ontology.json to decide how the rule should be expressed consistently. The issue recommends documenting that identify_by is not inherited and adding a validation warning, but these changes involve specification and implementation work; done means the inheritance rule and example are clear and the warning covers the described case.

索引モデルが issue の本文から書いたものです。

説明

needs-triage

ontology/ontology.md ("Identifiers") says identify_by "allows modelers to list the names of relationships that form the preferred identifier of a concept". Nothing in ontology.md, core-spec/spec.md, or ontology/ontology.json says whether a concept that extends another inherits the parent's identify_by, or must declare its own.

The reference implementation (now in apache/ossie-converters, ontology/src/ossie_ontology/converter/spec_to_ossie/converter.py, _populate_ontology) resolves the question one way without documenting it: it builds identify_by only from the concept's own identify_by list. A subtype that declares none — as Customer did in the first revision of #310 — resolves to an empty identifier even though it extends a concept with a preferred identifier and every one of its objects is identifiable by it.

Note the asymmetry: lookup_concept_relationship does walk extends when resolving a relationship name, so identify_by: [ nr ] on the subtype resolves to BusinessPartner.nr. The lookup inherits; the identifier list does not.

First raised by @jbonofre in the #310 review.

Proposal
  1. Document the rule. Recommended: identify_by is not inherited and must be declared on every entity type that is meant to be referenced. This matches the engine's behaviour today, and avoids ambiguity when a concept has more than one parent in extends.
  2. Add a validation warning when an entity type with a non-empty extends declares no identify_by and none of its parents' identifiers is restated — the silent empty identifier is what made #310's defect invisible until the engine ran.
  3. Update the Employee-style derived-subtype example in ontology.md to show the explicit declaration.
主要言語
Python
スター
2.7k
フォーク
353
平均マージ
3日 19時間
マージ済み PR(30日)
86

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

apache/ossie のほかの issue

apache/ossie の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。