Implement Spark-compatible `xpath_int`

オープン
  • 何か問題がありますか？
#285 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
72/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
rust, sql, xml
領域
databases

調査の方向性

Start from the shared number() evaluator planned in crates/spark/src/function/xml/ (see the xpath and xpath_double issues) and compare against Spark's XPathInt/XPathIntEvaluator. Register xpath_int alongside the other XML functions, narrowing the double with as i32, and add #[user_doc]. Add crates/sqllogictest/test_files/xml/xpath_int.slt with the saturation, truncation, NaN and NULL cases listed here; done when those SLT tests pass.

索引モデルが issue の本文から書いたものです。

説明

enhancement

Part of #271 and apache/datafusion-comet#7300.

What the function does

xpath_int(xml, path) evaluates an XPath 1.0 expression, converts the result with XPath number() into a
Java Double, and narrows it with Double.intValue(), giving an INT. Both arguments are strings
(collation-aware from 4.0), and path must be foldable. The result is always nullable. Available since Spark
2.0.0.

The number() conversion is in the xpath_double issue. Parsing, DTD and entity handling, namespaces, NULL
handling and errors are in the xpath issue. This issue covers only the double-to-int step, which is Java's
narrowing conversion (int) d:

  • NaN becomes 0;
  • values are truncated toward zero;
  • out-of-range values saturate at Integer.MAX_VALUE / Integer.MIN_VALUE, and so do +/-Infinity.

This matches Rust's d as i32. Nothing raises an error, and ANSI mode has no effect.

Examples
SELECT xpath_int('<a><b>1</b><b>2</b></a>', 'sum(a/b)');
-- 3
SELECT xpath_int('<a>this is not a number</a>', 'a');
-- 0
SELECT xpath_int('<a>this 2 is not a number</a>', 'a');
-- 0
SELECT xpath_int('<a><b>2000000000</b><c>40000000000</c></a>', 'a/b * a/c');
-- 2147483647
SELECT xpath_int('<a>try a boolean</a>', 'a = 10');
-- 0
SELECT xpath_int('<a><b class="odd">1</b><b class="even">2</b><b class="odd">4</b><c>8</c></a>', 'a/b');
-- 1
SELECT xpath_int('<a><b class="odd">1</b><b class="even">2</b><b class="odd">4</b><c>8</c></a>', 'sum(a/*)');
-- 15
SELECT xpath_int('<a><b class="odd">100000</b><b class="even">2</b><b class="odd">4</b><c>8</c></a>', 'sum(a/b[@class="odd"])');
-- 100004

These come from the ExpressionDescription, the Hive udf_xpath_int golden files run by
HiveCompatibilitySuite, and XPathExpressionSuite.

Edge cases to test
  • Saturation at both ends: 8.0E19 gives 2147483647 (above). By the same rule, -1 * a/b * a/c gives
    -2147483648, 1 div 0 gives 2147483647, and -1 div 0 gives -2147483648.
  • Truncation: <a>2.7</a> gives 2 and <a>-2.7</a> gives -2, by code reading. Note that XPath round()
    and floor() give different results, so test xpath_int(x, 'round(a)') as well.
  • NaN gives 0 (non-numeric text, 0 div 0, and the empty node-set, which is NaN by XPath 1.0 rules).
    The usage string says "zero if no match is found, or a match is found but the value is non-numeric".
  • Values just at and beyond 2^31: 2147483647, 2147483648 and -2147483649.
  • NULL or '' arguments give NULL. A non-literal path gives DATATYPE_MISMATCH.NON_FOLDABLE_INPUT.
    Malformed XML and an invalid path raise runtime errors (see the xpath issue).
Differences across Spark versions

None found beyond the shared ones in the xpath issue.

Implementation notes
  • Spark: XPathInt in sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala.
    It calls XPathIntEvaluator (ret.intValue()) in .../xml/XmlExpressionEvalUtils.scala.
  • DataFusion core has no equivalent.
  • Reuse the shared number() evaluator from the xpath and xpath_double issues in
    crates/spark/src/function/xml/, and narrow with as i32. Rust's saturating float-to-int cast matches
    Java's here.
  • Tests: add crates/sqllogictest/test_files/xml/xpath_int.slt and document the function with #[user_doc].

This issue was generated by an LLM (Claude) from the Apache Spark source code and tests. Examples come from Spark's ExpressionDescription examples, test suites and .sql.out golden files, but please verify them against Spark before relying on them.

主要言語
Rust
スター
7
フォーク
15
平均マージ
16時間 43分
マージ済み PR（30日）
26

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

apache/datafusion-spark のほかの issue

apache/datafusion-spark の issue をすべて見る

似ている issue

Rust の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。