Implement Spark-compatible `conv`
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
調査の方向性
Start by reading the sibling implementations hex, unhex and bin under crates/spark/src/function/math/ to copy the UDF registration and #[user_doc] patterns, then port Spark's NumberConverter using u64/unsigned division and wire the overflow error to datafusion.execution.enable_ansi_mode. Enable the commented queries in crates/sqllogictest/test_files/math/conv.slt (fix the second one's missing third argument) and extend it with the listed edge cases. Done means conv is registered, documented, and the slt file passes with ANSI both on and off.
索引モデルが issue の本文から書いたものです。
説明
Part of #174 and apache/datafusion-comet#7300.
What the function does
conv(num, from_base, to_base) converts the number written in num from base from_base to base to_base and returns it as a string. The logic is NumberConverter.convert, ported from Hive's UDFConv: the input is parsed into an unsigned 64-bit value; a positive to_base prints that value unsigned, a negative to_base prints it signed. Digits above 9 are printed in upper case. Available since 1.5.0.
num is implicitly cast to STRING (so conv(-10, 16, -10) works) and both bases to INT. The result type is the type of num (STRING; collation-aware in 4.0+). The result is NULL if any argument is NULL, if a base is out of range (from_base not in 2..36 or |to_base| not in 2..36), or if num is empty after trimming. Overflow while parsing gives -1 (all bits set) with ANSI off and an error with ANSI on.
Examples
SELECT conv('100', 2, 10);
-- 4
SELECT conv(-10, 16, -10);
-- -16
SELECT conv('3', 10, 2);
-- 11
SELECT conv('-15', 10, -16);
-- -F
SELECT conv('-15', 10, 16);
-- FFFFFFFFFFFFFFF1
SELECT conv('big', 36, 16);
-- 3A48
SELECT conv('11abc', 10, 16);
-- B
SELECT conv('9223372036854775808', 10, 16);
-- 8000000000000000
SELECT conv('92233720368547758070', 10, 16);
-- FFFFFFFFFFFFFFFF (ANSI off)
-- error ARITHMETIC_OVERFLOW (ANSI on)
SELECT conv('-9223372036854775807', 36, 10);
-- 18446744073709551615 (ANSI off)
Edge cases to test
- NULL in each argument returns NULL.
from_base1 or 37,to_base37 / -37 / 0 / 1 / -1 return NULL (conv('1234', 10, 37)is NULL).conv('', 10, 16)is NULL. - Trimming: only ASCII spaces (0x20) are removed (
UTF8String.trim).conv(' 10 ', 10, 2)is1010; a leading tab is an invalid digit, so the result is0. - Invalid digits: parsing stops at the first character that is not a digit in
from_base, and the valid prefix is converted (conv('11abc', 10, 16)isB). No valid digits gives0(conv('zz', 10, 10);conv('-', 10, 10)). - Case: lower- and upper-case letters are accepted as digits; output letters are upper case.
- Negative input with positive
to_baseis printed as an unsigned two's-complement value (FFFFFFFFFFFFFFF1); with negativeto_baseas signed (-F). - Overflow with ANSI off saturates to
-1(all bits) and then follows the sign rules:conv('9223372036854775807', 36, 10)andconv('-9223372036854775807', 36, 10)are18446744073709551615;conv('100000000000000000000000000000000000000000000000000000000000000000', 2, 8)is1777777777777777777777. - Overflow with ANSI on (
spark.sql.ansi.enabled=true, the 4.0+ default):ARITHMETIC_OVERFLOW(SQLSTATE 22003)Overflow in function conv(). If necessary set "spark.sql.ansi.enabled" to "false" to bypass this error., also for-92233720368547758070. Long.MinValuewithto_base = -2: the longest output (64 digits plus-).- Non-ASCII characters in
numare invalid digits (the UTF-8 bytes are checked one at a time). - Integer and DECIMAL
numarguments are cast to string first (conv(1.5, 10, 2)parses1.5, stops at., and returns1). - Column bases (they are not required to be literals).
Differences across Spark versions
- 4.0: ANSI on by default, so overflow fails by default instead of returning
FFFFFFFFFFFFFFFF-style results; collation-awarenum(result type followsnum). - 3.4 to 4.2 share the same
NumberConverterlogic; ANSI overflow checking exists in all of them.
Implementation notes
- Spark:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala,Conv; logic insql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala; error fromQueryExecutionErrors.overflowInConvError. - DataFusion core has no
conv.datafusion-sparkhashex,unhexandbinincrates/spark/src/function/math/; none does arbitrary-base conversion. - Port
NumberConverterdirectly (unsigned arithmetic withu64,Long.divideUnsignedequivalents), including the stop-at-invalid-digit and overflow-to--1behaviour. Usedatafusion.execution.enable_ansi_modefor the overflow error. - Tests: the placeholder
crates/sqllogictest/test_files/math/conv.sltexists with commented-out queries (note the second one drops the third argument); enable and extend it. Document with#[user_doc].
This issue was generated by an LLM (Claude) from the Apache Spark source code and tests. Examples come from Spark's ExpressionDescription examples, test suites and .sql.out golden files, but please verify them against Spark before relying on them.
- 主要言語
- Rust
- スター
- 7
- フォーク
- 15
- 平均マージ
- 16時間 43分
- マージ済み PR(30日)
- 26
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
apache/datafusion-spark のほかの issue
-
enhancement
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
apache/datafusion-spark#287 ·
メンテナーはふだん 1 日以内に返信
-
enhancement good first issue
難易度 2/5 1〜3時間 初心者へのやさしさ 80/100
apache/datafusion-spark#266 ·
メンテナーはふだん 1 日以内に返信
-
[Bug] make_dt_interval returns NULL for more than about 1.49 million days, Spark returns the interval対応中かも @Subodh-17 が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
apache/datafusion-spark#109 ·
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 5/5 1週間以上 初心者へのやさしさ 18/100
apache/datafusion-spark#299 ·
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 4/5 3〜5日 初心者へのやさしさ 35/100
apache/datafusion-spark#298 ·
メンテナーはふだん 1 日以内に返信
apache/datafusion-spark の issue をすべて見る
似ている issue
-
comp-rbac
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
ClickHouse/ClickHouse#131875 ·
メンテナーはふだん 1 日以内に返信
-
bug(python): read_transaction raises TypeError on a Rewrite with rewritten indices対応中かも @Borg93 が今日担当しました。 オープンbug
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
lance-format/lance#11117 ·
メンテナーはふだん 2 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
storytold/photocraft#15232 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
forge: fork preflight reads still send `requireCanonical: false`, which Rootstock rejects (-32603)対応中かも @Ynyesto が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
foundry-rs/foundry#18485 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
bondybondbond/rushcut#238 · コメント 1 件 ·