Implement Spark-compatible `regexp_extract_all`
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 22/100
調査の方向性
Start by reading RegExpExtractAll and RegExpExtractBase.checkGroupIndex in Spark's regexpExpressions.scala, then look at an existing string function under crates/spark/src/function/string/ to copy the registration, #[user_doc] and error-reporting patterns. This depends on the shared Java-regex compatibility helper proposed for rlike, so check its status before writing matching logic; the empty-match iteration rule and group index errors are the parts that must be reproduced exactly. Done means a new function plus crates/sqllogictest/test_files/string/regexp_extract_all.slt covering the NULL, no-match, out-of-range idx and optional-group cases above.
索引モデルが issue の本文から書いたものです。
説明
Part of #174 and apache/datafusion-comet#7300.
What the function does
regexp_extract_all(str, regexp[, idx]) returns an array with group idx of every match of the Java regular expression regexp in str. idx defaults to 1; 0 means the whole match. Spark loops Matcher.find() and, for each match, checks 0 <= idx <= groupCount and appends group(idx), or '' when the group did not participate. Available since 3.1.0.
str and regexp are implicitly cast to STRING and idx to INT. idx may be a column. Result type is ARRAY<STRING> (element type follows str's collation in 4.0+, containsNull = true but elements are never NULL). NULL if any argument is NULL. No match returns an empty array.
Examples
SELECT regexp_extract_all('100-200, 300-400', '(\\d+)-(\\d+)', 1);
-- ["100","300"]
SELECT regexp_extract_all('1a 2b 14m', '(\\d+)([a-z]+)', 0);
-- ["1a","2b","14m"]
SELECT regexp_extract_all('1a 2b 14m', '(\\d+)([a-z]+)', 2);
-- ["a","b","m"]
SELECT regexp_extract_all('a 2b 14m', '(\\d+)?([a-z]+)', 1);
-- ["","2","14"]
SELECT regexp_extract_all('1a 2b 14m', '(\\d+)?', 1);
-- ["1","","","2","","","14","",""]
SELECT regexp_extract_all('1a 2b 14m', '\\d+');
-- error INVALID_PARAMETER_VALUE.REGEX_GROUP_INDEX (groupCount 0, groupIndex 1)
SELECT regexp_extract_all('abc', col0, 1) FROM VALUES('], [') AS t(col0);
-- error INVALID_PARAMETER_VALUE.PATTERN
Edge cases to test
- NULL
str, NULLregexp, NULLidx(literal and column): NULL. - No match:
[].regexp_extract_all('100-200,300-400,500-600', '([a-z])', 1)is[](RegexpExpressionsSuite). - Group index validation only happens inside the match loop, so an out-of-range
idxraises no error when there is no match:regexp_extract_all('xyz', '\\d+', 1)returns[]. - Out-of-range or negative
idxwith a match:INVALID_PARAMETER_VALUE.REGEX_GROUP_INDEX(SQLSTATE 22023), messageThe value of parameter(s) `idx` in `regexp_extract_all` is invalid: Expects group index between 0 and 2, but got 3. - Optional group that did not participate yields
'', not NULL (see the(\\d+)?([a-z]+)example). - Empty pattern: matches at every position, so
regexp_extract_all('abc', '', 0)returns four empty strings. - Empty matches after a non-empty match: the
(\\d+)?example above has 9 elements because Java reports the empty match at the end of each\d+match. Theregexcrate does not report an empty match that starts where the previous match ended (itstestdata/empty.tomlgives 3 matches forb|onabc, Java finds 4), so a directcaptures_iterport returns fewer elements. Iteration must follow Java's rule. - Invalid pattern:
INVALID_PARAMETER_VALUE.PATTERNwithvaluethe quoted pattern, also for per-row patterns ('] [','], ['). - Non-literal pattern column with different patterns per row (Spark caches the last regex).
spark.sql.parser.escapedStringLiterals(default false) changes how the SQL literal is unescaped; the kernel sees the result. In.slt, DataFusion keeps backslashes literal ('(\d+)').- Java vs Rust pattern divergences to decline or test: lookaround / backreferences / atomic / possessive (Java only; e.g.
(?=[^ ]*[0-9])[^ ]+); ASCII\d\w\sin Java vs Unicode in Rust (regexp_extract_all('1\u0663', '\\d', 0)(U+0663 ARABIC-INDIC DIGIT THREE) is["1"]in Spark);.excludes\r,\u0085,\u2028,\u2029in Java;$matches before a final line terminator in Java;(?i)ASCII-only in Java; inline flag lettersU/u/dmean different things or are unknown; named groups: Java(?<n>...)only, Rust also(?P<n>...); both number named groups in order, sogroupCountmatches for accepted patterns. - Unicode / supplementary characters in
str(Java iterates UTF-16 but never splits a surrogate pair for.). UTF8_LCASEcollation (4.0+) compiles withCASE_INSENSITIVE | UNICODE_CASE.
Differences across Spark versions
- 3.4: group index errors were
_LEGACY_ERROR_TEMP_2006(The specified group index cannot be less than zero.) and_LEGACY_ERROR_TEMP_2007(Regex group count is <groupCount>, but the specified group index is <groupIndex>.), bothSparkIllegalArgumentException. 3.5+ usesINVALID_PARAMETER_VALUE.REGEX_GROUP_INDEXfor both cases. - 4.0: collation-aware inputs; array element type follows
str.
Implementation notes
- Spark:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala,RegExpExtractAll(baseRegExpExtractBase,RegExpExtractBase.checkGroupIndex). - DataFusion core has no equivalent.
regexp_matchreturns the capture groups of the first match only, uses Rust syntax, and returns NULL on no match. - Use the shared Java-regex compatibility helper proposed for
rlike: accept only a verified subset, return an "unsupported pattern" error otherwise (at planning time for literal patterns), and implement Java's empty-match iteration rule.regexp_countandregexp_substrare rewritten by Spark into this function andregexp_extract, so the same core can back them. - Belongs in
crates/spark/src/function/string/. Addcrates/sqllogictest/test_files/string/regexp_extract_all.sltand document with#[user_doc].
This issue was generated by an LLM (Claude) from the Apache Spark source code and tests. Examples come from Spark's ExpressionDescription examples, test suites and .sql.out golden files, but please verify them against Spark before relying on them.
- 主要言語
- Rust
- スター
- 7
- フォーク
- 15
- 平均マージ
- 16時間 43分
- マージ済み PR(30日)
- 26
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
apache/datafusion-spark のほかの issue
-
enhancement
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
apache/datafusion-spark#287 ·
メンテナーはふだん 1 日以内に返信
-
enhancement good first issue
難易度 2/5 1〜3時間 初心者へのやさしさ 80/100
apache/datafusion-spark#266 ·
メンテナーはふだん 1 日以内に返信
-
[Bug] make_dt_interval returns NULL for more than about 1.49 million days, Spark returns the interval対応中かも @Subodh-17 が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
apache/datafusion-spark#109 ·
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 5/5 1週間以上 初心者へのやさしさ 18/100
apache/datafusion-spark#299 ·
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 4/5 3〜5日 初心者へのやさしさ 35/100
apache/datafusion-spark#298 ·
メンテナーはふだん 1 日以内に返信
apache/datafusion-spark の issue をすべて見る
似ている issue
-
comp-rbac
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
ClickHouse/ClickHouse#131875 ·
メンテナーはふだん 1 日以内に返信
-
bug(python): read_transaction raises TypeError on a Rewrite with rewritten indices対応中かも @Borg93 が今日担当しました。 オープンbug
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
lance-format/lance#11117 ·
メンテナーはふだん 2 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
storytold/photocraft#15232 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
forge: fork preflight reads still send `requireCanonical: false`, which Rootstock rejects (-32603)対応中かも @Ynyesto が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
foundry-rs/foundry#18485 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
bondybondbond/rushcut#238 · コメント 1 件 ·