Angular CLI can copy files from outside the workspace root through symlinked asset directories
まだ誰も着手していません。
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 52/100
- issue の種類
- バグ
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- angular, typescript
- 領域
- build-system, cli, security
調査の方向性
Start by reproducing the six-command example with Angular CLI 22.2.0, then inspect the application builder's asset handling and schema.json, including the schema registry's Ajv setup. Check how symlinked asset directories and the followSymlinks option are passed to globbing. Done means the documented default prevents copying files outside the workspace while explicitly configured behavior remains covered by tests.
索引モデルが issue の本文から書いたものです。
説明
Command
build
Is this a regression?
- Yes, this behavior used to work in the previous version
The previous version in which this bug was not present was
No response
Description
ng build can copy files from outside the workspace into the build output when an asset directory is a symbolic link.
The application builder checks that every asset path stays inside the workspace root before globbing it:
if (!isSubDirectory(root, entry.input)) {
throw new Error(`The ${entry.input} asset path must be within the workspace root.`);
}
const cwd = path.resolve(root, entry.input);
const files = await glob(entry.glob, {
cwd,
dot: true,
ignore: entry.ignore ? defaultIgnore.concat(entry.ignore) : defaultIgnore,
followSymbolicLinks: entry.followSymlinks,
});
That check is lexical. isSubDirectory() resolves both operands with resolve(), compares them with relative(), and never calls realpath:
function isSubDirectory(parent, child) {
const resolvedParent = resolve(parent);
const resolvedChild = resolve(parent, child);
const relativePath = toPosixPath(relative(resolvedParent, resolvedChild));
return relativePath !== '..' && !relativePath.startsWith('../') && !isAbsolute(relativePath);
}
A symlink inside the project resolves inside the workspace root, passes the check, and is then used as the globber's cwd, which reads through it to the real target.
Whether the globber walks through it depends on followSymlinks, and the value that arrives there is not the documented one. schema.json declares:
"followSymlinks": {
"type": "boolean",
"default": false,
"description": "Allow glob patterns to follow symlink directories. This allows subdirectories of the symlink to be searched."
}
The schema registry builds Ajv without useDefaults:
this._ajv = new ajv.default({
strict: false,
loadSchema: (uri) => this._fetch(uri),
passContext: true,
verbose: true,
});
so schema defaults are never written into the options object. When the option is not set, entry.followSymlinks is undefined, and tinyglobby treats undefined the same as true:
followSymbolicLinks: undefined -> [ 'link/secret.txt' ]
followSymbolicLinks: false -> [ ]
followSymbolicLinks: true -> [ 'link/secret.txt' ]
The documented default is false. The effective default is true.
The containment check does hold for the direct form, which is what shows it is meant to hold:
assets: [{ "glob": "**/*", "input": "../../../outside" }]
An unhandled exception occurred: The ../../../outside asset path must be within the workspace root.
The same target reached through a symlink is copied with no warning and a successful build.
The configuration ng new generates already globs the whole public/ directory, so angular.json does not need to change:
"assets": [{ "glob": "**/*", "input": "public" }]
A symbolic link is a git object of mode 120000 whose content is a path string, so it survives clone. Nothing is executed during the build, so npm ci --ignore-scripts does not change the outcome.
Minimal Reproduction
See https://github.com/SkyZeroZx/angular-cli-symlink-asset-escape-poc
The same thing reproduces on a stock application in six commands:
npx @angular/[email protected] new repro-app --defaults --skip-git
cd repro-app
mkdir -p /tmp/outside-the-workspace
echo "this file is outside the Angular workspace" > /tmp/outside-the-workspace/secret.txt
ln -s /tmp/outside-the-workspace public/docs
ng build
find dist -name 'secret.txt'
The build completes normally and the file from outside the workspace is in the output:
dist/repro-app/browser/docs/secret.txt
Setting the option to the value the schema already documents as its default stops it:
assets: [{ "glob": "**/*", "input": "public", "followSymlinks": false }]
Exception or Error
Your Environment
Angular CLI 22.2.0
@angular/build 22.2.0
Node.js 24.21.0
npm 10.9.7
Linux x64
tinyglobby 0.2.17
Anything else relevant?
The symlink target can be an absolute path or a relative one such as ../../../.., so it does not need to know the layout of the machine that runs the build.
- 主要言語
- TypeScript
- スター
- 27k
- フォーク
- 11.8k
- 平均マージ
- 17時間 47分
- マージ済み PR(30日)
- 181
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
angular/angular-cli のほかの issue
-
area: @angular/build gemini-triaged
難易度 2/5 1〜3時間 初心者へのやさしさ 74/100
angular/angular-cli#33955 ·
-
area: @angular/cli gemini-triaged
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
angular/angular-cli#33055 · コメント 1 件 · リアクション 3 件 ·
-
area: @angular/build gemini-triaged
難易度 3/5 1〜2日 初心者へのやさしさ 68/100
angular/angular-cli#34166 · コメント 1 件 ·
-
area: @angular/build gemini-triaged severity5: regression
難易度 4/5 3〜5日 初心者へのやさしさ 75/100
angular/angular-cli#34163 ·
-
area: @angular/build gemini-triaged severity5: regression
難易度 4/5 3〜5日 初心者へのやさしさ 58/100
angular/angular-cli#34162 · コメント 1 件 · リアクション 1 件 ·
angular/angular-cli の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
receptron/mulmoterminal#2264 ·
-
documentation
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
components-web-app/docs#96 ·
-
enhancement
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
simonsobs/tileviewer#114 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100