chore(deps): use [workspace.dependencies] consistently and converge thiserror / heapless / rand versions

オープン
#457 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
45/100
issue の種類
リファクタリング
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
rust
領域
build-system

調査の方向性

Start by comparing the root Cargo.toml workspace dependencies with the crate manifests listed in the issue, then inspect Cargo.lock for the named version splits. Work one dependency at a time, as suggested, and check the affected manifests and tests for compatibility. Done means first-party dependencies consistently use workspace declarations where possible and the specified version splits are resolved or documented as required.

索引モデルが issue の本文から書いたものです。

説明

dependencies

Problem

The root Cargo.toml declares a [workspace.dependencies] table, but many crates re-declare the same dependencies with their own version strings, so the table is not the single source of truth it looks like.

Re-declared instead of workspace = true
  • tokio: aimdb-tcp-connector, aimdb-uds-connector, aimdb-serial-connector, aimdb-websocket-connector, aimdb-client, tools/aimdb-cli, examples/serve-records-http-demo ("1"); aimdb-sync ("1.40"); tools/aimdb-mcp, examples/remote-access-demo ("1.48"). Workspace says 1.49.
  • serde / serde_json: about a dozen manifests (aimdb-tokio-adapter, aimdb-uds-connector, aimdb-websocket-connector, aimdb-client, aimdb-sync, aimdb-cdr, aimdb-data-contracts, aimdb-zenoh-connector, tools/aimdb-cli, tools/aimdb-mcp, examples/remote-access-demo).
  • futures, tracing, clap, anyhow, log: aimdb-core, aimdb-client, aimdb-mqtt-connector, aimdb-embassy-adapter, aimdb-bench, aimdb-websocket-connector, aimdb-tokio-adapter, tools/aimdb-cli, tools/aimdb-mcp, and two examples.
  • embassy-sync, embassy-time, embassy-net: aimdb-mqtt-connector/Cargo.toml:157-164.
Real version splits inside our own crates
  • thiserror: aimdb-client, tools/aimdb-cli, tools/aimdb-mcp are on 1.x; workspace, aimdb-core and aimdb-sync are on 2.x. Both end up in Cargo.lock.
  • heapless: workspace (used by aimdb-knx-connector, aimdb-mqtt-connector, two embassy demos) is 0.8; aimdb-core, aimdb-embassy-adapter and aimdb-tcp-connector declare 0.9 directly. Part of this is forced (mountain-mqtt packet types take heapless 0.8 Vec; embassy-net uses 0.9), so it may not be fully removable.
  • rand: aimdb-mqtt-connector dev-depends on 0.8; aimdb-embassy-adapter, tools/embedded-check-fixture and the embassy demos use 0.10.1.

For context, Cargo.lock has 58 of 643 crates in more than one version. Most of the rest is transitive (zenoh, axum — e.g. three tungstenite versions via zenoh-link-ws, our direct 0.26, and axum) and out of our hands.

Suggested work

  1. Move each first-party use of a workspace-declared dependency to { workspace = true, features = [...] }, adding the missing ones (e.g. heapless 0.9 under a second alias) to the table.
  2. Bump aimdb-client, aimdb-cli and aimdb-mcp to thiserror 2.
  3. Bump the rand dev-dependency in aimdb-mqtt-connector to 0.10 if the tests allow.
  4. Decide whether heapless 0.8 can be confined to the crates that need it for mountain-mqtt.

Mechanical, but touches many manifests; best done in one PR per dependency.

Notes

Derived from the manifests and Cargo.lock at d9c7be0. cargo tree was not run (the embassy git patch could not be fetched offline), so parent crates were read from the lockfile.

主要言語
Rust
スター
101
フォーク
20
平均マージ
2時間 33分
マージ済み PR(30日)
90

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

aimdb-dev/aimdb のほかの issue

aimdb-dev/aimdb の issue をすべて見る

似ている issue

Rust の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。