refactor(cli): keep each tool's formats in its own profile

オープン
#1,143 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
18/100
issue の種類
リファクタリング
明瞭さ
おおむね明確
活発さ
活発
技術スタック
typescript
領域
cli, tooling

調査の方向性

Start with cli/tests/architecture/tool-addition-cost.arch.test.ts and the rules in cli/.claude/rules/00-architecture/0-hexagonal.md to see what the guardrail checks. Then trace the tool-named identifiers in formats/opencode-mcp-merge.ts, formats/vscode-mcp-merge.ts and formats/agent-frontmatter-strip.ts, and their callers. Done means the application/ and domain/formats/ baseline is empty and the golden snapshot is unchanged. This depends on #1141, which is not merged yet.

索引モデルが issue の本文から書いたものです。

説明

Problem

The CLI's own rule says application code never branches on the targeted tool and reads its capability instead (cli/.claude/rules/00-architecture/0-hexagonal.md), and a tool may only be named in its profile (cli/tests/architecture/tool-addition-cost.arch.test.ts). That test only sees a tool named in a string literal. Identifiers escape it: measured, 30 files outside src/contexts/tools/domain/profiles/ carry a tool name in what they declare or import, 9 of them in an application/ layer. A second host that needs the same behaviour means editing application code again.

#1141 moves every hook format into its tool's profile, hands the project-hooks format through PluginsCapability, and adds the guardrail for application/ and domain/formats/, with today's remaining violations as a baseline that may only shrink. This issue empties that baseline.

Scope
  • OpenCode's MCP merge: formats/opencode-mcp-merge.ts, called by name from install-runtime-config-use-case.ts, flat-mcp-materializer.ts, plugin-remove-use-case.ts and project-plugin-cleanup.ts.
  • formats/vscode-mcp-merge.ts and formats/agent-frontmatter-strip.ts (Copilot and Cursor agent frontmatter).
  • clean-user-scope-use-case.ts (purgeCursorUserScopeFiles), telemetry-on-use-case.ts (claudeSettings), flat-build-strategy.ts (the Claude root rewrite).
  • Same method as #1141: move each tool's format into its profile, expose what the application needs through the capability, behaviour unchanged, the golden snapshot identical.
Acceptance criteria
  • The guardrail's baseline for application/ and domain/formats/ is empty.
  • No application file imports a module from a tool's profile or a function named after a tool.
  • The golden snapshot is unchanged, and the CLI suite and the touched mutation scopes hold their floors.
Prior art in this repo
  • #1141 and the guardrail it adds.
  • cli/.claude/rules/00-architecture/0-hexagonal.md, 0-contexts.md; tool-addition-cost.arch.test.ts, context-boundary.arch.test.ts.
Out of scope
  • The composition root (src/runtime/wiring/) and readers whose job is one tool's own files (telemetry transcript readers, host plugin registry readers): naming the tool is their purpose.
主要言語
TypeScript
スター
481
フォーク
45
平均マージ
1日 13時間
マージ済み PR(30日)
91

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

ai-driven-dev/framework のほかの issue

ai-driven-dev/framework の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。