spike(aidd-ui): decide what the experience review adds over the code review

オープン
#1,122 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
35/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
typescript

調査の方向性

Start with plugins/aidd-ui/skills/03-review, its references/findings.md and references/fingerprint.md, then compare its findings with aidd-dev:05-review on at least two real projects, one with a UI system and one without. Read 01-system/references/lifecycle.md and delta-path.md for the pending-delta decision. Done means a per-project findings table, an evidence-backed placement recommendation, and a specified delta outcome—or a reason none is needed—and removal steps if the review is not justified.

索引モデルが issue の本文から書いたものです。

説明

Problem

aidd-ui ships 03-review, an experience review that produces evidence-pinned, nonnormative findings (PR #708). The code side already has aidd-dev review, which reads the same artefacts. It is not established that the UI review finds anything the code review misses, nor where it should sit.

Three overlaps are unresolved:

  • The review could target the UI system and the feature's UI contract (is the contract coherent and complete), or the implementation (does the code respect it), or both. The code review has to read the same artefacts either way.
  • A review that always reports something is cheap to produce and useless to read. If it repeats the same findings on every run, the fix belongs in the producing skills; it earns its place only if it finds project-specific things that change from run to run.
  • The design lifecycle implements first, reviews, then validates the delta. The case of a blocking review is undefined: what becomes of the pending delta.

A reviewer in a community lab on the plugin framed it as two review levels, and asked whether the macro audit of an app, independent of any feature, is a better shape than a per-feature review.

Scope

A spike. Run 03-review on at least two real projects (one with a UI system, one without) alongside the code review and answer:

  • Which findings only the UI review produced, which only the code review, and which both.
  • Whether the same findings come back on every run (a signal to fix the producing skill instead).
  • Where it should sit: a per-feature review, a standing audit of the system, or both.
  • What happens to a pending delta after a blocking review: kept, reworked, or dropped, and who decides.
Acceptance criteria
  • A table of findings per project, split by which review produced them.
  • A recommendation on placement (feature review, audit, both) with the evidence behind it.
  • The outcome of a pending delta after a blocking review is specified in the delta lifecycle, or the spike states why none is needed.
  • If the review is not justified, the issue lists what to remove rather than leaving it.
Prior art in this repo
  • PR #708 (draft): plugins/aidd-ui/skills/03-review, references/findings.md, references/fingerprint.md; delta lifecycle in 01-system/references/lifecycle.md and delta-path.md.
  • aidd-dev:05-review: the code review the UI review overlaps with.
  • #918 (open): acceptance evidence across real browser journeys, adjacent for rendered-browser review, which PR #708 lists as follow-up.
Out of scope
  • Rendered-browser review and visual regression: tracked separately (#918, PR #708 follow-ups).
  • Changing aidd-dev review beyond reading the UI artefacts.
主要言語
TypeScript
スター
481
フォーク
45
平均マージ
1日 13時間
マージ済み PR(30日)
91

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

ai-driven-dev/framework のほかの issue

ai-driven-dev/framework の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。