Hacktoberfest 2026:メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

Add CI, and symmetry tests that check the port against vhlab-library-matlab

オープン
#7 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
35/100
issue の種類
機能追加
明瞭さ
説明が足りない
活発さ
活発
技術スタック
github-actions, python
領域
ci-cd, testing

調査の方向性

Start with requirements.txt, tests/, the existing unittest command, and vhlib/md/vhlib_matlab_python_bridge.yaml; the issue also requires checking the companion MATLAB issue. Resolve the dependency, linter, fixture, and cross-repository workflow decisions before implementation. Done means push and pull-request CI runs the tests and reports structural or numerical drift against vhlab-library-matlab.

索引モデルが issue の本文から書いたものです。

説明

Neither this repository nor vhlab-library-matlab has any CI. There is no .github/ directory in either, so nothing runs on push or on a pull request, and nothing checks that the MATLAB and Python implementations still agree.

A companion issue covers the MATLAB side: VH-Lab/vhlab-library-matlab#8.

Current state here

  • No workflows, no .github/.
  • No packaging metadata — no setup.py, no pyproject.toml. requirements.txt lists vhlab-toolbox-python, numpy, scipy, pyyaml.
  • tests/ now exists (added in #5) with 18 tests under unittest: tests/test_bridge.py validating the bridge contract files, and tests/test_neural_response_significance.py.
  • Run locally with python3 -m unittest discover -s tests.

1. CI for this repository

A GitHub Actions workflow on push and pull request that:

  • runs python3 -m unittest discover -s tests on a couple of Python versions;
  • installs vhlab-toolbox-python from GitHub rather than PyPI. This is the one thing that needs a decision before the workflow can be written — vlt is not importable in a clean environment today, so any test that touches it is currently unwritable, which is part of why the ported modules have so few tests. Either pin a git URL in requirements.txt or add a CI step that clones it.
  • optionally runs a linter. Worth deciding whether to adopt one at all before wiring it up; a linter that fails on existing code on day one gets switched off.

2. Symmetry tests

The bridge contract files added in #5 make part of this mechanical. Two distinct kinds, worth keeping separate:

Structural symmetry — cheap, needs no MATLAB, can run in this repository's CI as soon as the MATLAB repo is checked out alongside:

  • every matlab_path in every vhlib_matlab_python_bridge.yaml exists in vhlab-library-matlab;
  • every .m file in a ported area has an entry, so a function added on the MATLAB side shows up as a gap rather than silently;
  • matlab_last_sync_hash is compared against the current MATLAB HEAD, and the test reports which ported functions have drifted since they were last checked. This is the field that makes drift detectable rather than assumed, and it is worthless unless something reads it.

Numerical symmetry — the same fixture through both implementations, asserting the same answer. Running MATLAB inside this repository's CI is the expensive option; the cheaper one is golden fixtures: a MATLAB script generates reference inputs and outputs, commits them as JSON, and the Python tests compare against them. The MATLAB half of that belongs in the companion issue.

Good first candidates, because they are pure functions with no dirstruct or file-system dependency:

  • neural_response_significance — has Python tests as of #5, but they check against an ANOVA computed from the definition, not against MATLAB's anova1. A golden fixture would close that gap.
  • cellname2nameref / nameref2cellname / cellname2date — string round-trips.
  • filter_by_index / filter_by_reference — where the 1-based to 0-based index decision could silently go wrong.
  • read_stimtimes_txt and write_stimtimes_txt — round-trip a file written by one and read by the other.

spiketriggeredaverage is the one place where symmetry is not expected: the Python signature deliberately diverges (raw arrays instead of measureddata/spikedata objects, three outputs instead of six), as recorded in vhlib/md/vhlib_matlab_python_bridge.yaml. Any symmetry harness needs a way to mark that, rather than reporting it as a failure forever.

Note

Whatever shape this takes, it should apply to vhlab-toolbox-python too, which has the same gap.

🤖 Generated with Claude Code

https://claude.ai/code/session_01QJXrVvcT4jif5nwu5ihLkV

主要言語
Python
スター
0
フォーク
1
PR マージ指標
30日以内にマージされた PR はありません

環境構築

このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

VH-Lab/vhlab-library-python のほかの issue

VH-Lab/vhlab-library-python の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。