Bounding-box subset allocates memory proportional to the whole mesh, not the crop
メンテナーはふだん 2 日以内に返信
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 30/100
- issue の種類
- バグ
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- numpy, python
- 領域
- data, performance
調査の方向性
Start with uxarray/grid/bounds.py:84-96 and the subset.bounding_box entry point, then run the provided MCVE at both mesh sizes. Review the proposed prefiltering, persisted-connectivity, and file-level SCRIP approaches, including the measurements from #1779. Done means a regional crop no longer incurs memory proportional to the full mesh, with the crop results still matching existing behavior.
索引モデルが issue の本文から書いたものです。
説明
Version
2026.9.0 (and main)
How did you install UXarray?
Source
What happened?
Two separate costs make a regional crop of a large SCRIP mesh scale with the whole mesh rather than the crop. The first is fixable in the subsetting code; the second is a reader/representation question and is the harder one.
1. Grid.bounds is computed for every face before any filtering.
subset.bounding_box filters on face_bounds_lon/lat, which come from _populate_face_bounds (uxarray/grid/bounds.py:84-96). That materializes the node coordinate and connectivity arrays with .values regardless of how the grid was opened. Measured, 12-corner SCRIP, crop fixed at ~0.006% of the mesh:
| n_face | crop | memory |
|---|---|---|
| 400,000 | 26 faces | +0.076 GiB |
| 1,600,000 | 116 faces | +0.851 GiB |
Asking for a smaller box does not help — the index is built before the box is consulted.
2. face_node_connectivity is a lazy graph over the dedup, so any slice replays it.
On the 63 GB CONUS-RRM np4 grid (299,999,162 faces), after open_grid leaves ~119 GiB resident, even a contiguous conn[:30M] kills a 236 GiB worker: computing the connectivity re-reads the 53.6 GiB corner arrays.
The decisive measurement is crop-size independence:
| crop | candidates | outcome |
|---|---|---|
| Texas | 30,914,134 | killed on slice |
| Key West | 15,866 | killed on slice |
A 2000× smaller crop fails identically, so the cost is not the crop.
For contrast, the pg2 twin — same 200 m geometry, 4 corners instead of 12 — subsets in 113 s.
What did you expect to happen?
That a regional crop costs something proportional to the region, and that a mesh which can be opened can also be subset.
Can you provide a MCVE to reproduce the bug?
"""Memory cost of a bbox subset scales with the mesh, not the crop."""
import gc, os, sys, tempfile, time
from pathlib import Path
import numpy as np, psutil, uxarray as ux, xarray as xr
P = psutil.Process(os.getpid())
rss = lambda: P.memory_info().rss / 1024**3
n_face, n_corner = int(sys.argv[1]), 12
tmp = Path(tempfile.mkdtemp()) / "mesh.nc"
rng = np.random.default_rng(0)
clon, clat = rng.uniform(0, 360, n_face), rng.uniform(-85, 85, n_face)
off = np.linspace(0, 2 * np.pi, n_corner, endpoint=False)
xr.Dataset({
"grid_corner_lon": (("grid_size", "grid_corners"),
(clon[:, None] + 0.02 * np.cos(off)[None, :]) % 360.0),
"grid_corner_lat": (("grid_size", "grid_corners"),
np.clip(clat[:, None] + 0.02 * np.sin(off)[None, :], -90, 90)),
"grid_center_lon": (("grid_size",), clon),
"grid_center_lat": (("grid_size",), clat),
"grid_imask": (("grid_size",), np.ones(n_face, "i4")),
"grid_area": (("grid_size",), np.zeros(n_face)),
}).to_netcdf(tmp)
del clon, clat; gc.collect()
grid = ux.open_grid(str(tmp), chunks="auto")
base = rss(); t0 = time.perf_counter()
sub = grid.subset.bounding_box(lon_bounds=[-1.0, 1.0], lat_bounds=[-1.0, 1.0])
print(f"n_face={n_face:,} crop={int(sub.n_face):,} +{rss()-base:.3f} GiB "
f"{time.perf_counter()-t0:.1f}s")
Run at 400000 and 1600000: per-face cost stays flat while the crop stays at ~0.006%.
Possible directions
Not prescribing a fix; each is a design call.
- Prefilter on face centres before computing exact bounds — addresses (1). #1779 does this and measures 0.84 GiB → 0.00 GiB at 1.6M faces.
- Persist connectivity after dedup, so slicing does not replay the graph — addresses (2).
- Subset SCRIP at the file level, bypassing global connectivity entirely.
grid_center_lat/longives candidates andgrid_corner_lat/lonsettles them exactly; neither needs node dedup. Prototyped outside uxarray against the 63 GB file: Key West returns 8,858 faces in 39 s at 0.47 GiB, verified to return the identical face set tosubset.bounding_boxon every SCRIP mesh small enough for both to run. The file ischunking=contiguous, so candidate rows are direct seeks. - Do not hold both coordinate representations:
node_x/y/zare derivable fromnode_lon/latand are ~46% of what survives a subset.
A narrower INT_DTYPE for connectivity would halve another array, but #1658 shows INT_FILL_VALUE does not survive that narrowing — mentioned only to rule it out.
- 主要言語
- Python
- スター
- 230
- フォーク
- 56
- 平均マージ
- 6日 3時間
- マージ済み PR(30日)
- 12
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
UXARRAY/uxarray のほかの issue
-
Update installation docs to include new conda recipes対応中かも @Sevans711 が 16 日前に担当しました。 オープンdocumentation
難易度 1/5 1時間未満 初心者へのやさしさ 82/100
UXARRAY/uxarray#1793 · コメント 1 件 · 担当者 1 名 ·
メンテナーはふだん 2 日以内に返信
-
developer experience
難易度 1/5 1時間未満 初心者へのやさしさ 90/100
メンテナーはふだん 2 日以内に返信
-
zonal_mean() and weighted_mean() should return the same type of object対応中かも @Sevans711 が 25 日前に担当しました。 オープンbug
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
UXARRAY/uxarray#1733 · 担当者 1 名 ·
メンテナーはふだん 2 日以内に返信
-
documentation
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
メンテナーはふだん 2 日以内に返信
-
Neighborhood filter radii in kilometers対応中かも @cmdupuis3 が 3 日前に担当しました。 オープンimprovement
UXARRAY/uxarray#1824 · 担当者 1 名 ·
メンテナーはふだん 2 日以内に返信
UXARRAY/uxarray の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
noontide-co/mainbranch#1211 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
[1.x Bug] run-operation --sql reports success but rolls back writes on transaction-capable adaptersオープンtriage
難易度 2/5 1〜3時間 初心者へのやさしさ 64/100
dbt-labs/dbt#16784 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
bug needs-triage
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
メンテナーはふだん 1 日以内に返信
-
bug settings ui
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
DewaldOosthuizen/py-tray-command-launcher#162 ·
メンテナーはふだん 1 日以内に返信
-
run_all sleeps after the final job despite documenting delays between jobs対応中かも @Gambit-Checkmate が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 74/100