Allow package-private planning domain classes and methods

オープン
  • 何か問題がありますか？
#2,160 コメント 6 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 2 日以内に返信

まだ誰も着手していません。

  • #1 @theoema による — マージされずにクローズ
  • #2168 @theoema による — マージされずにクローズ

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
48/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
停滞
技術スタック
java
領域
backend

調査の方向性

Start by reading MemberAccessorValidator and ReflectionHelper to trace where non-public classes and methods are rejected or missed. Then inspect ReflectionBeanPropertyMemberAccessor and GizmoMemberAccessorImplementor to understand the existing fallback constraints. Done means package-private planning classes, getters, and setters are discoverable and usable without changing behavior for public classes.

索引モデルが issue の本文から書いたものです。

説明

Problem

Timefold requires all planning domain classes, getters, and setters to be public. This is enforced by MemberAccessorValidator, but the underlying accessor layer already handles non-public access — making this restriction unnecessary.

The contradiction

The reflection-based accessor already calls setAccessible(true) and creates a MethodHandle that works fine with non-public methods:

// ReflectionBeanPropertyMemberAccessor.java
public ReflectionBeanPropertyMemberAccessor(Method getterMethod, AnnotatedElement annotatedElement, boolean getterOnly) {
    this.getterMethod = getterMethod;
    MethodHandles.Lookup lookup = MethodHandles.lookup();
    this.getterMethod.setAccessible(true);                          // ← handles non-public
    this.getherMethodHandle = lookup.unreflect(getterMethod)        // ← creates fast MethodHandle
            .asFixedArity();
    // ...
}

At runtime, it invokes via MethodHandle, not raw Method.invoke():

public Object executeGetter(Object bean) {
    return getherMethodHandle.invoke(bean);  // MethodHandle — JIT-optimized to direct call
}

But MemberAccessorValidator rejects non-public members before the accessor ever gets a chance:

// MemberAccessorValidator.java — declaring class gate
private static void verifyDeclaringClassIsAccessible(Member member, String messagePrefix) {
    var declaringClass = member.getDeclaringClass();
    if (!Modifier.isPublic(declaringClass.getModifiers())) {
        throw new IllegalArgumentException(
                "%s is not accessible because its declaring class (%s) is not public."
                    .formatted(messagePrefix, declaringClass.getCanonicalName()));
    }
}

// MemberAccessorValidator.java — repeated across verifyFieldOrGetter, verifyIsVoidMethod,
// verifyIsPublicFieldOrHasReadMethod, verifyGetterSetterProperties
if (!Modifier.isPublic(method.getModifiers())) {
    throw new IllegalArgumentException(
            "%s is a getter method, but it is not public."
                .formatted(messagePrefix));
}

There's also a discovery-layer issue — ReflectionHelper uses Class.getMethod() which only returns public methods, so package-private getters are invisible before validation even runs.

What about Gizmo performance?

The Gizmo path generates bytecode with direct invokeVirtual instructions, which requires public access. However, the reflection path already uses MethodHandle — which the JVM JIT-compiles to the same direct call after warmup:

Path Runtime execution After JIT
Gizmo invokeVirtual bytecode direct call
Reflection (MethodHandle) MethodHandle.invoke() direct call (inlined)

For non-public members, falling back to the MethodHandle-based reflection path carries no meaningful performance penalty. The Gizmo implementor itself documents this constraint:

// GizmoMemberAccessorImplementor.java (line 353)
// The member MUST be public if not called in Quarkus
// (i.e. we don't delegate to the field getter/setter).
Why this matters

Package-private domain models are a standard Java encapsulation pattern. In modular codebases, it's common to keep domain classes package-private and expose only the API boundary publicly. Today you're forced to write:

// Everything must be public even though nothing outside this package needs access
public class Lesson {
    public Timeslot getTimeslot() { ... }
    public void setTimeslot(Timeslot timeslot) { ... }
}

This would enable:

class Lesson {
    Timeslot getTimeslot() { ... }
    void setTimeslot(Timeslot timeslot) { ... }
}
Scope

This is a small change — no behavior change for existing public classes, no performance impact, and the accessor infrastructure already supports it.

主要言語
Java
スター
1.8k
フォーク
242
平均マージ
2日 14時間
マージ済み PR（30日）
43

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

TimefoldAI/timefold-solver のほかの issue

TimefoldAI/timefold-solver の issue をすべて見る

似ている issue

Java の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。