A request aborted by the client is logged as an unhandled 500

オープン
#8,521 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

  • #8536 @mixelburg による — マージされずにクローズ

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
75/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
node.js, typescript
領域
api, backend

調査の方向性

Start with executeMiddleware in packages/start-server-core/src/createStartHandler.ts around lines 413, 436, and 475, then trace the rejection through requestHandler in packages/start-server-core/src/request-response.ts around lines 121-143. Reproduce the behavior with a delayed loader, a built server, and curl -m 0.2. Done means a client-aborted request ends quietly without the unhandled error log or a server-side 500 response.

索引モデルが issue の本文から書いたものです。

説明

What happens

When a client closes the connection while a request is still running, Start prints the abort reason as an unhandled error on the server, with status 500:

Error: aborted
    at abortIncoming (node:_http_server:921:17)
    ... 2 lines matching cause stack trace ...
    at TCP.<anonymous> (node:net:362:12) {
  cause: Error: aborted
      at abortIncoming (node:_http_server:921:17)
      at socketOnClose (node:_http_server:914:3)
      at Socket.emit (node:events:526:24)
      at TCP.<anonymous> (node:net:362:12) {
    code: 'ECONNRESET'
  },
  status: 500,
  statusText: undefined,
  headers: undefined,
  data: undefined,
  body: undefined,
  unhandled: true
}

Nobody receives the 500, because the client has gone. In production, every user who navigates away while a loader or server function is waiting prints one of these. It cannot be caught from application code. A request middleware that catches the abort and returns its own Response still gets the line, and so does a custom src/server.ts that wraps handler.fetch in a try/catch, because the error never leaves handler.fetch. Start returns a 500 Response and logs it on the way.

Why
  1. Once request.signal aborts, executeMiddleware throws signal.reason whatever the middleware returned: createStartHandler.ts L413, L436, L475.
  2. requestHandler passes the rejected promise to h3's toResponse with no config: request-response.ts L141.
  3. h3's prepareResponse treats anything that is not an HTTPError as unhandled, logs it with console.error unless config.silent is set, and answers 500.

The reason is whatever the server runtime aborts the signal with. Under srvx it is Node's socket error (Error: aborted, ECONNRESET). An AbortError would be logged the same way, since it is an Error and not an HTTPError.

This is close to #8155, which fixed the SSR render stream surfacing the same abort. That path is fixed in our versions. This one is the middleware runner's throw, which reaches h3 whatever the render does.

Steps
  1. A route whose loader calls a server function that waits for a few seconds, for example an upstream call with a long deadline.
  2. vite build, then start the built server.
  3. curl -m 0.2 http://localhost:3000/<that route>, so the client leaves while the loader waits.
  4. The server prints the error above. In our app the request middleware's own log line records the request as a 499 with aborted: true just before it, so the app did see the abort.
Expected

A request the client aborted ends quietly. Two possible shapes: requestHandler answers a bare response without calling h3 when request.signal.aborted and the rejection is request.signal.reason, or it passes h3 an onError that does the same.

Versions
  • @tanstack/react-start 1.168.56 (1.168.58 is the same: it depends on the same server core)
  • @tanstack/start-server-core 1.169.37 (latest). main at 3cdd1af04b has the same code.
  • h3-v2 ([email protected]), bundled by Start
  • nitro 3.0.260903-beta via nitro/vite, srvx 1.0.3
  • Node 24.21.0, macOS
主要言語
TypeScript
スター
15.3k
フォーク
1.9k
平均マージ
1日 5時間
マージ済み PR(30日)
46

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

TanStack/router のほかの issue

TanStack/router の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。