[svelte-query] Reactive options updates can cancel and restart an in-flight refetch without changing the query key or enabled value
まだ誰も着手していません。
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 48/100
- issue の種類
- バグ
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- typescript
- 領域
- frontend
調査の方向性
Start with the provided regression test as a .svelte.test.ts file in a Svelte-enabled Vitest setup using client/browser conditions and jsdom. Trace how createInfiniteQuery recomputes reactive options during the focus-triggered refetch, particularly cancellation and infinite-query page fetching. Done means the test completes without aborting the in-flight request and reports aborted: false with pages [0, 1].
索引モデルが issue の本文から書いたものです。
説明
Describe the bug
With createInfiniteQuery, updating reactive state used by the options accessor can cancel and restart an in-flight refetch, even though:
- The query key stays the same.
enabledremainstrue.- The QueryClient stays the same.
- The component remains mounted.
- No explicit cancellation or invalidation occurs.
For example, replacing reactive state { enabled: true } with a new { enabled: true } object during a focus-triggered refetch can abort the current request and restart fetching from the first page.
With two cached pages, the reproduction fetches pages [0, 0, 1] instead of [0, 1]. The first request's AbortSignal becomes aborted.
Your minimal, reproducible example
See tests below
Steps to reproduce
The regression test below uses only Svelte, TanStack Query and Vitest. Run it as a .svelte.test.ts file in a Svelte-enabled Vitest setup using the client/browser resolution conditions and jsdom.
import { expect, it, vi } from 'vitest'
import { flushSync } from 'svelte'
import {
QueryClient,
InfiniteQueryObserver,
createInfiniteQuery,
infiniteQueryOptions,
focusManager,
} from '@tanstack/svelte-query'
it('does not cancel a refetch when reactive options retain the same values', async () => {
let state = $state({ enabled: true })
let now = Date.now()
vi.spyOn(Date, 'now').mockImplementation(() => now)
const client = new QueryClient({
defaultOptions: {
queries: { staleTime: 60_000, retry: false },
},
})
client.mount()
const key = ['items'] as const
let response: ReturnType<typeof Promise.withResolvers<void>> | undefined
const reads: Array<{ page: number; signal: AbortSignal }> = []
const options = () =>
infiniteQueryOptions({
queryKey: key,
enabled: state.enabled,
initialPageParam: 0,
queryFn: async ({ pageParam, signal }) => {
reads.push({ page: pageParam, signal })
await response?.promise
return {
items: [pageParam],
next: pageParam === 0 ? 1 : undefined,
}
},
getNextPageParam: (page) => page.next,
})
// Load two pages, then leave the query unobserved.
const first = new InfiniteQueryObserver(client, options())
const stop = first.subscribe(() => {})
await vi.waitFor(() =>
expect(first.getCurrentResult().isSuccess).toBe(true),
)
await first.fetchNextPage()
stop()
// Return to the cached query after it becomes stale.
now += 60_001
const dispose = $effect.root(() => {
const query = createInfiniteQuery(options, () => client)
$effect(() => {
void query.data
void query.isFetchingNextPage
void query.fetchStatus
})
})
try {
flushSync()
await vi.waitFor(() => expect(reads).toHaveLength(4))
await vi.waitFor(() =>
expect(client.getQueryState(key)?.fetchStatus).toBe('idle'),
)
flushSync()
now += 60_001
reads.length = 0
response = Promise.withResolvers<void>()
focusManager.setFocused(false)
focusManager.setFocused(true)
await vi.waitFor(() => expect(reads).toHaveLength(1))
// Recompute options without changing enabled or query identity.
state = { enabled: true }
flushSync()
const aborted = reads[0]!.signal.aborted
response.resolve()
await vi.waitFor(() =>
expect(client.getQueryState(key)?.fetchStatus).toBe('idle'),
)
expect({
aborted,
pages: reads.map(({ page }) => page),
}).toEqual({
aborted: false,
pages: [0, 1],
})
} finally {
response?.resolve()
dispose()
client.clear()
client.unmount()
vi.restoreAllMocks()
focusManager.setFocused(true)
}
})
- Load two pages of an infinite query whose query function reads the provided
signal. - Unsubscribe, retaining the cached pages.
- Let the query become stale, mount it through
createInfiniteQuery, and allow its initial refetch to finish. - Let it become stale again and trigger a window-focus refetch.
- While the first page request is pending, replace reactive state read by the options accessor with an equivalent object. Keep the query key and
enabledvalue unchanged. - Observe that the pending request is aborted and the first page is requested again.
Expected behavior
The existing refetch should continue without cancellation or duplicate requests when the query identity and enabled state remain unchanged.
Expected: aborted: false, requested pages [0, 1].
Actual: aborted: true, requested pages [0, 0, 1].
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
- OS: Windows
- Reproduced using Vitest 4.1.11 with jsdom 30.0.1
Tanstack Query adapter
svelte-query
TanStack Query version
6.1.48
TypeScript version
6.0.3
Additional context
No response
- 主要言語
- TypeScript
- スター
- 50.3k
- フォーク
- 4.2k
- 平均マージ
- 22時間 33分
- マージ済み PR(30日)
- 214
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
TanStack/query のほかの issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
-
難易度 4/5 3〜5日 初心者へのやさしさ 45/100
-
難易度 4/5 3〜5日 初心者へのやさしさ 40/100
-
難易度 3/5 1〜2日 初心者へのやさしさ 78/100
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
vercel-labs/just-bash#464 ·
-
looksLikeSlug() is ASCII-only, so non-Latin entity slugs (e.g. Korean) skip exact match and collapse オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
-
難易度 1/5 1時間未満 初心者へのやさしさ 90/100
TanStack/tanstack.com#1293 ·