daemon inputs: link targets and the rest of the stat family (lstat, readlink, realpath, access) are no input yet

オープン
#142 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
35/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
javascript, node.js
領域
testing, tooling

調査の方向性

Start with packages/oracles/oracle-gaps/inputs.mjs and trace watchReads, inputHash, and servedHash; then read the oracle history and shard definitions in scripts/pr-shards.mjs and scripts/e2e-shards.mjs. Add the link and stat family as oracle histories first, following the listed RED, fix, GREEN, and mutant steps. Done means the new history fails against the current daemon, passes on shard 4 after the fix, and its mutant fails only that history.

索引モデルが issue の本文から書いたものです。

説明

Family: link targets and the stat family. lstat/lstatSync/fs.promises.lstat, readlink/readlinkSync/fs.promises.readlink, realpath/realpathSync/fs.promises.realpath, access/accessSync/fs.promises.access, the callback stat, and exists are not inputs. G42 says the stat family records existence, kind and link target. Today statSync, existsSync and promise stat key a path as fs:, by the file's text, not a file, or missing. Nothing records a link's target.

Gate kind link: tests/gate-link is a symbolic link to open or shut, two files with the same text. File b reads readlinkSync(new URL('./gate-link', import.meta.url)) and opens the gate when the target is open. The edit re-points the link, so no file's text changes. A second history, lstat, can test lstatSync(...).isSymbolicLink() against a link that the edit replaces with a file. writeFixture already writes links ({ link }).

Fix: a key link:<path>, hashed by the kind from lstat plus readlink's target, or missing. Wrap lstat* and readlink* to record it, and realpath* to record link: for each component (or the resolved path's fs:). Wrap access*, the callback stat and exists to record fs: (existence and kind). Add link: to inputHash and servedHash.

Authority: maintainer decision M 2026-11-16 "Every read is a daemon input" (the user ruled it with no exceptions), v21.2 R46, G42, I8. The watch family (watch, watchFile) stays no input (C-19).

Context: #133 records the six #55 fs calls on any path, node_modules included, plus environment variables, plugin inputs and directory listings (readdir/opendir, dir:/dirs: keys). The recorder is packages/oracles/oracle-gaps/inputs.mjs (watchReads), shared by the worker (capture-setup.mjs) and the CLI process (check.mjs). Keys are hashed by inputHash and looked up through servedHash. This family is still unbuilt, so I8 does not hold for it.

Oracle-first plan (the pattern from #133):

  1. Add a value to inputRead (drawn, appended; update the canary's inputRead line) and one constructed history appended at the end, with steps [inputGate, recheck]. It enters edit inputGate changed the cold result, an edit to the <kind> gate input changed the cold result and an unchanged check through the daemon computed nothing. Add it to scripts/pr-shards.mjs shard 4 (and a Windows shard) and to scripts/e2e-shards.mjs.
  2. RED: run pnpm exec vitest --run --config oracle-gaps/vitest.config.mjs gap-report-oracle -t "fixed seed 20261105: <name>" on the oracle-only commit. Expect incremental equals cold: "after inputGate, the daemon's report differs from the cold run's", with the daemon reusing killed where the cold run says survived.
  3. Fix in inputs.mjs (see below), then show GREEN on shard 4.
  4. Mutant: remove the new wrapper or key from watchReads. Only this history should fail.
主要言語
JavaScript
スター
5
フォーク
1
平均マージ
8時間 31分
マージ済み PR(30日)
60

環境構築

このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

TanStack/oracles のほかの issue

TanStack/oracles の issue をすべて見る

似ている issue

JavaScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。