A live query whose first on-demand subset load failed stays in error after a later load succeeds

オープン
  • 何か問題がありますか？
#2,271 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
54/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
typescript
領域
backend, databases

調査の方向性

Start with the named failure handling in db/src/query/live/collection-subscriber.ts and collection-config-builder.ts, then trace how a successful source refetch updates live query state. The issue includes a Vitest reproduction; run it to confirm the failure, then verify that after the retry succeeds the live query leaves error and exposes both rows.

索引モデルが issue の本文から書いたものです。

説明

  • I've validated the bug against the latest version of DB packages

Describe the bug

If a live query's first subset load fails, the live query is put into a fatal error state. A later successful load of the same subset (e.g. collection.utils.refetch(), or an invalidation) fetches the rows into the source collection, but the live query stays error with no rows. The only way back is to recreate the live query.

Tested with @tanstack/db 0.15.2, @tanstack/query-db-collection 1.4.8, @tanstack/query-core 5.104.5 (no related commits on main since 0.15.2).

To Reproduce

Drop-in vitest test:

import { expect, test } from "vitest";
import { createCollection, createLiveQueryCollection, eq } from "@tanstack/db";
import { QueryClient } from "@tanstack/query-core";
import { parseLoadSubsetOptions, queryCollectionOptions } from "@tanstack/query-db-collection";

const tick = () => new Promise((resolve) => setTimeout(resolve, 0));
const settle = async () => {
  for (let i = 0; i < 30; i++) await tick();
};

test("a live query whose first load failed shows the rows once a later load of that subset succeeds", async () => {
  const queryClient = new QueryClient({ defaultOptions: { queries: { retry: false, gcTime: 60_000 } } });
  let failing = true;
  const reads = [];
  const collection = createCollection(queryCollectionOptions({
    id: "gap-2",
    queryClient,
    queryKey: ["gap-2"],
    syncMode: "on-demand",
    getKey: (row) => row.key,
    queryFn: (ctx) => {
      const { filters } = parseLoadSubsetOptions(ctx.meta?.loadSubsetOptions);
      const seq = filters.find((filter) => filter.field.join(".") === "seq")?.value;
      reads.push(seq);
      if (failing) return Promise.reject(new Error("read failed"));
      return Promise.resolve([{ key: seq + "-1", seq }, { key: seq + "-2", seq }]);
    },
  }));
  const live = createLiveQueryCollection((q) => q.from({ r: collection }).where(({ r }) => eq(r.seq, "a")));

  await expect(live.preload()).rejects.toThrow("read failed");
  await settle();
  expect(reads).toEqual(["a"]);

  failing = false;
  await collection.utils.refetch();
  await settle();

  expect(reads).toEqual(["a", "a"]);
  expect(live.toArray.map((row) => row.seq)).toEqual(["a", "a"]);
});

Result: the second read succeeds (reads is ["a", "a"], the source query is success), but live.toArray is [] and live.status is "error".

Expected behavior

Once a later load of the subset succeeds, the live query leaves the error state and shows the rows, the way a query observer recovers after a successful refetch. (Whether recovery should be automatic or an explicit clearError/retry is your call; today neither path recovers the live query.)

Additional context

  • The first-load failure is classified fatal (db/src/query/live/collection-subscriber.ts:108-116 while status is loading), goes through collection-config-builder.ts:482-499 to transitionToError (:1218-1234), and fatalQueryError/isInErrorState are only cleared on a new sync run (:748-751), not by a successful source fetch.
  • Related: the "transitioning out of error state needs more thought" review on #671, #672, #1260.
  • Why it matters: Retry after a failed first load does nothing for the user unless the app tears the live query down and rebuilds it; we currently do that by resubscribing.
  • Happy to send a PR (with oracle coverage) if you'd like to assign it; equally fine if you'd rather handle it yourselves. The test is free to adopt.

The repro was written with an AI coding assistant and checked by hand against the installed sources.

主要言語
TypeScript
スター
4k
フォーク
277
平均マージ
1日 7時間
マージ済み PR（30日）
176

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

TanStack/db のほかの issue

TanStack/db の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。