Make initial sync errors final and report later failures as Collection health
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 8/100
- issue の種類
- リファクタリング
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- angular, react, sqlite, typescript
調査の方向性
Start with PLAN.md and the design folder in docs/contributing/designs/source-failure-and-health/ on the feat/source-health-channel branch, then the oracle at packages/db/tests/source-health-oracle.test.ts. Stage 1 is in packages/db, so read the health API there before touching any adapter. Done means the listed adapter and framework work lands, the oracle passes, and the breaking changeset ships. This is maintainer-led design work, not a first task.
索引モデルが issue の本文から書いたものです。
説明
Summary
Make an initial sync error final, and report problems after the first ready as health metadata instead of an error status. A live query exposes an errors tree for every Collection it depends on. This is a breaking change. Stage 1 (core) is done on the branch feat/source-health-channel (e8508df79). The plan, design, and TLA+ models are in docs/contributing/designs/source-failure-and-health/ on that branch.
Decisions
The maintainer made these decisions on 2026-10-13:
- A retry that succeeds is a success. While a source retries, it reports nothing, and the Collection stays
loading. markErroris final for its sync attempt. A source calls it only when it gives up. The framework never moveserrorback toready.- Recovery is the app's job.
cleanup()thenpreload(), a refetch, or a user refresh starts a fresh attempt. - A final initial error reaches every consumer, with its cause. Readiness waits reject, and live queries enter error for every shape. Suspense throws, and Effects are disposed.
statusis only the initial gate. After the first ready, a sync failure is metadata on the Collection. The data stays, even if it grows stale.useLiveQueryreturns anerrorstree. It has one node for each Collection the query depends on. The shape is always the same, and apps can parse it.- An Effect works the same as a query. Its gate is "every initial load settled", whatever
skipInitialsays. - IndexedDB closure stays a crash. A closed local store cannot recover.
- Ordering. When both change,
status:changefires beforehealth:change, in the same tick. - The
errorstree keeps stable object identity. A node changes only when something in its subtree changes. - TrailBase does not resubscribe after its stream ends. A stream end reports a final health error. Reconnect is for the TrailBase maintainers.
Done in stage 1 (packages/db)
- Lifecycle.
error→readyis removed, andmarkReady()aftermarkError()throws. - Health API. The
reportError(error, { final })andreportHealthy()sync callbacks,Collection.health, and thehealth:changeevent.markError()after the first ready becomes a final health error, with a development warning. - Live queries. A source failure before the first ready fails the query for every shape, and the old
erroredSourceIdshealing is removed. After the first ready, health does not change status or rows. - The
errorstree. One node per query alias, recursing through nested live queries, with stable identity. Include nodes carryinstances: { total, inError }. A load that fails after the first ready is a request error, which clears when the load later succeeds or the demand is released. - Effects. Every Effect gates on its initial loads. After the gate, problems reach
onHealthChange, and the Effect is not disposed. - Readers and docs. The observer and pooled views expose
errors, andisErrorstays the gate.ARCHITECTURE.mdhas laws 16 and 17. - Oracle.
packages/db/tests/source-health-oracle.test.ts(propertysource-health.history) covers direct, join, self-join, nested, include, and pooled shapes, with request and Effect lanes. Base code fails 45 of 49 cells, and 16 mutants fail at assertions. The full@tanstack/dbsuite passes. - Bugs found. A pooled view over a failed source reported
isError: false. A secondmarkErrorbefore ready replaced the first error.
Remaining work
The plan's checklist (PLAN.md, sections 3.2 to 3.6) has the details.
- Adapters.
- Electric: change the
markErrorcalls after the first ready toreportError, and callreportHealthy()after recovery. - query-db: a successful refetch must not revive a failed initial load (
query.ts, themarkReady()call after an application). - PowerSync: replace the
markError/markReadyheal around the tracking rebuild. - TrailBase: a stream end reports a final health error.
- RxDB and persistence: report health, and handle a follower's view of the leader's upstream health.
- Electric: change the
- Framework hooks. React, Vue, Solid, Svelte, and Angular return
errors, and Suspense throws only for the initial gate. Add a health scenario to the shared conformance suite. Rebuildpackages/db/distfirst, because the framework packages read it. - Docs.
error-handling.md, which contradicts itself on recovery today.collection-options-creator.md, with the adapter rules.live-queries.md, with theerrors.hasErrorscallout.sqlite-persistence.mdandoffline-transactions.md.- The custom-adapter skill and the framework skills.
- Do not edit generated reference docs.
- Release. A breaking changeset with a migration guide, then the pull request.
Open items
- Code weight. Production code in stage 1 is about +418 net lines in
packages/db. Do a reduction pass before review. - Effect request errors clear only when a later load of the same source succeeds. They do not clear when the failed demand is released, because failures are tracked per source.
- Pooled views end for good when their source is cleaned up, so the oracle skips restart steps for them.
- Review record.
docs/contributing/oracle-reviews/progressive-source-readiness-tla/README.md, limit P6 ("disposes an Effect"), is now true only before the gate. - Oracle review. No
oracle-reviewhas run on the health oracle yet.
Related: #2115, #2117, #2118, #2139.
- 主要言語
- TypeScript
- スター
- 3.9k
- フォーク
- 272
- 平均マージ
- 1日 1時間
- マージ済み PR(30日)
- 235
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
TanStack/db のほかの issue
-
難易度 3/5 半日 初心者へのやさしさ 62/100
メンテナーはふだん 1 日以内に返信
-
難易度 3/5 半日 初心者へのやさしさ 58/100
メンテナーはふだん 1 日以内に返信
-
難易度 5/5 1週間以上 初心者へのやさしさ 5/100
メンテナーはふだん 1 日以内に返信
-
難易度 4/5 3〜5日 初心者へのやさしさ 25/100
メンテナーはふだん 1 日以内に返信
-
難易度 4/5 3〜5日 初心者へのやさしさ 35/100
メンテナーはふだん 1 日以内に返信
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
one-zero-eight/apply-bot#39 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
bigbluebutton/bbb-ui-components-react#108 ·
メンテナーはふだん 2 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
メンテナーはふだん 1 日以内に返信
-
high priority
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
CI-CMG/deep-sea-corals-exb#84 · コメント 1 件 ·