[BUG]: P2P sync downloads full 500-block chunks without headers-first validation
メンテナーはふだん 1 日以内に返信
@anshulchikhale30-p がすでに取り組んでいます。
2026年11月8日 から。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 25/100
- issue の種類
- 機能追加
- 明瞭さ
- 明確に書かれている
- 活発さ
- 活発
- 技術スタック
- python
調査の方向性
Start with main.py handlers request_chain, chain_request, and chain_response, then read minichain/p2p.py and minichain/chain.py to understand current sync and validation. Run the existing test suite and inspect its sync coverage before planning the new tests named in the issue. Done means header-first sync, bounded and rate-limited body requests, peer handling for invalid data, and the stated acceptance criteria are implemented and documented in docs/sync.md.
索引モデルが issue の本文から書いたものです。
説明
Bug Description
MiniChain's P2P sync downloads up to 500 full blocks per request and has no headers-first phase or block locator. When a peer's tip is ahead, main.py calls request_chain(network, chain.last_block.index + 1, 500); on a fork it requests up to 50 blocks backward. This works for small local chains but is inefficient and unsafe at scale.
Current behavior:
request_chainbroadcasts achain_requestwithstart_indexandlimit=500.chain_requestserveschain.chain[start_index:start_index+limit]and sends every full block (header + transactions + receipts).chain_responseparses all received blocks into memory and applies them one by one.- There is no
getheaders/headersphase and no block locator, so an invalid chain is only discovered after downloading entire bodies. chain_requestacceptsstart_indexandlimitwithout bounds; a peer can request a very large range or send a very large response.- There is no request ID/response correlation, no maximum response size, and no per-peer sync rate limit.
p2p.pycoverage is 37% (README), so these paths are under-tested.
Impact:
- Slow sync and high memory use on long chains.
- Wasted bandwidth and CPU on invalid or adversarial chains.
- DoS vector via oversized requests/responses or request floods.
- Repeated 50-block backward scans on forks.
- Multi-node research at 10k+ blocks is impractical.
Expected behavior:
- Sync headers first with a locator, validate the header chain (PoW, target, timestamp, parent linkage, cumulative work), then download bodies in bounded batches.
- Bound request/response sizes, add request IDs, unicast to one peer, and rate-limit per peer.
- Disconnect or ban peers that send invalid or oversized data.
Proposed fix:
- Add
getheaderswith a locator (recent block hashes),stop_hash, andmax(e.g. 2000), plus aheadersresponse. - Validate headers before bodies: PoW, target, timestamp, parent linkage, cumulative work.
- Add
getblockby hash or bounded range; fetch bodies in small batches (e.g. 64 blocks) with a maximum number of in-flight requests. - Verify transaction root, receipt root, and state root after executing the bodies.
- Add request IDs, unicast requests to one peer, and deduplicate responses.
- Cap
start_index,limit, and response bytes; add a per-peer token bucket. - Feed invalid or oversized responses into the existing validation counters and ban repeat offenders.
- Add tests for 10k-block sync, 100-block reorg, invalid headers, invalid bodies, oversized requests/responses, restart mid-sync, and rate limiting.
- Document the protocol and limits in
docs/sync.md.
Acceptance criteria:
- 10k-block sync completes within an agreed target and bounded memory.
- Headers are validated before bodies are downloaded.
- Fork detection uses a locator, not repeated 50-block scans.
- Requests and responses are bounded and rate-limited.
- Invalid or oversized peers are disconnected or banned.
- No unbounded queues or response buffers.
-
p2p.pycoverage is at least 65%. - Sync protocol and limits are documented.
Relevant files:
main.py(request_chain,chain_request,chain_response)minichain/p2p.pyminichain/chain.pytests/test_sync.py(new)tests/test_p2p_limits.py(new)
References:
- Bitcoin P2P network guide: https://developer.bitcoin.org/devguide/p2p_network.html
- Bitcoin protocol documentation: https://en.bitcoin.it/wiki/Protocol_documentation
- BIP 152 compact block relay (optional future work): https://github.com/bitcoin/bips/blob/master/bip-0152.mediawiki
Steps to Reproduce
- Start two nodes on different ports with separate data directories.
- Let one node mine more than 500 blocks.
- Connect the second node to the first node.
- Observe the
hellohandler requestchain_requestwithlimit=500, followed by full-blockchain_responsepayloads. - For the adversarial case, send a
chain_requestwith a very largelimit, or send achain_responsecontaining a very large list of blocks, and observe memory/CPU use.
Logs and Screenshots
Relevant log lines include:
?? Peer ... is ahead (...) . Initiating chunked sync...
?? Peer requested blocks from ... (limit 500).
No screenshots available.
Environment Details
- OS: Windows 11 / Linux
- Python 3.10+
- MiniChain
mainbranch as of 2026-11-08 p2p.pycoverage: 37% (README coverage report)
Impact
High - Major feature is broken (sync works for small chains, but is not safe or efficient at scale).
Code of Conduct
- I have joined the Discord server and will post updates there
- I have searched existing issues to avoid duplicates
- 主要言語
- Python
- スター
- 12
- フォーク
- 27
- 平均マージ
- 2分
- マージ済み PR(30日)
- 1
環境構築
- Dockerfile または Docker Compose ファイルあり
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
StabilityNexus/MiniChain のほかの issue
-
[BUG]: Handle JSON-RPC notifications and empty batches correctly対応中かも @Muneerali199 が 10 日前に担当しました。 オープンbug
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
StabilityNexus/MiniChain#177 · コメント 2 件 ·
メンテナーはふだん 1 日以内に返信
-
automatic-copyright-year: keep README copyright current対応中かも @anshulchikhale30-p が 7 日前に担当しました。 オープンdocumentation enhancement
難易度 3/5 半日 初心者へのやさしさ 35/100
StabilityNexus/MiniChain#189 ·
メンテナーはふだん 1 日以内に返信
-
Difficulty: bound per-block EMA moves, add a difficulty floor, and preserve state across restarts対応中かも @anshulchikhale30-p が 7 日前に担当しました。 オープンbug documentation enhancement
難易度 4/5 3〜5日 初心者へのやさしさ 25/100
StabilityNexus/MiniChain#187 ·
メンテナーはふだん 1 日以内に返信
-
[BUG]: Blocks on a different parent are classified INVALID and get the sender banned対応中かも @kansalakshat が 7 日前に担当しました。 オープンbug
難易度 2/5 1〜3時間 初心者へのやさしさ 35/100
StabilityNexus/MiniChain#185 ·
メンテナーはふだん 1 日以内に返信
-
[FEATURE]: Add transaction and receipt lookup RPC methods対応中かも @Thushara3005 が 10 日前に担当しました。 オープンenhancement
難易度 4/5 3〜5日 初心者へのやさしさ 58/100
StabilityNexus/MiniChain#176 ·
メンテナーはふだん 1 日以内に返信
StabilityNexus/MiniChain の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
huggingface/datasets#9128 ·
メンテナーはふだん 1 日以内に返信
-
priority:low ready-for-dev
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
OpenHands/extensions#975 ·
メンテナーはふだん 1 日以内に返信
-
Function/dict state handlers can't supply provider-state injected values (`generate.provider_state`)オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
pact-foundation/pact-python#1789 ·
メンテナーはふだん 9 日以内に返信
-
documentation
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
juandresrodca/AdminForge#66 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
メンテナーはふだん 1 日以内に返信