Support pobes whose geometry is chosen at order time
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 35/100
- issue の種類
- 機能追加
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- python, typescript
- 領域
- tooling
調査の方向性
Start by reading the existing generate_multi_shank generator and the current library entries for the probe families described in the issue. Compare which geometry values are fixed versus chosen at order time, then review how the widget currently loads and visualizes entries. Done means parameterized family generators, metadata for units and published ranges, preserved real-part-number entries, and widget support for selecting and loading generated probes.
索引モデルが issue の本文から書いたものです。
説明
Right now every entry in the library is a part number that pins the whole geometry: NP1000, ASSY-325D-F, A4x8-5mm-100-400-177. For those a lookup is the right answer.
However, some manufacturers let the buyer choose part of the geometry when ordering, so the model name alone does not determine the probe:
- NeuroNexus sells many designs with a 15 or 50 µm thick shank and adds the thickness as a suffix to the part number (
A1x32-6mm-50-177-H16-50). Our model names stop before the suffix. - Diagnostic Biochips Deep Array datasheets say "please specify the shank length", up to 90 mm. The six
DA*files in the library draw the contour to y = 90000 µm, so they picked the maximum without saying so. The contacts are fine as they are measured from the tip. - Blackrock Utah arrays have the needle length (0.5 to 1.5 mm), the grid size and the channel count chosen per order, with no part number at all.
- Plexon U-Probe, V-Probe and S-Probe (channel count, spacing, shaft length) and CorTec AirRay grids work the same way. They are not in the library because there is no single file we could add.
A file for one of these looks exactly as authoritative as NP1000, but it answers a question it can't answer. Somebody with a 1.0 mm Utah array would load a 1.5 mm file and nothing would warn them.
What I have in mind (I tried it on a local branch with the Utah array):
- probeinterface gets a generator per family, next to
generate_multi_shank, that fixes what the manufacturer fixes and takes the ordered values as arguments with no defaults, e.g.generate_utah_array(needle_length_um, rows, cols). - The library keeps one entry per family that lists the fixed values, the free parameters with their units and published ranges, and the generator to call, instead of a probe file. A widget that allows to explore the parmameter options, changes so you can visualize when you pick them and gives you the python snippet to load it.
- Entries that are a real part number stay as they are.
The NeuroNexus thickness option also came up in https://github.com/SpikeInterface/probeinterface/issues/452.
- 主要言語
- TypeScript
- スター
- 21
- フォーク
- 11
- 平均マージ
- 22時間 23分
- マージ済み PR（30日）
- 2
環境構築
このプロジェクトの環境構築ファイルはまだ確認していません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
SpikeInterface/probeinterface_library のほかの issue
-
難易度 3/5 1〜2日 初心者へのやさしさ 62/100
SpikeInterface/probeinterface_library#73 · コメント 5 件 ·
-
難易度 3/5 1〜2日 初心者へのやさしさ 45/100
SpikeInterface/probeinterface_library#67 · コメント 1 件 ·
SpikeInterface/probeinterface_library の issue をすべて見る
似ている issue
-
ADD openalgoオープンtemplate
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
メンテナーはふだん 1 日以内に返信
-
factory-active factory-automatic task-bug-reproduction-success task-identify-harness-labels-done task-identify-issue-type-done
難易度 2/5 1〜3時間 初心者へのやさしさ 90/100
メンテナーはふだん 1 日以内に返信
-
bug Needs: Triage :mag:
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
microsoft/fluentui-contrib#671 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
sveltejs/acorn-typescript#150 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100