Fix CI D1 migration timing issues for Email and OTP Login E2E tests

オープン
#607 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
22/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
停滞
技術スタック
github-actions, sql, typescript

調査の方向性

Start with the CI workflow that creates the D1 database, runs 020_add_email_plugin.sql and 026_add_otp_login.sql, and deploys the preview, then compare it with the plugin-card lookup the tests depend on. Next, look at tests/e2e/29-email-plugin-settings.spec.ts and tests/e2e/44-otp-login-admin.spec.ts for the test.describe.skip markers. Done means the root cause is recorded, both suites run without the skip, and they pass across repeated CI runs.

索引モデルが issue の本文から書いたものです。

説明

area: quality bug priority: P2 testing

Summary

Two E2E test suites are currently skipped due to D1 migration timing/propagation issues in CI:

  • tests/e2e/29-email-plugin-settings.spec.ts
  • tests/e2e/44-otp-login-admin.spec.ts

These tests pass locally but fail in CI even after migrations execute successfully.

Background

These tests were skipped in PR #581 to unblock the merge of the component-based plugin settings architecture feature. The tests verify:

  1. Email Plugin Settings (29-email-plugin-settings.spec.ts)

    • Navigation to email plugin settings from plugins page
    • Display of email settings form with all fields (API key, from email, from name, etc.)
    • Save settings functionality
    • Required field validation
    • Test email section display
  2. OTP Login Admin (44-otp-login-admin.spec.ts)

    • OTP Login plugin settings page loading
    • Test email form display
    • Email preview section display
    • Code settings form display
    • Quick links to related settings
    • Email configuration status
    • Features list display
    • Save settings button
    • Send test code functionality

Root Cause Investigation

The CI workflow:

  1. Creates a fresh D1 database for each PR
  2. Runs migrations (020_add_email_plugin.sql, 026_add_otp_login.sql)
  3. Deploys to Cloudflare Workers preview
  4. Runs E2E tests

Migrations execute successfully (confirmed by ✅ markers in CI logs), but the Email plugin card is not visible when tests run. This suggests a timing/propagation delay between:

  • D1 migration completion
  • Data being available to the Worker

Potential Solutions to Investigate

  1. Add delay after migrations - Wait for D1 propagation before running tests
  2. Verify data availability - Add a health check endpoint that confirms plugin data exists
  3. D1 eventual consistency - Research if D1 has eventual consistency behavior and workarounds
  4. Worker restart - Check if Worker needs restart/redeploy after migrations
  5. Database binding timing - Investigate if database bindings need time to propagate

Acceptance Criteria

  • Identify root cause of D1 propagation delay
  • Implement fix in CI workflow or application code
  • Re-enable skipped tests by removing test.describe.skip
  • Verify tests pass consistently in CI (run multiple times)

Related

  • PR #581 - Original PR where tests were skipped
  • Migrations: 020_add_email_plugin.sql, 026_add_otp_login.sql

🤖 Generated with Claude Code

主要言語
TypeScript
スター
1.8k
フォーク
219
平均マージ
2日 21時間
マージ済み PR(30日)
67

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

SonicJs-Org/sonicjs のほかの issue

SonicJs-Org/sonicjs の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。