Gem `BUNDLE_GEMFILE` check compares paths lexically, so a symlinked spelling of the project's own Gemfile (e.g. macOS `/tmp/app/Gemfile`) is refused, and `vex` / `rollback` reject the hosted patch Bundler is loading
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
調査の方向性
crates/socket-patch-core/src/formats/gem/manifest.rsを読み、138〜147行目付近の関数resolve_againstと、183〜189行目のmanifest比較から始めてください。修正では、BUNDLE_GEMFILEをプロジェクトのルートと比較する際にパスを正規化する(またはファイルの同一性を使用する)ことで、同じGemfileを指すシンボリックリンクのパスを受け入れるようにしてください。完了の目安は、issueに記載された再現ケースが機能することです。シンボリックリンクを含むプロジェクトでBUNDLE_GEMFILE=$PWD/Gemfileを指定しても、redirect_gem_bundle_gemfile_unsupportedが返されなくなります。
索引モデルが issue の本文から書いたものです。
説明
[agent] Found by the scheduled Bundler (RubyGems) bug-hunt routine (ledger #316).
Summary
formats::gem::manifest::classify decides whether BUNDLE_GEMFILE names the project's own Gemfile / gems.rb by comparing std::path::absolute + normalize_lexically of the setting against the project root. It never resolves symlinks. The root comes from the process cwd (getcwd, the physical path) or --cwd. A shell's $PWD, and paths people type, are often the logical path through a symlink. So BUNDLE_GEMFILE=$PWD/Gemfile names the same file Bundler loads, but socket-patch classifies it as "another manifest" (LoadedManifest::Unsupported).
On macOS this is the default for anything under /tmp (→ /private/tmp) or $TMPDIR (/var/folders/… → /private/var/…). On Linux it hits any project reached through a symlinked directory (a symlinked workspace or home, /app → volume, and so on).
Impact
All of these fail closed, but each one stops socket-patch from working on a correctly configured project, with a message that's factually wrong:
- Hosted
scanredirects nothing:redirect_gem_bundle_gemfile_unsupported("bundler loads/tmp/bh-app/Gemfile… not the project's Gemfile or gems.rb"). That is the project's Gemfile. vexon an already-redirected project whose install is patched (Bundler loads the patched gem) refuses with exit 2: "BUNDLE_GEMFILE points bundler at another manifest, so this wiring is never installed and the patch is not attested". It also suggests deletingGemfile.lock, which is the lock Bundler uses.rollback/removeerror out withpatched_ref_unattributablefor the same reason, so the hosted patch can't be unwound while the variable is set.
The same function backs bundler_loaded_lock_in (lock inventory, ledger recovery, VEX discovery) and the vendored manifest check, so every gem lock reader inherits this.
Repro (Linux; the ln -s stands in for macOS /tmp)
mkdir -p real/app && ln -s "$PWD/real" link && cd link/app
printf 'source "https://rubygems.org"\n\ngem "colorize", "0.8.1"\ngem "rainbow"\n' > Gemfile
bundle config set --local path vendor/bundle && bundle install && bundle lock --add-checksums
echo "PWD=$PWD physical=$(pwd -P)"
BUNDLE_GEMFILE=$PWD/Gemfile bundle exec ruby -e 'puts Bundler.default_lockfile' # → link/app/Gemfile.lock (same file)
A="--api-url <mock> --org org --api-token fake --patch-server-url <mock>"
socket-patch scan --mode hosted --json --yes --dry-run $A # redirected: 1
BUNDLE_GEMFILE=$PWD/Gemfile socket-patch scan --mode hosted --json --yes --dry-run $A # redirected: 0, redirect_gem_bundle_gemfile_unsupported
BUNDLE_GEMFILE=$(pwd -P)/Gemfile socket-patch scan --mode hosted --json --yes --dry-run $A # redirected: 1
# after a real redirect (no env) + bundle install → installed gem is patched:
BUNDLE_GEMFILE=$PWD/Gemfile socket-patch vex --product pkg:gem/app@1 $A # exit 2 ("never installed")
BUNDLE_GEMFILE=$PWD/Gemfile socket-patch rollback --dry-run --json --yes $A # status error, patched_ref_unattributable
The same refusal happens for --cwd <symlinked path> with BUNDLE_GEMFILE=<physical path>, and for .bundle/config BUNDLE_GEMFILE: "<symlinked abs path>/Gemfile" (as written by bundle config set --local gemfile "$PWD/Gemfile"), with no environment variable at all.
Expected vs actual
- Expected, per docs/ecosystems.md (RubyGems row):
BUNDLE_GEMFILE"is followed when it names the project'sGemfile/gems.rb, and any other configured manifest is refused". Bundler expands the path and resolves it to the same file and the sameGemfile.lock(Bundler.default_lockfileabove), so socket-patch should treat it as the project'sGemfile. - Actual: the refusal fires when it shouldn't (a false
Unsupported), and the VEX / rollback messages claim Bundler uses a different manifest.
Matrix (Bundler 4.0.22)
| OS | Setup | Unset | BUNDLE_GEMFILE=$PWD/Gemfile (logical) |
BUNDLE_GEMFILE=$(pwd -P)/Gemfile |
|---|---|---|---|---|
| macos-latest, Ruby 3.4.9 | project in /tmp/bh-app (physical /private/tmp/bh-app) |
redirected 1 | refused | redirected 1 |
| ubuntu-latest, Ruby 3.4 | project via symlinked dir | redirected 1 | refused | redirected 1 |
| Linux sandbox, Ruby 3.3.6 | same, plus vex / rollback after a real redirect + install (2/2) |
vex ok | vex exit 2, rollback error (installed gem is patched) | — |
| Linux sandbox | --cwd <link> + env <real> / config abs <link> path |
— | refused / refused | — |
Probe run: https://github.com/SocketDev/socket-patch/actions/runs/37382646373 (the probe's own vex/rollback cells hit a stale vendor/bundle harness artifact; the Linux sandbox rows cover them).
First bad commit
9d718cf5 (#431, the fix for #341 / #390), which introduced the BUNDLE_GEMFILE classification with a lexical compare; cbf1f748 (#532) kept it. The v4.0.0 release binary ignores BUNDLE_GEMFILE and redirects this project (it predates the classification), so this hasn't shipped in a release yet.
Suspect code
crates/socket-patch-core/src/formats/gem/manifest.rs:138-147(resolve_against:absolute+normalize_lexicallyonly) and:183-189(target == root.join(manifest)).- The same lexical compare is in
env_keeps_root(manifest.rs:163-166), which decides whether the env var moves Bundler's root.
Comparing canonicalized paths (or file identity, same_file-style) whenever both exist would match what Bundler does. A lexical match could stay as the fast path, falling back to canonicalization only when it fails, so a symlinked Gemfile file (already refused elsewhere) keeps its own handling.
- 主要言語
- Rust
- スター
- 8
- フォーク
- 1
- 平均マージ
- 18時間 19分
- マージ済み PR(30日)
- 504
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
SocketDev/socket-patch のほかの issue
-
agent:triaged bug bughunt pm:npm priority:p3 ux
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
SocketDev/socket-patch#1072 · コメント 2 件 ·
メンテナーはふだん 1 日以内に返信
-
agent:triaged bug bughunt pm:yarn-berry priority:p1
難易度 2/5 1〜3時間 初心者へのやさしさ 73/100
SocketDev/socket-patch#783 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
Vendored cargo warns cargo_multi_version_old_cargo ("declares no rust-version") when the root package inherits rust-version from [workspace.package]対応中かも このイシューにリンクされたプルリクエストがオープン中、またはマージ済みです。 オープンagent:triaged bug bughunt pm:cargo priority:p2
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
SocketDev/socket-patch#651 · コメント 3 件 ·
メンテナーはふだん 1 日以内に返信
-
bug bughunt pm:npm
難易度 4/5 3〜5日 初心者へのやさしさ 45/100
SocketDev/socket-patch#1481 ·
メンテナーはふだん 1 日以内に返信
-
Hosted gem scan ignores a Gemfile `lockfile "custom.lock"` DSL call (Bundler 4), so it pins the unused Gemfile.lock, leaves the real lock untouched, and every frozen install fails対応中かも @mikolalysenko が今日担当しました。 オープンagent:claimed agent:triaged bug bughunt pm:bundler priority:p1
難易度 4/5 3〜5日 初心者へのやさしさ 35/100
SocketDev/socket-patch#1477 · コメント 3 件 ·
メンテナーはふだん 1 日以内に返信
SocketDev/socket-patch の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
project-robius/robrix#1154 ·
メンテナーはふだん 1 日以内に返信
-
Add Mimirオープン
難易度 1/5 1時間未満 初心者へのやさしさ 78/100
slavakurilyak/awesome-ai-agents#759 ·
メンテナーはふだん 1 日以内に返信
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
compiler-explorer/compiler-explorer#9272 ·
メンテナーはふだん 1 日以内に返信
-
難易度 1/5 1時間未満 初心者へのやさしさ 63/100
pop-os/cosmic-files#2117 ·
メンテナーはふだん 2 日以内に返信