CI perf: workflow_dispatch of CI — Windows-only janitor fixes re-run the full Linux + macOS nightly matrix (~100 min/day, ~30 macOS)
メンテナーはふだん 1 日以内に返信
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 1/100
- issue の種類
- 機能追加
- 明瞭さ
- 明確に書かれている
- 活発さ
- 停滞
- 技術スタック
- github-actions, yaml
- 領域
- ci-cd
調査の方向性
Read .github/workflows/ci.yml and the janitor instructions referenced by the issue. Check how workflow_dispatch gates nightly jobs and how CI_SCOPE selects matrix includes, then compare a dispatch with os: all against the stated 99-job baseline. Done means OS-specific dispatches select the intended jobs while scheduled, push, pull request, and merge queue runs retain their current coverage; linked pull request #1820 is already open.
索引モデルが issue の本文から書いたものです。
説明
Measurement
Window: 7 days to 2026-10-29 08:17 UTC. There were 6 workflow_dispatch runs of CI. 5 were on ci-janitor/agent branches that fix a Windows-only nightly failure: cargo-home-windows-test, fix-ci-go-gowork-windows-tests, fix-ci-windows-yarnrc-escaped-path, windows-nightly-path-asserts and uv-settings-test-windows. The 6th was pylock-follow-uv.
A dispatch runs the whole nightly matrix. Here are the two dispatches from this morning:
| run | Linux | Windows | macOS | verdict |
|---|---|---|---|---|
40831237830 ci-janitor/cargo-home-windows-test |
98.3 min / 91 jobs | 52.6 / 4 | 43.5 / 4 | red on test (windows-latest, 1) |
40833574647 agent/fix-ci-go-gowork-windows-tests |
96.0 / 91 | 47.4 / 4 | 39.7 / 4 | red on test (windows-latest, 2) |
| for reference, nightly 40824880386 | 95.7 / 91 | 49.9 / 5 | 36.2 / 4 | red on both Windows shards |
In this 4-hour slice those two dispatches used 194 Linux + 83 macOS job-min. That is more than all 10 full PR CI runs together (370 Linux). Neither branch changes anything that runs on Linux or macOS, and the PR's own CI run already covers the Linux tiers.
Where the time goes
Per dispatch: ~97 Linux min in 91 jobs (the full e2e tier, the yarn/cargo-vex full matrices and coverage), ~41 macOS min (test (macos-latest, 1/2) 16.6–18.3 min each, e2e-build-macos 2.9–5.9, yarn-berry (macos) 2.5–3.0) and ~50 Windows min. Only the 4 Windows jobs (e2e-build-windows, test (windows-latest, 1/2), yarn-berry 4.12.0 (windows-latest)) test the fix.
Root cause
The only dispatch input ci.yml has is hosted_e2e. Every nightly-tier job is gated on github.event_name == 'workflow_dispatch' (for example ci.yml lines 365, 562, 825, 957, 1179, 2107, 2169, 2234, 2545), so a dispatch can't pick an OS.
Proposed fix
In .github/workflows/ci.yml:
- Add a dispatch input
os: choice [all, windows, macos, linux], defaultall. - In each job's
if:, replace the baregithub.event_name == 'workflow_dispatch'term with an OS-aware one. Windows jobs (testwindows matrix rows,e2e-build-windows,e2e-windows,cargo-vex-matrix-windows, the windowsyarn-berryrow) take(github.event_name == 'workflow_dispatch' && contains(fromJSON('["all","windows"]'), inputs.os)), and likewise for macOS and Linux. Matrices that mix OSes (test,yarn-berry-e2e) filter theirincludeoninputs.osthe same wayCI_SCOPEalready picks the include list. - Have the ci-janitor routine / agent instructions dispatch with
-f os=windowsfor Windows-only fixes.
schedule, push, pull_request and merge_group are unchanged. ci-ok already treats skipped jobs as passing, and dispatch runs aren't required checks.
Expected saving
- Per Windows-only dispatch: ~97 Linux + ~41 macOS job-min, ~95 Depot/hosted job starts and 4 macOS runner slots.
- At the 7-day rate (5 Windows-only dispatches, ~0.7/day): ~70 Linux + ~30 macOS job-min/day. On days when the janitor is iterating on a Windows nightly break (2 in 25 min this morning) it's ~190 Linux + ~80 macOS.
- Wall clock doesn't change: the Windows test shards (16–21 min) set the length of a dispatch run.
Coverage and risk
Nothing loses coverage. The nightly (schedule) still runs every job on every OS, and os: all (the default) keeps today's dispatch behavior. A janitor fix that turns out to break Linux or macOS is still caught by its PR CI run, the merge queue, and the nightly. Required check names ci-ok / clippy don't change. The risk is a typo in an if: that silently skips a job on schedule. Check with a workflow_dispatch of os: all and compare its job count (99) before merging.
Effort
S: one input and ~12 if: / matrix-include edits in one file, plus one line in the janitor instructions.
ROI
Saving ≈ 0.07k Linux ×1 + 0.03k macOS ×3 = 0.16 weighted k-min/day; confidence 0.6 (the dispatch rate swings with Windows nightly breaks); effort 1 → ROI ≈ 0.1.
Generated by Claude Code
- 主要言語
- Rust
- スター
- 8
- フォーク
- 2
- 平均マージ
- 19時間 31分
- マージ済み PR(30日)
- 686
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
SocketDev/socket-patch のほかの issue
-
bug bughunt pm:npm
難易度 4/5 3〜5日 初心者へのやさしさ 53/100
SocketDev/socket-patch#1827 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
Go apply, apply --check and vex treat a module that is only another module's replace target as built, so the patch is reported applied and attested while go builds the unpatched code対応中かも @mikolalysenko が今日担当しました。 オープンagent:claimed agent:triaged bug bughunt pm:go priority:p2
難易度 4/5 3〜5日 初心者へのやさしさ 48/100
SocketDev/socket-patch#1823 · コメント 3 件 ·
メンテナーはふだん 1 日以内に返信
-
Vendored gem mode writes the rewired `gem` line of a CRLF Gemfile with an LF ending, leaving the Gemfile with mixed line endings対応中かも @mikolalysenko が今日担当しました。 オープンagent:claimed agent:triaged bug bughunt pm:bundler priority:p1
難易度 3/5 1〜2日 初心者へのやさしさ 25/100
SocketDev/socket-patch#1821 · コメント 3 件 ·
メンテナーはふだん 1 日以内に返信
-
Nightly Windows: 3 Go workspace unit tests fail (Unix-only GOWORK paths)対応中かも @mikolalysenko が今日担当しました。 オープンagent:claimed agent:triaged ci-janitor priority:p3
難易度 3/5 1〜2日 初心者へのやさしさ 35/100
SocketDev/socket-patch#1815 · コメント 2 件 ·
メンテナーはふだん 1 日以内に返信
-
Go apply writes the shared replace into ./go.work when GOWORK names another file in the same directory, reports success, and the workspace builds unpatched対応中かも @mikolalysenko が今日担当しました。 オープンagent:claimed agent:triaged bug bughunt pm:go priority:p2
難易度 4/5 1〜2日 初心者へのやさしさ 35/100
SocketDev/socket-patch#1810 · コメント 3 件 ·
メンテナーはふだん 1 日以内に返信
SocketDev/socket-patch の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
メンテナーはふだん 1 日以内に返信
-
memory_patch_page drops the `#` of headings like `## Notes on C#`対応中かも @viniciusdsandrade が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 85/100
akitaonrails/ai-memory#1859 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
wealthfolio/wealthfolio#2376 ·
メンテナーはふだん 1 日以内に返信
-
kind/bug kind/security
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
spiceai/spiceai#15826 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
area:cli bug dotnet good first issue priority:medium
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
メンテナーはふだん 1 日以内に返信