Snap: show the pending editor when capture starts outside the Snap page

オープン
  • 何か問題がありますか？
#151 コメント 4 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
38/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
macos, swift
領域
desktop

調査の方向性

Start with the capture entry points and restore callback in Sources/LocalVoice/main.swift and WorkbenchHome.swift, then trace draft ownership in SnapWorkspaceView.swift and SnapModel.swift. Reproduce the Home-to-Screen capture flow and inspect the existing host/page/sheet structure before changing it. Done means the acceptance journeys work across the listed entry points, cancellation restores prior context, and a meaningful regression test covers the flow.

索引モデルが issue の本文から書いたものです。

説明

bug

Outcome and evidence

P1, reproduced in the installed app. Completing a Screen capture while Home is selected returns to Home without an editor and leaves Snap disabled. Opening the Snap page exposes the hidden draft; Cancel restores capture. A person has no visible way to finish or cancel at the action's origin.

Workbench Preview 2.3.0, build 20260928054038, source 00be555139f87d4557f48fcffc132b8621c251a2, unmodified source, macOS 26.5.1 (25F80), Apple M5, built-in display. Identity verified in the running app using Copy build details on 28 September 2026.

Reproduction

  1. Leave the main window on Home with no visible Snap editor.
  2. Open Quick controls and choose Snap → Options → Screen.
  3. Wait for capture to finish. Home returns; Snap and the recent-item Edit action are disabled, with no editor shown.
  4. Select Snap in the sidebar. The New Snap sheet appears.
  5. Cancel the sheet. Capture becomes available again.

One completed Screen journey was observed. The editor was cancelled and no new Snap was saved. The source also exposes the same risk for toolbar/Home/shortcut entry points; those complete capture journeys still need retesting. No private desktop screenshot is attached.

Owner and bounded change

Source links below pin the earlier audited commit 9578d8cf; the relevant paths were checked against installed 00be5551 and the described behaviour is unchanged. Source findings and native observations are distinguished below.

  • main.swift starts capture without changing the selected page; its restore callback at line 76 only shows the window.
  • WorkbenchHome.swift mounts the Snap workspace conditionally; its Home action at line 466 starts capture directly.
  • SnapWorkspaceView.swift owns the draft sheet.
  • SnapModel.swift creates the draft and restores the window. A non-nil draft keeps capture busy.

Give successful capture one host-owned path that exposes the existing draft editor from every entry point. Keep one draft/state owner. The same completion route currently restores Workbench on cancellation too; verify cancellation returns to the prior app/window state before changing that behaviour. Focus theft on cancellation is a source lead, not a reproduced result here.

Additional consequence in the newer build

At 00be5551 SnapModel.importInbox, a pending draft also makes screenshot-inbox import return early. This is source-confirmed; the screenshot-relocation setting was not changed during native testing.

Keep draft ownership separate from inbox adoption where safe. A visible editable draft should not stall settled background screenshots indefinitely. Preserve the existing readback-before-Trash and later-manual-location rules.

Acceptance

  • Region, Window and Screen each expose one usable editor from Home, another page, panel, toolbar and configured shortcut, including a hidden/minimised main window.
  • Save, Save & Copy, Cancel and Escape resolve the draft and allow another capture without hidden or duplicate items.
  • Selector cancellation creates no item and restores the prior context; acquisition errors are visible and recoverable.
  • Existing originals, crop/marks and independent jobs remain intact.
  • With screenshot adoption explicitly enabled in a disposable test, pending/visible drafts do not lose or indefinitely stall new settled screenshots; adoption resumes safely after Cancel/Save. Existing inbox files and manual screenshot-location changes remain intact.
  • Add a meaningful host/page/sheet regression, then repeat the complete journey in the signed installed Preview and record Copy build details.

Related: #112, #134, #7. Follow the product contract and shared install workflow; this request does not require a second capture store.

主要言語
Swift
スター
0
フォーク
1
平均マージ
14時間 21分
マージ済み PR（30日）
208

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Ship-Work/workbench のほかの issue

Ship-Work/workbench の issue をすべて見る

似ている issue

Swift の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。