detectors judge their own pattern tables and the law registry text as project code (M3)

オープン
#426 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
48/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
typescript
領域
testing-qa

調査の方向性

Start with the code-only view of M1, then read the named detectors and data modules, including encryption-implementation-configuration.ts, environment-variables-usage-configuration.ts, authentication-checker.ts, and src/data/*-laws.ts. Reproduce the self-audit described in the issue and trace how pattern tables, law text, and data-only modules reach each check. Done means detector data and prose are excluded by general rules, with the listed self-findings gone and the intended checks still running.

索引モデルが issue の本文から書いたものです。

説明

bug

Found in the 8.0.0 self-audit triage: RoC 7.29.1 (npm, 5fc54afe) on a clean clone of develop at 2d2fa9a, with typescript resolvable (verdict compliance, 0 failed / 46 warnings). The bucket method and per-law tables are kept by QA; counts are from that run.

What happens

Run on a repository that contains detectors (RoC itself, or any project with lint/security tooling), the detectors flag their own data:

  • Data Encryption: WEAK_ALGORITHMS = ['MD5','SHA1','DES','RC4'] (encryption-implementation-configuration.ts:23) flags its own line; 26 of 29 findings are pattern tables or law text.
  • Environment Security: BEST_PRACTICES.bad contains 'process.env.SECRET_KEY without validation' (environment-variables-usage-configuration.ts:128-132); doc-reference URLs in the serverless registry are "hardcoded URLs".
  • Authentication Security: /md5.*password/ matches its own source (authentication-checker.ts:129-133). Note: two of its checks pass today only because of the detector's own /AuthService/ and /refreshToken/ patterns, so fixing scope makes them fire (see the gating issue).
  • Code Documentation: the law registries src/data/*-laws.ts are "under-commented" because their prose lives in fields (28 files).
  • Typed HTTP Boundaries: its only match is law prose describing its own false positive (code-quality-laws.ts:462).
  • Async Cache Single-Flight: a file is selected by the law card's own example text (cache-harness-laws.ts:83-85).

Suggested direction

A general rule, not an ignore list for RoC: string contents of pattern/data tables are not code (covered by the code-only view of M1), and data-only modules (no function bodies) are skipped by ratio-style checks.

主要言語
TypeScript
スター
0
フォーク
0
平均マージ
38分
マージ済み PR(30日)
96

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Rule-Of-Code/RoC のほかの issue

Rule-Of-Code/RoC の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。