Request: Abstract ScriptAnalysis to allow multiple providers

まず、PSES の既存の analysis-service ラッパー、提案されている Specter プロジェクト、およびその PSSA 互換性テストを確認します。何かを実装する前に provider の境界と統合アプローチを明確にします。完了とは、PSES が複数の ScriptAnalysis provider をサポートしつつ、説明されている診断とフォーマットのユースケースを維持できることを意味します。

Prerequisites

• I have written a descriptive issue title.
• I have searched all issues to ensure it has not already been reported.

Summary

Howdy howdy!

About six years ago I branched PSSA to experiment with how we might rewrite it to address some of the issues it represents especially for embedding in PSES.

I picked that back up again recently and have spent some time pushing it into an interesting state. I've put it together here.

I pulled in all of PSSA's tests and it passes all of them (except for deliberate breaks, which are either minor or internal type things) when run through its compatibility module.

Anyway, I suspect I won't be maintaining it, but I'd be happy to give it away if it's useful. It's specifically intended to serve PSES scenarios alongside also offering a PS module — it even has a server mode in case you want to run it as a daemon. And maybe this is of interest to @bergmeister too. Oh it also has a few extra rules, including native implementations of InjectionHunter.

Otherwise I just stopped in to say hi and hope all's well!

Proposed Design

If memory serves, we abstracted PSSA in PSES by wrapping it in an analysis service. We could probably do something similar in PSES pretty easily, but this time compiling directly against the DLL because it's meant to be used as a DLL. Also the service could spawn a new process that lives between calls or something — not quite sure about the details there, but the point is to amortise initialisation costs (maybe that scenario is actually better for CI or repeated command line use). Basically it shouldn't be too crazy to integrate if you're interested. And it should be pretty quick for diagnostics and much much faster for formatting