Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

Validate mirth.properties at startup and refuse to run on any invalid value

オープン
  • 何か問題がありますか？
#413 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
22/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
静か
技術スタック
java
領域
backend, tooling

調査の方向性

Start from Mirth.run() and how mirth.properties (plus conf/mirth.properties.d drop-ins from #405) is loaded and read ad-hoc (getInt, Boolean.parseBoolean, testPort). There is no central key/type/constraint registry yet; that schema and a fail-closed startup pass (plus a -t-style check mode) are the work. Done means any invalid value names the property and reason and the process never starts. This is design, not a first-timer patch.

索引モデルが issue の本文から書いたものです。

説明

mirth.properties values are read ad-hoc across the codebase with inline defaults, and validation is inconsistent: some settings fail fast, some crash, some silently coerce. On adjacent lines of Mirth.run(), http.port = banana throws an uncaught ConversionException via isUsingHttp()'s default-less getInt and the server thread dies with a stack trace, while https.port = banana right next to it refuses to start cleanly with "port is invalid" (testPort). Booleans coerce to false (Boolean.parseBoolean), https.*.protocols passes through unvalidated, while a few settings do have ad-hoc guards (the DH key-size clamp, password requirements). Same class of mistake, different outcomes.

Target the model nginx (nginx -t), Apache (configtest), haproxy (-c), and sshd (-t) use: one validation pass over the whole merged config (base + conf/mirth.properties.d drop-ins, #405) at startup, refuse to run on any invalid value, with a clear message naming the property and the reason. Never start on a config that doesn't fully parse.

Why this is architectural, not a patch:

  • No config schema exists. nginx validates everything because its parser is the schema; every directive has a known type and constraints. mirth.properties has no central registry of valid key -> type -> constraints -> required. Step one is building that registry.
  • Validate the merged config against the registry at startup; fail closed with a per-property message on any type/range/enum violation.
  • Mistyped keys can't be caught the way nginx catches an unknown directive: htp.port = 8080 silently leaves http.port at its default. The registry would need to flag unknown keys (warn or fail) - a design call.
  • Offer a check mode (-t-style "validate and exit") so operators can test before a restart.

Context: came up during #405, which added fail-closed handling for unreadable/malformed drop-in files. This covers invalid values in readable files.

主要言語
Java
スター
227
フォーク
81
平均マージ
2日 18時間
マージ済み PR（30日）
12

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

OpenIntegrationEngine/engine のほかの issue

OpenIntegrationEngine/engine の issue をすべて見る

似ている issue

Java の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。