[BUG] Code assist broken for userutil sources using Java 14+ syntax
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 48/100
- issue の種類
- バグ
- 明瞭さ
- おおむね明確
- 活発さ
- 静か
- 技術スタック
- java
調査の方向性
Start with com.mirth.connect.client.ui.reference.ReferenceListFactory#addUserutilReferences(String, InputStream) and identify the bundled JavaParser dependency and configured source level. Migrate its parsing and AST/visitor usage to the current com.github.javaparser API. Done means Java 17 syntax in a CLIENT userutil source is parsed and its class offers CTRL+space completions.
索引モデルが issue の本文から書いたものです。
説明
Describe the bug
The Java baseline for OIE is now Java 17, but the JavaParser library used to build code-assist references for the JavaScript editor is japa.parser JavaParser 1.0.8 (javaparser-1.0.8.jar), the legacy version that only understands an old Java grammar (no enhanced switch expressions, records, text blocks, etc.). When a CLIENT source library contains any class written with Java 14+ syntax, JavaParser fails to parse it at Administrator startup, the exception is caught and logged, and that class is dropped from the completion cache — so CTRL+space code assist is unavailable for it. Consistently reproducible.
To Reproduce
Setup: a custom extension/plugin that ships a *-userutil-sources.jar referenced in its metadata as a CLIENT library.
- In a userutil class, use any Java 14+ syntax (e.g. a switch expression):
/**
* Returns a human-readable label for the given priority code.
*
* @param code the single-character priority code
* @return the corresponding label
*/
public static String priorityLabel(final char code) {
// Java 14+ switch expression — not parseable by JavaParser 1.0.8.
return switch (code) {
case 'H' -> "High";
case 'M' -> "Medium";
case 'L' -> "Low";
default -> "Unknown";
};
}
- Package the sources into
myext-userutil-sources.jar. - Register it as a
CLIENTsource library in the extension metadata:
<library type="CLIENT" path="src/myext-userutil-sources.jar" />
- Start the Administrator (this is when userutil sources are parsed and the reference/completion cache is built).
- Open a transformer in the JavaScript editor and trigger code assist (CTRL+space) against the class.
Expected behavior
Since the project baseline is Java 17, the JavaParser used to build code-assist references should be able to parse Java 17 source, so the userutil class loads normally and CTRL+space offers completions for it.
Actual behavior
At Administrator startup, JavaParser.parse(is) in com.mirth.connect.client.ui.reference.ReferenceListFactory#addUserutilReferences(String, InputStream) throws a parse exception on the Java 14+ syntax. The catch (Exception e) swallows it and logs:
ERROR ... ReferenceListFactory - Unable to load references from userutil entry <package>/<Class>.java
japa.parser.ParseException: ...
The class is skipped, so no references are built and CTRL+space offers no completions for it — even though the same code compiles and runs fine under the Java 17 baseline.
Screenshots
N/A
Environment (please complete the following information):
- OS: Windows 11
- Java Distribution/Version: OpenJDK 17
- Connect Version: 4.5.2
Workaround(s)
Avoid Java 14+ syntax in any source that ends up in a CLIENT sources jar. For switch expressions, fall back to a classic switch statement:
public static String priorityLabel(final char code) {
switch (code) {
case 'H': return "High";
case 'M': return "Medium";
case 'L': return "Low";
default: return "Unknown";
}
}
The class still compiles and runs under Java 17; only the syntax exposed to JavaParser is downgraded. Note this is per-class: one offending class only drops its own references, not the whole jar.
Additional context
Root cause is a mismatch between the Java baseline (17) and the bundled JavaParser (japa.parser 1.0.8), which predates modern Java grammar by many language versions. The legacy japa.parser line is no longer maintained; the project moved to com.github.javaparser (3.x), which tracks current Java language levels. A fix would be to migrate ReferenceListFactory from japa.parser.* to a current com.github.javaparser:javaparser-core and keep it aligned with the configured source level. The API differs between the two (e.g. JavaParser.parse(InputStream) and the AST/visitor packages changed), so this is a small migration rather than a drop-in version bump.
I would be happy to work on this one if it has potential to me merged...
- 主要言語
- Java
- スター
- 227
- フォーク
- 81
- 平均マージ
- 2日 18時間
- マージ済み PR(30日)
- 12
環境構築
- Dockerfile または Docker Compose ファイルあり
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
OpenIntegrationEngine/engine のほかの issue
-
Outdated GitHub workflow action versions対応中かも このイシューにリンクされたプルリクエストがオープン中、またはマージ済みです。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
OpenIntegrationEngine/engine#485 ·
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
OpenIntegrationEngine/engine#478 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
OpenIntegrationEngine/engine#355 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
OpenIntegrationEngine/engine#347 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
OpenIntegrationEngine/engine#313 ·
メンテナーはふだん 1 日以内に返信
OpenIntegrationEngine/engine の issue をすべて見る
似ている issue
-
area: android good first issue help wanted testing
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
Gautam-aman/ResQNet#56 ·
メンテナーはふだん 1 日以内に返信
-
documentation hermes-queue
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
chrisalunlloyd2-sudo/mindpalace#294 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
QuicksilverMC/Argentum#31 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
saysky/ForestBlog#111 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 77/100
eclipse-hawkbit/hawkbit#3429 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信