Searchlight: keep people in context when searching across an owner

オープン
#2,998 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
15/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
活発
領域
frontend, search

調査の方向性

This is design research, not a code change. Start from the owner-wide concept search row that links to /search/ with an owner filter, then look at how the Repositories tab renders Search through its url prop. Compare the options (stay on the repository page, land on the owner page, or a results view inside the current page) against the oclapi2 /concepts/ owner filter, since there is no /orgs/:org/concepts/ route. Done means the options are compared with their API and UI work, mockups exist, and the team's decision is recorded on the issue.

索引モデルが issue の本文から書いたものです。

説明

component/web decision/human-review signal/low-risk signal/needs-human signal/small-scope stage/triaged type/feature

Choosing the owner-wide concept search takes you off the organization, user or repository page and over to global search with an owner filter. The goal of OpenConceptLab/ocl_issues#2987 was to stay in context. Research and mock up how to do that, for the team to decide on before any build.

What's there now:

  • The row goes to /search/?filters={"owner":"CIEL","ownerType":"Organization"}&q=hem&type=concepts.
  • Organization and user pages have no Concepts tab.
  • Search can already render inside a page through its url prop, which is how the Repositories tab works.
  • oclapi2 has no /orgs/:org/concepts/ route; today's search uses the owner filter on /concepts/.

Questions for the team:

  • What does "same context" mean from a repository page: stay on that page, or land on the owner's page?
  • Where do results go: a Concepts tab on the owner's page, a results view inside the current page, or somewhere else?
  • Can people widen or clear the scope from there, as they can in global search, and do mappings need to be included?

Acceptance criteria

  • Options are compared, with the API and UI work each needs. All keep today's rule: private repositories appear only for people who can already see them.
  • Mockups of the preferred options.
  • The team reviews them, and the decision is recorded here.
  • Build tickets are filed.

Related: OpenConceptLab/ocl_issues#2987, OpenConceptLab/ocl_issues#2997 (a scope selector could change how people reach this).

主要言語
言語のデータがありません
スター
4
フォーク
2
平均マージ
2時間 12分
マージ済み PR(30日)
1

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

OpenConceptLab/ocl_issues のほかの issue

OpenConceptLab/ocl_issues の issue をすべて見る

似ている issue

Web Dev の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。