Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

landing: sample chart's 7-day axis carries a month of returns

オープン
  • 何か問題がありますか？
#369 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
55/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
静か
技術スタック
react, typescript
領域
frontend

調査の方向性

Start with BoardPreview.tsx and compare SAMPLE_CURVES with SAMPLE_STANDINGS; read Race.tsx to confirm the competition figures stay there. Re-derive the sample curves at plausible seven-day magnitudes, then check the chart in-browser and re-derive both reserved-height constants if the chip strip changes. Done when the landing chart’s seven-day axis matches its sample returns without changing the competition standings.

索引モデルが issue の本文から書いたものです。

説明

The hero card on / draws a seven-day axis over returns that took about a month to happen.

  • SAMPLE_CURVES (BoardPreview.tsx:56) runs "7d ago" → "5d ago" → … → "Now", and its own doc comment describes Live-board shape, "one session at a time".
  • SAMPLE_STANDINGS beside it (:57-61) carries +21.0% / +5.5% / +2.8% / +1.4% / −1.5% — Competition-window figures over roughly a month. Race.tsx:9 imports the same array and heads it "Competition Standings", under copy reading "Competition: one fixed window of market history".
  • The curves were built to land exactly on those returns, so nothing on the card contradicts itself. It just says DeepSeek made +21.0% in seven days.

Pre-existing — #367 did not introduce it. Filing it now because #367 roughly triples the chart and makes that axis the most prominent claim on the acquisition page, which raises the cost of leaving it wrong.

#367 corrected the caption from "over the competition window" (which contradicted the axis) to "over the last seven days" (which matches it). That is as far as wording can go: the caption now truthfully describes a chart whose underlying data is borrowed.

Why this is polish, not a correctness bug

The card carries an Illustrative example chip, and the numbers are openly fabricated — no user or model is being misrepresented. The cost is credibility on the page whose job is credibility.

Options
  1. Re-derive SAMPLE_CURVES at plausible seven-day magnitudes and give BoardPreview its own returns. Race.tsx keeps the Competition figures, which is where they belong. Costs a second array and a re-derivation of the chart-height reserves if the chip text changes width.
  2. Relabel the axis to the competition window ("Apr 15" … "May 15"). Cheaper, but re-introduces the contradiction with SAMPLE_CURVES' documented Live-board shape.

Preference is (1) — the sample data is fabricated anyway, so fabricating it at the right magnitude costs nothing but the edit.

Note if touching this: the chip strip's width feeds two measured constants (--board-chart-reserve, 590 stacked / 390 at lg+) and the comment above them says to re-derive both in-browser if the strip's content changes. Don't reason them out.

主要言語
Python
スター
767
フォーク
156
平均マージ
1日 19時間
マージ済み PR（30日）
71

環境構築

  • Dockerfile または Docker Compose ファイルあり
  • プルリクエストのテンプレートなし
  • コントリビューションガイドなし

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Open-Finance-Lab/AgenticTrading のほかの issue

Open-Finance-Lab/AgenticTrading の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。