Generate the routing gRPC field mapping from a single source of truth
メンテナーはふだん 1 日以内に返信
@ramakrishnap-nv がすでに取り組んでいます。
2026年8月14日 から。
評価
この issue はまだ評価されていません。
説明
Follow-up to review feedback from @rg20 on #1597 (mapper, to_device, round-trip test).
Problem
Adding one field to cpu_routing_problem_t today means editing five places by hand:
- the struct —
cpp/include/cuopt/routing/cpu_routing_problem.hpp - the wire format —
cpp/src/grpc/routing/cuopt_routing.proto - host → proto —
map_routing_problem_to_proto - proto → host —
map_proto_to_routing_problem - host → device —
cpu_routing_problem_t::to_device
Nothing enforces that all five stay in sync. Not the compiler, not a test.
The failure mode is worse than the usual boilerplate complaint. A forgotten field
does not crash — the value silently never crosses the wire, and the remote solve
returns a plausible answer for a different problem than the one submitted.
That is expensive to detect and easy to miss in review.
Scale: cpu_routing_problem_t currently has 41 std::vector members, 6
std::map members, and 5 nested struct types. Roughly 80% of that is one
regular pattern repeated 41 times.
Suggested direction
Both review threads share a single root cause — the field list is written out
five times — so it is worth fixing once rather than twice.
Single source of truth for the routing field list, expanded into the proto,
both mapper directions, to_device, and a round-trip test. Either:
- a routing section in
cpp/src/grpc/codegen/field_registry.yaml, reusing
generate_conversions.py(which already emits 27.incfiles and supports
repeated_messages), or - an X-macro field-list header, which is less machinery and also covers
to_device, which is outside the gRPC codegen's remit.
Caveat worth designing around: routing is less regular than LP. The 6 maps carry
real semantics — order_service_times is keyed by vehicle id with -1 meaning
"all vehicles", vehicle_breaks maps to a vector of structs. Expect ~80%
generated plus a tail of hand-written special cases, not a pure win.
Cheaper first step
A round-trip property test — populate every field with distinct values, go
host → proto → host, compare — catches the same class of bug for a fraction of
the effort and does not restructure anything. Worth doing first, and worth
keeping even after codegen lands.
Prior art in-tree: python/cuopt/cuopt/tests/routing/test_routing_grpc_serialization.py
already fails loudly when a new cuopt.routing._deferred._SETTERS entry is
unmapped. That guards the Python DataModel → cpu_routing_problem_t direction;
this issue is about the remaining C++ hops.
Not blocking #1597
#1597 is approved with these threads open, so this is design follow-up rather
than a merge blocker.
- 主要言語
- Cuda
- スター
- 1.1k
- フォーク
- 255
- 平均マージ
- 1日 22時間
- マージ済み PR(30日)
- 102
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
NVIDIA/cuopt のほかの issue
-
[BUG] Constraint validation reports CSR offset count as the number of rows対応中かも @0z5a が 2 日前に担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
メンテナーはふだん 1 日以内に返信
-
ci: pr-test-summary job shows red when the GitHub API returns persistent 5xx errors対応中かも @0z5a が 2 日前に担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
メンテナーはふだん 1 日以内に返信
-
難易度 1/5 1時間未満 初心者へのやさしさ 82/100
メンテナーはふだん 1 日以内に返信
-
bug mip
難易度 4/5 1〜2日 初心者へのやさしさ 53/100
NVIDIA/cuopt#2290 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
[BUG] Dataset downloader reports success and replaces data after a failed download対応中かも @0z5a が 2 日前に担当しました。 オープン
難易度 3/5 1〜2日 初心者へのやさしさ 75/100
メンテナーはふだん 1 日以内に返信