Closed TCP listening socket stays in LISTEN inside the sandbox until another bind on the same port
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 55/100
- issue の種類
- バグ
- 明瞭さ
- 明確に書かれている
- 活発さ
- 活発
- 技術スタック
- docker, rust
- 領域
- networking
調査の方向性
Start in crates/openshell-sandbox/src/network_broker.rs, especially collect_closed_socket_entries and the broker's descriptor handling after listen; also check the behavior introduced by #4150. Reproduce using the supplied sandbox steps, then verify that closing or exiting a listener removes it from /proc/net/tcp and connections fail with connection refused.
索引モデルが issue の本文から書いたものです。
説明
User Story
I use OpenShell to run coding agents that start a local web server inside the sandbox and run browser tests against it.
I directly encountered a listening port that stays open after the server that owned it has closed it and exited.
This makes it look as if a server is still running on that port when nothing is.
Problem Statement
Inside a sandbox, when a workload closes a TCP listening socket (or the process that owns it exits), the socket does not go away. It stays in LISTEN on the same address and port:
/proc/net/tcp(andss -ltn) still lists it.- No process in the sandbox owns it.
- A client that connects is accepted by the kernel but never gets a response.
It goes away only when something else in the sandbox binds the same port. A later bind + listen on that port succeeds, and the stale entry disappears at that moment.
For maintainers: the network broker keeps its own descriptor for every brokered socket. It only reclaims descriptors for closed sockets when a bind hits EADDRINUSE, or when the registry or descriptor budget fills up (collect_closed_socket_entries in crates/openshell-sandbox/src/network_broker.rs). Since #4150, accept no longer goes through the broker, so the broker may not need to keep a listening socket's descriptor after listen succeeds. We have not tested that change.
Impact / Why This Matters
- Health checks and port probes that run after a server stops see a port that still accepts connections but never answers. They wait for their timeout instead of failing fast.
- Tools that check for leftover processes or ports after a test run report a listener that no process owns, which is confusing to debug.
- Workaround today: after the server stops, bind the same port from a socket that never listens (for example, a connect from
127.0.0.1:<port>to a closed port). The bind makes the stale entry go away.
Acceptance Criteria
- After a workload closes a listening socket, the address and port no longer show as
LISTENin the sandbox. - After the process that owns a listening socket exits, the address and port no longer show as
LISTENin the sandbox. - Connecting to that port after it is closed fails with connection refused, as it would outside the sandbox.
Reproduction Steps
- Create a sandbox with the default image and policy:
openshell sandbox create --name listen-repro -- sleep infinity - Open a listener on 127.0.0.1:4400, close it, then check whether the port is still listening and whether a connection gets an answer:
openshell sandbox exec --name listen-repro -- bash -c ' perl -MIO::Socket::INET -e '\''my $s = IO::Socket::INET->new(LocalAddr => "127.0.0.1", LocalPort => 4400, Listen => 5, ReuseAddr => 1) or die "listen: $!"; close $s; print "listener closed\n"'\'' sleep 3 grep -q ":1130 00000000:0000 0A" /proc/net/tcp && echo "127.0.0.1:4400 still LISTEN" || echo "gone" perl -MIO::Socket::INET -e '\''my $c = IO::Socket::INET->new(PeerAddr => "127.0.0.1:4400", Timeout => 2); print $c ? "connect: accepted by kernel\n" : "connect failed: $!\n"; if ($c) { $c->blocking(0); sleep 2; my $n = sysread($c, my $b, 1); print defined $n ? "read $n bytes\n" : "no response\n" }'\'' ' - Expected:
gone, thenconnect failed: Connection refused.
Actual:127.0.0.1:4400 still LISTEN, thenconnect: accepted by kernelandno response.
The same happens when the owning process exits without closing the socket, and with listeners written in other languages (Node.js net.Server behaves the same way).
Environment
- OpenShell: 0.1.2 (
openshell --version) - OS: macOS 27.0.1 on Apple silicon (arm64)
- Deployment: local gateway, Docker Desktop 29.8.2 (Linux kernel 7.0.14-linuxkit), default sandbox image (Ubuntu 24.04.5 LTS), default policy
- Not tested on v0.1.3-pre.6, but the reclaim logic in
network_broker.rslooks the same there and onmain.
Logs
listener closed
127.0.0.1:4400 still LISTEN
connect: accepted by kernel
no response
- 主要言語
- Rust
- スター
- 15.4k
- フォーク
- 1.7k
- 平均マージ
- 1日 21時間
- マージ済み PR(30日)
- 366
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
NVIDIA/OpenShell のほかの issue
-
state:triage-needed
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
メンテナーはふだん 1 日以内に返信
-
docs: document workspace and provider label capabilities対応中かも @johntmyers が 3 日前に担当しました。 オープンarea:docs
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
NVIDIA/OpenShell#4250 · コメント 2 件 ·
メンテナーはふだん 1 日以内に返信
-
bug(driver-mxc): test helper fails to compile after gateway-name argument対応中かも @feloy が 5 日前に担当しました。 オープンstate:triage-needed
難易度 1/5 1時間未満 初心者へのやさしさ 88/100
メンテナーはふだん 1 日以内に返信
-
bug: install.sh ignores XDG_CONFIG_HOME for the local gateway config対応中かも @fede-kamel が 8 日前に担当しました。 オープンarea:cli os:linux os:macos state:validated
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
NVIDIA/OpenShell#4042 · コメント 2 件 ·
メンテナーはふだん 1 日以内に返信
-
state:triage-needed
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
NVIDIA/OpenShell#3995 · コメント 2 件 ·
メンテナーはふだん 1 日以内に返信
NVIDIA/OpenShell の issue をすべて見る
似ている issue
-
bug user-priority/P2
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
rescript-lang/rescript#8765 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
nautechsystems/nautilus_trader#5287 ·
メンテナーはふだん 1 日以内に返信
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
farion1231/cc-switch#8072 ·
メンテナーはふだん 1 日以内に返信
-
Python 3.15 support対応中かも @amnesiaof が今日担当しました。 オープンL: python L: python:uv
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
dependabot/dependabot-core#16524 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信