tensor_save returns true when the write fails (a full device, a size limit): the file is truncated and the call says it was saved

オープン
#2,473 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
55/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
c
領域
backend

調査の方向性

Start with src/builtins_tensor.c and compare tensor_save with write_text and write_bytes to determine the repository’s writer error and cleanup behavior. Inspect git grep -n 'fwrite' src/ for other unchecked writers, and review docs/BUILTINS.md for the tensor_save row. Done means tests cover /dev/full, a regular file under RLIMIT_FSIZE, and successful saves, with the documented failure behavior and partial-file handling verified.

索引モデルが issue の本文から書いたものです。

説明

area:stdlib found-by:critic kind:silent-wrong

tensor_save returns true when the write fails. It checks that the path opens and nothing after that: src/builtins_tensor.c ignores the result of every fwrite and of fclose, then returns make_bool(1).

Found by a blind review of #2468 (a documents change), which ran the sentence "returns true once the file is written" against a full device and a size limit. Seen on phase2-numbers at 05e6d6fd; the code is older than the branch.

Shows it

A device that is full:

p is buf_from_list of ([1, 2])
print of (tensor_save of [p, "/dev/full"])

prints true, nothing on stderr, exit code 0. A direct write to /dev/full fails with ENOSPC.

A regular file, with the process's file-size limit at 64 bytes (RLIMIT_FSIZE=64, SIGXFSZ ignored):

p is buf_from_list of ([1, 2])
print of (tensor_save of [p, "t.bin"])

prints true; t.bin holds 64 of the 112 bytes the same program writes without the limit. Its header declares the whole tensor. A later tensor_load of that file reads a truncated tensor.

What it does report: a path it cannot open (a missing folder, a folder as the path, no permission) returns false.

This is a saved checkpoint that says it was saved. The rule it breaks is the repository's own: no silent wrong answers.

Done when

  • tensor_save reports a failed or short write: the results of fwrite and fclose are checked, and a failure is the builtin's failure answer (and, like the other file writers, a catchable io error where the repository's rule for writers says so: decide on this issue which, from what write_text and write_bytes do).
  • A truncated file is not left behind as if whole: write to a temporary name and rename, or remove the partial file, whichever the other writers do.
  • A test shows both failures red first on the code as it is: the full device, and a size limit on a regular file; and the unchanged success path.
  • The other tensor and model writers of src/ that return a success bit are listed with whether they check their writes (git grep -n 'fwrite' src/), and each unchecked one is fixed here or named in an issue of its own.
  • docs/BUILTINS.md's row of tensor_save says what it returns on success and on each failure.

— Claude DevBox

主要言語
C
スター
3
フォーク
7
平均マージ
3時間 28分
マージ済み PR(30日)
270

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

InauguralSystems/EigenScript のほかの issue

InauguralSystems/EigenScript の issue をすべて見る

似ている issue

C の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。