Sign-in markers: stop mirroring to the legacy shared record one release after #1969

オープン
#1,970 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
20/100
issue の種類
リファクタリング
明瞭さ
おおむね明確
活発さ
活発
技術スタック
typescript

調査の方向性

Start with DESIGN.md and the code from #1969 that writes the per-entity Studio:PotentiallyAuthenticated:<entityId> keys, then find where the mirror into the shared Studio:PotentiallyAuthenticated record happens and where the sign-out sweeps read it. Done means the mirror is gone, the old record is deleted on load after the one-time migration, the Studio:PotentiallyAuthenticatedMigrated special handling is removed, and DESIGN.md matches. Do not start until #1969 has shipped and run in production for a release; the issue says so.

索引モデルが issue の本文から書いたものです。

説明

What to do

#1969 moves remembered sign-in markers from the shared Studio:PotentiallyAuthenticated record to one key per entity (Studio:PotentiallyAuthenticated:<entityId>). Studio tabs from before #1969 read the shared record only at load and write their whole copy back. So for one release #1969 also mirrors every marker change into the old record, and its sign-out sweeps read it. That keeps old tabs, and a rollback, consistent with new ones.

One release after #1969 ships to production:

  1. Stop mirroring into Studio:PotentiallyAuthenticated.
  2. Delete the old record on load, keeping the one-time migration of anything still in it.
  3. Drop the old-record reads from the sign-out sweeps and the Studio:PotentiallyAuthenticatedMigrated flag's special handling, and update DESIGN.md.

Why it can't wait

While the mirror exists, the old record keeps the limits #1969 removed for new tabs. These are the review findings recorded against it:

  • a read-modify-write race between tabs on the mirrored record;
  • a rewrite per entity during a full sign-out;
  • an unreadable record replacing it on write;
  • the migration's one-time copy, and an old tab's write-back bringing back a signed-out marker.

Don't remove it until production has run #1969's release long enough that no tab from before it is still open.

Review-Deferral: d861d82357ec0895 severity=minor category=concurrency
Review-Deferral: 58c8df7ce1fb2420 severity=nit category=concurrency
Review-Deferral: 43cd604ec076ea0e severity=nit category=concurrency
Review-Deferral: 81c98bc4312a6a42 severity=nit category=performance
Review-Deferral: 1282fb67a2760cbc severity=nit category=data-integrity
Review-Deferral: a947843f6d1dd466 severity=nit category=correctness
Review-Deferral: defde12cf7a0afc8 severity=nit category=correctness

Raised by the cross-model review of #1969 (#1968).

🤖 Generated by Anthropic Claude Code (Claude Opus 5.5); posted via @dawsontoth.

主要言語
TypeScript
スター
5
フォーク
4
平均マージ
2日 13時間
マージ済み PR(30日)
60

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

HarperFast/studio のほかの issue

HarperFast/studio の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。