[Feature]: out-of-tree graph store keyed by repository, shared across worktrees
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 38/100
- issue の種類
- 機能追加
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- git, python
調査の方向性
Start with graphify/paths.py and the existing worktree-guard test in test_hooks.py, then trace how CLI commands resolve and write GRAPHIFY_OUT. For the first PR, use real git worktree fixtures to cover per-repository resolution, origin.json, the linked-worktree write guard, and graphify where. Later work should follow the skill and agent text in install.py and the proposed store list/prune commands.
索引モデルが issue の本文から書いたものです。
説明
Problem or use case
I'd like graphify to keep its graphs outside the repositories it indexes, in a per-user store. I want the graphs. What I don't want is graphify-out/ inside other people's repos, or a set of workarounds I have to maintain to keep it out.
On a typical day I clone about ten repositories and open around three git worktrees in each, one per agent task. Since graphify writes graphify-out/ into the checkout, every clone and every worktree needs its own handling:
- The output has to be ignored somewhere, and the repo's
.gitignoreisn't mine to edit. So it goes into.git/info/excludeor a global excludes file, without a trailing slash in case it's a symlink. - A fresh worktree has no graph, and rebuilding one per worktree costs time and LLM calls. Copying the primary checkout's graph in doesn't help: incremental extraction then treats the whole corpus as changed (#2654).
- A symlink from each worktree to the primary checkout's
graphify-outneeds apost-checkouthook ininit.templateDir. That hook doesn't fire in repos that set their owncore.hooksPath. Anupdatefrom the worktree also writes straight through the link into the primary graph. - An absolute
GRAPHIFY_OUTis one global value with no per-repo key. The skill ignores it anyway (#2571).
Each of these works on its own terms. Together they are a pile of glue per clone, just to read someone else's code with a graph.
Proposed solution
My proposal is an opt-in store mode. Graphs live in a per-user directory keyed by repository, nothing is written to the working tree, and one global setting turns it on. After that a new clone or worktree needs no preparation.
I read through v8 to check how much this touches. Most of it already works with an absolute GRAPHIFY_OUT, so the design is mostly about computing that value per repo:
- Resolution happens in
graphify/paths.pyat import time, and the first match wins. IfGRAPHIFY_OUTis set, nothing changes. If an in-treegraphify-out/already exists at the repo top, nothing changes either, so teams that commit their graph are not affected. If store mode is on, the result is<store>/<key>. Otherwise it staysgraphify-out. The resolved value is absolute and goes intoGRAPHIFY_OUT, so the modules that copy the constant at import keep working as they are. - Store mode is enabled with
GRAPHIFY_STORE=1or with{"store": true}in~/.graphify/config.json. The config file is there because git hooks run from GUI clients don't see the shell environment. The default location is~/.graphify/store/, next to the per-user state graphify already keeps, andGRAPHIFY_STORE_DIRoverrides it. - The key is the repo directory name plus a short hash of
git rev-parse --path-format=absolute --git-common-dir. That gives every linked worktree of a clone the same key. Outside git, the hash comes from the absolute cwd. Each entry also writes anorigin.jsonwith the common dir, the primary worktree path and the remote URL, for listing and pruning later. - Worktrees share the clone's graph read-only. Read commands, hook-guard and MCP work from any worktree. Write commands (
extract,update,watch,cluster-only) exit with a message pointing at the primary checkout. The existing worktree guard in the hooks already skips rebuilds there. Sincesource_filepaths are relative to the scan root, a graph built in the primary checkout resolves fine from a worktree. In store mode.graphify_rootis always written absolute. This would also cover the read-side fallback from #2064. - A new
graphify wherecommand prints the resolved output dir exactly as the process sees it. It is the only new CLI surface, and the skill uses it to find the graph. - The skill and the always-on text stop hardcoding the path. Each bash block starts with
GFY_OUT="$(graphify where 2>/dev/null || echo graphify-out)", and every literalgraphify-out/becomes"$GFY_OUT"/. Inline Python gets the path from an env var, never through string interpolation. In default modegraphify whereprintsgraphify-out, so current behaviour doesn't change. This overlaps with #1054 and #2720, and I'd rather work with those authors than open a competing change. graphify store listshows each entry with its origin, size and last write, and flags orphans whose clone is gone.graphify store pruneremoves orphans and is a dry run by default.- In store mode
hook installdoesn't write the.gitattributesmerge-driver line, since there is no in-tree graph to merge. Nothing else in the hooks changes.
I'd split the work into three PRs, each useful on its own:
- Resolution, the key,
origin.json, the write guard in linked worktrees, andgraphify where. Tests would use realgit worktree addfixtures, like the existing worktree-guard test intest_hooks.py. CLI, hooks and MCP users get the benefit from this one alone. - Skill fragments, always-on blocks and the agent text in
install.pyswitch tographify where, including the--blessrun and the sanctioned always-on edits. graphify store listandgraphify store prune.
A few things I'm not sure about:
- Should store mode stay opt-in, or become the default in some later major version?
- Is a shared read-only graph the right policy for worktrees? The alternative is an opt-in per-worktree graph keyed by
--git-dir, seeded from the clone's graph once #2654 is fixed. - Is
~/.graphify/store/a good default, or would you prefer$XDG_DATA_HOME/graphify/on Linux? I wouldn't put it under a cache dir, because the semantic pass costs money to rebuild.
Alternatives considered
graphify remote(#1751, #1752) moves the data out, but the repo still gets agraphify-outsymlink, a committed.graphify/config and a.gitignoreedit. That fits a team sharing one graph. It doesn't fit leaving someone else's repo untouched.- Making the skill honour
GRAPHIFY_OUT(#1054, #2720) is needed, and step 6 builds on it. It is still one global value with no per-repo key, though. - The worktree fallback in #2064 lets read commands use the primary checkout's graph. It covers part of step 4, but not the in-tree writes or the skill.
- #686 asked for worktree support earlier and got
GRAPHIFY_OUT, which leads back to the points above.
Area
CLI or installation
Are you willing to submit a PR?
Yes, I can work on this. If the design looks right to you, I'll start with the first PR, and I'm happy to change any part of it before that.
- 主要言語
- Python
- スター
- 124k
- フォーク
- 11.9k
- PR マージ指標
- 30日以内にマージされた PR はありません
環境構築
このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
Graphify-Labs/graphify のほかの issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 86/100
Graphify-Labs/graphify#3763 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
Graphify-Labs/graphify#3611 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
Nix supportオープン
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
Graphify-Labs/graphify#3193 · リアクション 2 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 1/5 1時間未満 初心者へのやさしさ 92/100
Graphify-Labs/graphify#2871 · コメント 2 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
Graphify-Labs/graphify#2865 ·
メンテナーはふだん 1 日以内に返信
Graphify-Labs/graphify の issue をすべて見る
似ている issue
-
approved Good First Issue scope: docs
難易度 1/5 1時間未満 初心者へのやさしさ 85/100
hiero-ledger/hiero-sdk-python#2730 · コメント 3 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
wemake-services/wemake-django-template#3178 · リアクション 1 件 ·
メンテナーはふだん 1 日以内に返信
-
md/asciidoc/csv: an explicit `encoding="utf-8"` keeps a leading BOM, the auto-detect path drops itオープン
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
docling-project/docling#4846 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
neurostuff/NiMARE#1181 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
pytest-dev/pytest#15180 ·
メンテナーはふだん 1 日以内に返信