Contact search blocks the UI with a large address book
メンテナーはふだん 4 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 35/100
調査の方向性
Start with ContactsFragment.onSearchQueryChanged(), the entry point named in the issue, and trace how each keystroke filters and normalizes contacts. Compare the current behavior with the reported working version’s approach to precomputing searchable text and filtering in the background. Done means large address books remain responsive while typing and deleting, with existing matching and ordering preserved; the report says a fix is already working, so check with the contributor before taking it on.
索引モデルが issue の本文から書いたものです。
説明
Checklist
- I can reproduce the bug with the latest version given here.
- I made sure that there are no existing issues - open or closed - to which I could contribute my information.
- I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
- I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
- I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
- This issue contains only one bug.
- I have read and understood the contribution guidelines.
Affected app version
1.11.1
Affected Android/Custom ROM version
Android 10
Affected device model
Huawei LYA-L29
How did you install the app?
F-Droid / IzzyOnDroid
Steps to reproduce the bug
- Use an address book with several thousand contacts (3,520 contacts containing phone numbers in my test).
- Open the Contacts tab and activate search.
- Type and delete queries of 1 to 7 characters.
- Observe UI stalls while typing.
Expected behavior
Typing and deleting a query should remain responsive with a large address book in a fast way not delaying...
Actual behavior
Contact filtering and repeated normalization run on the main thread for each keystroke, causing visible stalls.
Screenshots/Screen recordings
Not attached. Timing measurements are included below.
Additional information
I have a working version with a fix, tested on the same phone and address book. I reproduced the original problem and verified the improvement on the device. Search feels substantially faster and more responsive in everyday use.
| Measurement | Before | Working version |
|---|---|---|
| Main-thread work per keystroke | 70 to 185 ms | 2 to 31 ms, typically 3 to 6 ms |
| Filtering | On the main thread | 7 to 30 ms on a background thread |
The first keystroke in the baseline took 437 ms. The measurements used temporary SystemClock.elapsedRealtime() instrumentation around the search handler, with roughly 60 keystrokes of typing and deleting queries. These are single-device results, and main-thread time is not the same as end-to-end result latency.
ContactsFragment.onSearchQueryChanged() repeatedly normalizes up to six fields per contact on every keystroke. My patch precomputes searchable text once per contact list, performs filtering on a background thread, and discards outdated results when the query changes or search closes. It preserves the existing matching and ordering rules, including accent-insensitive and numeric searches, which I have tested on the device.
This concerns typing in the Contacts tab, rather than initial contact loading or search in the dial pad/call history.
I'd like to contribute this as a focused PR. Your contribution guidelines require the help wanted label before submission. Could a maintainer add it so I can open the PR?
- 主要言語
- Kotlin
- スター
- 1.4k
- フォーク
- 213
- 平均マージ
- 5日 10時間
- マージ済み PR（30日）
- 14
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
FossifyOrg/Phone のほかの issue
-
feature request needs triage
難易度 2/5 1〜3時間 初心者へのやさしさ 63/100
FossifyOrg/Phone#922 ·
メンテナーはふだん 4 日以内に返信
-
bug needs triage
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
FossifyOrg/Phone#914 · コメント 2 件 ·
メンテナーはふだん 4 日以内に返信
-
bug needs triage
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
FossifyOrg/Phone#889 ·
メンテナーはふだん 4 日以内に返信
-
feature request needs triage
難易度 2/5 半日 初心者へのやさしさ 60/100
FossifyOrg/Phone#822 ·
メンテナーはふだん 4 日以内に返信
-
feature request needs triage
難易度 3/5 半日 初心者へのやさしさ 70/100
FossifyOrg/Phone#913 ·
メンテナーはふだん 4 日以内に返信
FossifyOrg/Phone の issue をすべて見る
似ている issue
-
bug follow-up
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
メンテナーはふだん 1 日以内に返信
-
binding:web core docs p3
難易度 2/5 1〜3時間 初心者へのやさしさ 85/100
RunanywhereAI/runanywhere-sdks#1123 ·
メンテナーはふだん 1 日以内に返信
-
StepExamBenchmarkTest runs a loop and prints a timing but asserts nothing対応中かも このイシューにリンクされたプルリクエストがオープン中、またはマージ済みです。 オープンjules
難易度 1/5 1時間未満 初心者へのやさしさ 82/100
open-learning-exchange/myplanet#18199 · コメント 1 件 ·
メンテナーはふだん 4 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
auth0/Auth0.Android#1095 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
Scheme-less stream URLs throw NullPointerException instead of URISyntaxException対応中かも @blihio が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
pedroSG94/RootEncoder#2218 ·
メンテナーはふだん 3 日以内に返信