Extensions can't open a tab in a container: cookieStoreId is dropped in GeckoWebExtension.onNewTab

オープン
#699 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
35/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
android, kotlin
領域
api, mobile

調査の方向性

Start in GeckoWebExtension.onNewTab in the android-components engine-gecko code, where tabDetails.cookieStoreId is currently not forwarded to tabHandler.onNewTab. Use a-c-weblibre-new-window-context.patch as the reference for carrying a contextId into a new engine session, and check GeckoTabsApiImpl.addTab on the WebLibre side. Done means tabs.create({cookieStoreId}) opens the tab in the requested container, which you can verify with the minimal extension the reporter describes.

索引モデルが issue の本文から書いたものです。

説明

enhancement needs-triage

Is your feature request related to a problem? Please describe.

WebLibre ignores cookieStoreId when an extension creates a tab. browser.tabs.create({ url, cookieStoreId: "firefox-container-<uuid>" }) resolves successfully, but the tab opens in the default container, so an extension has no way to target one of WebLibre's containers.

That makes container-scoped automation impossible in WebLibre although the same add-ons work in desktop Firefox — e.g. opening a set of links into separate accounts, "open this link in " helpers, or a request queue that fans one URL out to several containers.

Related earlier reports: #283 (contextualIdentities — a larger ask, closed) and #587 (extensions can't modify cookies in containers — confirms containers are mapped to Gecko's contextId). This report is deliberately narrower than both.

Describe the solution you'd like

Make extension-created tabs honor cookieStoreId.

I traced where the value is lost. GeckoView already provides it (WebExtension.CreateTabDetails.cookieStoreId), and WebLibre already forwards a contextId when it creates tabs itself (GeckoTabsApiImpl.addTab(..., contextId, ...) → createTab(contextId = ...)). The value is dropped one layer earlier, in android-components:

// components/browser/engine-gecko/.../GeckoWebExtension.kt
override fun onNewTab(ext: GeckoNativeWebExtension, tabDetails: CreateTabDetails): GeckoResult<GeckoSession>? {
    ...
    tabHandler.onNewTab(
        this@GeckoWebExtension,
        geckoEngineSession,
        tabDetails.active == true,
        tabDetails.url ?: "",
        isPrivate,                     // tabDetails.cookieStoreId is not forwarded
    )

So the fix looks like the pattern already used in a-c-weblibre-new-window-context.patch, which carries the opener's contextId into a new engine session for TARGET_WINDOW_NEW:

  • create the new engine session with contextId = tabDetails.cookieStoreId
  • keep the tab model's contextId consistent (as WindowFeature does)
  • optionally forward the value through TabHandler.onNewTab / onNewTabOverride so the app can pass it to addTab(..., contextId = …)

Scope: creating a tab in an already known container id only. contextualIdentities (listing/creating containers) is not needed for this use case, so this does not reopen #283.

Describe alternatives you've considered

  1. Container-targeted deeplink / intent extra (e.g. weblibre://open?url=…&container=…). Useful for external launchers, but from inside an extension it costs an extra throwaway tab, and it does not fix the tabs.create contract.
  2. browser.contextualIdentities (#283). Not needed here; listing/creating containers is out of scope.
  3. Manual workaround: tabs.update() on a tab that already exists in a container keeps that container, so a container that has one open tab can be reused — but nothing can be opened into a container that has no tab yet.

Additional context

Measured on WebLibre 0.40.0, GeckoView 158.0.2, Android 16 (Xiaomi Pad mini):

Operation Result
tabs.create({url, cookieStoreId: "firefox-container-<uuid>"}) opens in firefox-default, no error
tabs.create({url, cookieStoreId: "firefox-container-1"}) opens in firefox-default
activate a tab in the target container, then tabs.create({url}) still firefox-default
browser.contextualIdentities undefined (with the permission declared)
browser.tabs.query({cookieStoreId}) works — filters correctly
tabs.update({tabId, url}) on a tab already in a container keeps the container

Background: GeckoView implemented the cookieStoreId parameter for tabs.create in 2020 (bug 1622500) ahead of Fenix containers, which then did not ship — which is likely why the android-components callback still carries only url and isPrivate.

I can provide a minimal MV2 reproduction extension (manifest + ~20 lines) and, if you'd like, a patch against fennec-components plus the small GlobalComponents.kt change. I have had container-related issues/PRs accepted in other container extension projects (Container Tab Groups), so I'm happy to do the patch work.

主要言語
Dart
スター
1k
フォーク
41
PR マージ指標
30日以内にマージされた PR はありません

環境構築

このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

FaFre/WebLibre のほかの issue

FaFre/WebLibre の issue をすべて見る

似ている issue

Dart の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。