Command.runWith has no way to opt out of its own console-rendered help/error output on parse failures
メンテナーはふだん 1 日以内に返信
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 48/100
- issue の種類
- 機能追加
- 明瞭さ
- おおむね明確
- 活発さ
- 静か
- 技術スタック
- typescript
- 領域
- cli
調査の方向性
Start in packages/effect/src/unstable/cli/Command.ts, reading runWith, its ShowHelp catchFilter, and showHelp. Run the missing-name reproduction to observe the console writes and surfaced failure. Done means a supported runWith configuration or hook provides the requested control without requiring ambient Console buffering, with behavior covered by relevant CLI tests.
索引モデルが issue の本文から書いたものです。
説明
Effect version
4.0.0-beta.93 (effect/unstable/cli)
Description
Command.runWith's parser (packages/effect/src/unstable/cli/Command.ts) unconditionally renders its own help/error output to the console whenever a run fails with CliError.ShowHelp, with no way for a host application to opt out of, redirect, or make that rendering conditional on the specific failure. The catchFilter at the end of runWith catches every ShowHelp failure and calls showHelp(command, error) before re-failing with the same error:
const showHelp = <Name extends string, Input, E, R, ContextInput>(
command: Command<Name, Input, ContextInput, E, R>,
error: CliError.ShowHelp
): Effect.Effect<void, CliError.CliError, Environment> =>
Effect.gen(function*() {
const formatter = yield* CliOutput.Formatter
const helpDoc = yield* getHelpForCommandPath(command, error.commandPath, GlobalFlag.BuiltIns)
yield* Console.log(formatter.formatHelpDoc(helpDoc))
if (error.errors.length > 0) {
yield* Console.error(formatter.formatErrors(error.errors as any))
}
})
// ...
Effect.catchFilter(
(error) =>
CliError.isCliError(error) && error._tag === "ShowHelp"
? Result.succeed(error)
: Result.fail(error),
(error) => Effect.andThen(showHelp(command, error), Effect.fail(error))
),
A host CLI that wants full ownership of its own error/usage rendering — to match a different CLI framework's exact wording, to choose which stream a given failure lands on, or to suppress the built-in render entirely for specific failure tags — has no supported way to do that. runWith's config parameter is just { version: string }; there's no hook to skip, replace, or redirect the internal Console.log/Console.error calls.
Today the only way to get that control is to swap out the ambient Console.Console service for the duration of the run, buffer every log/error write, wait for the run's Exit, inspect the ShowHelp's errors array to classify what should have happened, and then selectively replay/redirect/drop the buffered writes. That means:
- Re-implementing (outside the library) which
ShowHelpcases the library itself would consider "should still show usage" vs. "already showed everything needed" — knowledge onlyrunWith/showHelpreally have. - Coupling to
showHelp's exactConsolecall pattern (that it's exactly onelogthen, conditionally, oneerror) — any change to that internal implementation silently breaks the workaround. - No way to prevent the render for a subset of failures without inspecting error internals from outside the library (e.g. wanting to keep the help dump for an unrecognized flag but suppress it for a missing required flag, to match a host framework that treats those differently).
Reproduction
import { Effect, Console } from "effect"
import { Command, Flag } from "effect/unstable/cli"
const cmd = Command.make("greet", { name: Flag.string("name") }, () => Effect.void)
const writes: Array<string> = []
const bufferingConsole = {
...console,
log: (...args: unknown[]) => Effect.sync(() => writes.push(`log: ${args.join(" ")}`)),
error: (...args: unknown[]) => Effect.sync(() => writes.push(`error: ${args.join(" ")}`)),
}
const program = Command.runWith(cmd, { version: "1.0.0" })([]).pipe(
Effect.provideService(Console.Console, bufferingConsole as any),
Effect.exit,
)
Effect.runPromise(program).then((exit) => {
console.log("writes:", writes) // always has the library's own help+error render
console.log("exit:", exit) // caller ALSO gets the ShowHelp error to handle itself
})
Running this for a missing required flag (name never supplied) produces both:
- The library's own
Console.log/Console.errorrender (captured inwritesabove), which happens unconditionally. - The
ShowHelpfailure surfacing throughexit, for the caller to render again if it wants its own error message.
There is no runWith option to get #2 without #1.
Suggested fix
A few shapes that would work, roughly in order of preference:
- A. Add a
runWithconfig option (e.g.renderHelp?: boolean, defaulttrue) that skips the internalshowHelpcall entirely, so a host that wants to own rendering gets the bareShowHelpfailure with no console side effect at all. - B. Let
runWithaccept a render hook (e.g.config.onShowHelp?: (error: CliError.ShowHelp, formatter: CliOutput.Formatter) => Effect.Effect<void>) in place of the hardcodedConsole.log/Console.errorpair, so a host can redirect output per-failure-tag without needing to interceptConsoleat all. - C. At minimum, export
showHelp(or an equivalent pure "format without printing" function) as public API, so hosts that need to suppress the built-in render can still reproduce it faithfully on their own terms instead of re-derivingformatter.formatHelpDoc/formatErrors's call order by trial and error.
Happy to open a PR for whichever direction maintainers prefer — we're working around this downstream in our own CLI (built on effect/unstable/cli) by swapping the ambient Console.Console service, but it's fragile against any change to showHelp's internals and duplicates classification logic the library already has.
- 主要言語
- TypeScript
- スター
- 16.7k
- フォーク
- 808
- 平均マージ
- 10時間 17分
- マージ済み PR(30日)
- 850
環境構築
このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
Effect-TS/effect のほかの issue
-
[email protected]: crypto declarations require a global CryptoKey type, breaking Node-only type-checks with @types/node 22 and 24対応中かも @effect-bot が今日担当しました。 オープンbug
Effect-TS/effect#10196 · 担当者 1 名 ·
メンテナーはふだん 1 日以内に返信
-
OpenApi.fromApi (4.1.0) emits duplicate component schemas with a _1 suffix when the encoded side differs再び着手できるかも このイシューのプルリクエストはマージされずにクローズされました。 オープン
難易度 3/5 1〜2日 初心者へのやさしさ 35/100
メンテナーはふだん 1 日以内に返信
-
難易度 5/5 1週間以上 初心者へのやさしさ 35/100
メンテナーはふだん 1 日以内に返信
-
難易度 4/5 3〜5日 初心者へのやさしさ 47/100
メンテナーはふだん 1 日以内に返信
-
`fromJsonSchemaDocument`: import open `patternProperties`対応中かも @effect-bot が 2 日前に担当しました。 オープン
Effect-TS/effect#10048 · 担当者 1 名 ·
メンテナーはふだん 1 日以内に返信
Effect-TS/effect の issue をすべて見る
似ている issue
-
bug ready-for-agent
難易度 2/5 1〜3時間 初心者へのやさしさ 73/100
PhyberApex/kuroshiro#1687 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 73/100
microsoft/monaco-editor#5563 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
メンテナーはふだん 1 日以内に返信
-
bug
難易度 1/5 1時間未満 初心者へのやさしさ 86/100
awslabs/visual-asset-management-system#937 ·
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100