Hacktoberfest 2026:メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

A webhook that fails three times disappears

オープン
#342 コメント 4 件 リアクション 0 件 担当者 1 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@Herikcool がすでに取り組んでいます。

2026年10月16日 から。

  • #388 @Herikcool による — オープン
  • #467 @sparkysolutions10-pixel による — オープン

評価

この issue はまだ評価されていません。

説明

area:reliability difficulty:intermediate help wanted points:150 Stellar Wave
Background

When deliverJsonWithRetries exhausts its attempts it does this:

console.warn(`[webhook] delivery failed after ${attempt} attempts to ${url}: HTTP ${res.status}`)

…and returns. The alert is gone. The subscriber never learns that an alert fired,
and the operator learns only if someone is reading warn-level logs at the moment
it happens. For an alerting product this is the worst possible failure, because
silence is indistinguishable from "nothing happened".

What to build
  • Persist failed deliveries — endpoint, payload, attempt count, last status, first
    and last attempt times.
  • A counter metric of permanent delivery failures, labelled by a bounded category
    (not by URL — see L171).
  • A way to see recent failures, either on an admin route or via /status.
  • Do not store a delivery secret alongside the payload.
  • Decide and document whether failed deliveries can be replayed; building replay
    is optional, but say which it is.
Acceptance criteria
  • An exhausted delivery is recorded durably, not only logged
  • The record contains enough to diagnose without the original log line
  • A metric counts permanent failures with bounded label values
  • Secrets are not persisted
  • Recent failures are retrievable through an endpoint

Drips Wave · Complexity: Intermediate · 150 points


Repo: Divinity-Labs/Lens. Node + TypeScript, Fastify, Prisma on Postgres,
Redis for queues, Prometheus via prom-client.

Run the tests: npm test. The tests are vitest, not jest. Running jest
against this repo reports "66 suites, 0 tests" and means nothing. A single file
is npx vitest run src/__tests__/yourfile.test.ts.

Load test (prices) is already failing on main and has been for some
time. It is not your PR that broke it. Every other check should be green.

This service prices real assets on Stellar mainnet. A number that is wrong
is worse than a number that is missing, because a caller cannot tell the
difference. Prefer failing loudly over returning a plausible value.

Never elide an address, a contract id or a key in code, a comment or a test
fixture.
A previous batch wrote a shortened contract id in an issue text and
five contributors invented plausible-looking ids to fill the gap. Write the
whole thing or do not write it at all.

The house pattern for an outbound deadline already exists — see
src/alerts/delivery.ts, which passes signal: AbortSignal.timeout(10_000) to
fetch. Where an issue below asks for a timeout, copy that, do not invent a
second convention.


Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

主要言語
TypeScript
スター
4
フォーク
71
平均マージ
1日 11時間
マージ済み PR(30日)
64

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Divinity-Labs/Lens のほかの issue

Divinity-Labs/Lens の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。