Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

Fourteen files read process.env directly, and nothing validates it

オープン
  • 何か問題がありますか？
#338 コメント 5 件 リアクション 0 件 担当者 1 名 GitHub で見る

メンテナーはふだん 3 日以内に返信

@Jossy-ossy がすでに取り組んでいます。

2026年10月16日 から。

  • #387 @Jossy-ossy による — オープン
  • #481 @sparkysolutions10-pixel による — マージされずにクローズ

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
35/100
issue の種類
リファクタリング
明瞭さ
おおむね明確
活発さ
活発
技術スタック
nodejs, postgresql, prometheus, redis, typescript
領域
backend

調査の方向性

Start with src/config.ts, which already reads process.env 34 times, then find the other direct reads in src/db.ts, src/app.ts, src/index.ts, src/api/admin.ts and src/bazaar/rateLimit.ts. Move parsing into one zod-validated module that fails at startup and names the bad variable, and check the result against .env.example with the drift guard, run through npm test (vitest). Done means process.env is read in exactly one module and a non-numeric numeric variable is rejected.

索引モデルが issue の本文から書いたものです。

説明

area:config difficulty:intermediate help wanted points:150 Stellar Wave
Background

src/config.ts exists and is 333 lines, reading process.env 34 times. It does
no validation — no schema, no zod, despite zod already being a dependency used
for route validation. And 14 other files under src/ read process.env
directly, bypassing it entirely, among them src/db.ts, src/app.ts,
src/index.ts, src/api/admin.ts and src/bazaar/rateLimit.ts.

The failure mode is a misspelled or missing variable becoming undefined, then
a default, then a service that starts cleanly and behaves wrongly. A numeric
limit read as undefined silently becomes NaN in arithmetic. Nothing fails
until a price is wrong.

What to build
  • One validated config module as the single source: parse and validate the whole
    environment once at startup with zod, and fail to start on anything invalid.
  • Types derived from the schema, so a typo in a config key is a compile error.
  • Replace the 14 direct reads with imports from it.
  • Every variable documented in .env.example. The repo has a drift guard that
    checks this — run it.
  • Required-in-production variables must be required, not silently defaulted.
Acceptance criteria
  • process.env is read in exactly one module
  • Invalid or missing required configuration fails at startup with a message naming the variable
  • Config values are typed from the schema
  • .env.example documents every variable and the drift guard passes
  • A numeric variable that is not a number is rejected rather than becoming NaN

Drips Wave · Complexity: Intermediate · 150 points

Repo: Divinity-Labs/Lens. Node + TypeScript, Fastify, Prisma on Postgres,
Redis for queues, Prometheus via prom-client.

Run the tests: npm test. The tests are vitest, not jest. Running jest
against this repo reports "66 suites, 0 tests" and means nothing. A single file
is npx vitest run src/__tests__/yourfile.test.ts.

Load test (prices) is already failing on main and has been for some
time. It is not your PR that broke it. Every other check should be green.

This service prices real assets on Stellar mainnet. A number that is wrong
is worse than a number that is missing, because a caller cannot tell the
difference. Prefer failing loudly over returning a plausible value.

Never elide an address, a contract id or a key in code, a comment or a test
fixture. A previous batch wrote a shortened contract id in an issue text and
five contributors invented plausible-looking ids to fill the gap. Write the
whole thing or do not write it at all.

The house pattern for an outbound deadline already exists — see
src/alerts/delivery.ts, which passes signal: AbortSignal.timeout(10_000) to
fetch. Where an issue below asks for a timeout, copy that, do not invent a
second convention.

Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

主要言語
TypeScript
スター
4
フォーク
71
平均マージ
3日 6時間
マージ済み PR（30日）
144

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Divinity-Labs/Lens のほかの issue

Divinity-Labs/Lens の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。