Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

The websocket metric's label grows without bound

クローズ
  • 何か問題がありますか？
#337 コメント 2 件 リアクション 0 件 担当者 1 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@Jossy-ossy がすでに取り組んでいます。

2026年10月16日 から。

評価

この issue はまだ評価されていません。

説明

area:observability difficulty:intermediate help wanted points:150 Stellar Wave
Background

src/ws/fanout.ts increments:

ws_messages_sent_total.labels(client.pairKey).inc()

pairKey is user-supplied through the subscription — it is whatever pair a
client asked for. Prometheus creates a new time series for every distinct label
value and keeps it for the lifetime of the process, so the number of series
grows with the number of distinct pairs ever subscribed to, not with the number
of pairs that exist.

A client subscribing to randomly generated pair keys can grow the /metrics
response without limit. Even without malice, a screener that walks every pair
produces thousands of permanent series. This is the standard Prometheus
cardinality failure, and it ends with /metrics too slow to scrape.

What to build
  • Only label with a pair that is known — validate pairKey against the pairs
    the service actually tracks before using it as a label value.
  • Unknown pairs should either be rejected at subscribe time or folded into a
    single other label.
  • Audit the rest of src/metrics.ts and src/middleware/httpMetrics.ts for the
    same pattern; any label value derived from user input is a candidate.
  • Document the rule in src/metrics.ts so the next metric does not reintroduce it.
Acceptance criteria
  • No metric label can take an unbounded set of values from user input
  • A test subscribing to many unknown pairs does not create a series per pair
  • The existing * aggregate label keeps working
  • The rule is written down next to the registry definition

Drips Wave · Complexity: Intermediate · 150 points

Repo: Divinity-Labs/Lens. Node + TypeScript, Fastify, Prisma on Postgres,
Redis for queues, Prometheus via prom-client.

Run the tests: npm test. The tests are vitest, not jest. Running jest
against this repo reports "66 suites, 0 tests" and means nothing. A single file
is npx vitest run src/__tests__/yourfile.test.ts.

Load test (prices) is already failing on main and has been for some
time. It is not your PR that broke it. Every other check should be green.

This service prices real assets on Stellar mainnet. A number that is wrong
is worse than a number that is missing, because a caller cannot tell the
difference. Prefer failing loudly over returning a plausible value.

Never elide an address, a contract id or a key in code, a comment or a test
fixture. A previous batch wrote a shortened contract id in an issue text and
five contributors invented plausible-looking ids to fill the gap. Write the
whole thing or do not write it at all.

The house pattern for an outbound deadline already exists — see
src/alerts/delivery.ts, which passes signal: AbortSignal.timeout(10_000) to
fetch. Where an issue below asks for a timeout, copy that, do not invent a
second convention.

Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

主要言語
TypeScript
スター
4
フォーク
71
平均マージ
1日 9時間
マージ済み PR（30日）
34

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Divinity-Labs/Lens のほかの issue

Divinity-Labs/Lens の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。