Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

Fix missing income requirement in Senior Citizen Tax Freeze screening

オープン
  • 何か問題がありますか？
#564 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
48/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
java
領域
backend

調査の方向性

Start by comparing library-api/src/main/resources/benefits/pa/phl/senior-citizen-tax-freeze.dmn with checks/income/tax-freeze-income.dmn and the PhlLowIncomeTaxFreeze composition; confirm the income definition and existing test locations. Then update the SCTF composition, metadata, documentation, and fixtures as described. Done means the boundary, missing-evidence, and existing age-path scenarios pass, along with library compilation and discovery/schema/composition checks.

索引モデルが issue の本文から書いたものです。

説明

Problem

library-api/src/main/resources/benefits/pa/phl/senior-citizen-tax-freeze.dmn currently composes enrollment, owner occupancy, Philadelphia residence and age checks, but does not check income. Its local tSituation also omits applicantAndSpouseIncome.

Consequently, an otherwise qualifying applicant can receive isEligible: true even when their income is unknown or exceeds the program limit. The DMN documentation currently identifies this as partial screening.

Philadelphia requires both age and income eligibility. The official Senior Citizen Tax Freeze guidance lists inclusive total-income limits of $33,500 for a single person and $41,500 for a married couple (source checked 2026-10-17).

Reuse the existing income check

checks/income/tax-freeze-income.dmn already exposes TaxFreezeIncomeService, and PhlLowIncomeTaxFreeze already composes it. It uses the canonical applicantAndSpouseIncome field, primaryPersonId and spouse relationships, with inclusive single/married thresholds and unknown results for missing income or relationship evidence.

  • Import and invoke TaxFreezeIncomeService as a named entry in SCTF's checks context, following the Low-Income Tax Freeze composition pattern. Do not introduce a duplicate income fact, algorithm or threshold table.
  • Add applicantAndSpouseIncome to SCTF's minimal local tSituation; reuse its existing person/relationship fields. Confirm the current program income definition matches the shared check before composing it.
  • Add the corresponding knowledge requirement and KIE Tools 10.2 DMNDI shape/edge. Preserve the existing age pathways and the standard all(checksAsList) aggregation.
  • Confirm generated OpenAPI input and x-bdt-benefit composition metadata include the income requirement so newly imported builder benefits collect and evaluate it.
  • Replace the partial-screening descriptions/annotation with accurate documentation after the rule is implemented, and update the shared income check's description that currently says SCTF does not invoke it.

Acceptance criteria and validation

  • With other requirements passing, single income at $33,500 passes and income above it fails; married income at $41,500 passes and income above it fails.
  • Missing income or unresolved spouse/marital evidence produces an unknown income result and isEligible: null when all other requirements pass. An explicitly empty relationships list establishes the existing single-person route.
  • A known failed requirement still yields isEligible: false even if income is unknown.
  • Existing applicant, spouse and late-spouse age-path fixtures are updated with appropriate income evidence; adding income does not change the age algorithms.
  • Existing Low-Income Tax Freeze and reusable TaxFreezeIncome scenarios continue to pass without duplicated rules.
  • Bruno benefit tests cover the inclusive boundaries, over-limit and missing-income cases; library compilation/tests and discovery/schema/composition checks pass.

This fixes an existing omission identified during the library documentation migration. Related: #563 (expose DMN documentation and limitations in the builder).

主要言語
Java
スター
16
フォーク
5
平均マージ
15時間 42分
マージ済み PR（30日）
21

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

  • Dockerfile・Docker Compose ファイルなし
  • プルリクエストのテンプレートあり
  • コントリビューションガイドなし

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

CodeForPhilly/benefit-decision-toolkit のほかの issue

CodeForPhilly/benefit-decision-toolkit の issue をすべて見る

似ている issue

Java の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。