"Toggle Impassable Cells" should mark more cells
まだ誰も着手していません。
評価
調査の方向性
Start by locating the “Toggle Impassable Cells” entry point and reading how it currently identifies Rock terrain and overlays. Use the terrain examples in the issue to understand the red, blue, and purple categories, then inspect how terrain objects, structures, and units expose their movement and immunity properties. Done means the toggle reflects the specified terrain and object categories, including passable overlays; the issue does not name tests or files to run.
索引モデルが issue の本文から書いたものです。
説明
The "Toggle Impassable Cells" function currently only marks cells with the Rock Terrain Type, which makes it unreliable because units are unable to move onto many other cells as well.
To improve this WAE should instead check the values of every Terrain Type and mark every cell that has a Terrain Type for which all values (aside for Winged, which can always be ignored) are 0% (or are missing) in red.
For example:
[Rock]
Foot=0%
Track=0%
Wheel=0%
Float=0%
Hover=0%
Amphibious=0%
FloatBeach=0%
Creep=0%
Winged=10%
Buildable=no
Terrain Types for which only (at least one of) Float, Amphibious and Hover (and FloatBeach for YR) have a value above 0% (and aren't missing) should be marked in blue:
[Water]
Foot=0%
Track=0%
Wheel=0%
Hover=59%
Float=59%
Amphibious=59%
FloatBeach=59%
Creep=0%
Winged=100%
Buildable=no
And Terrain Types for which only (at least one of) Amphibious and Hover (and FloatBeach for YR) have a value above 0% (and aren't missing) should be marked in purple:
[Beach]
Foot=0%
Track=0%
Wheel=0%
Float=0%
Hover=59%
Amphibious=59%
FloatBeach=59%
Creep=0%
Winged=100%
Buildable=no
While "Toggle Impassable Cells" already also marks cells with overlay using the Rock Terrain Type, it doesn't remove marked cells when you place passable overlay on impassable terrain to make it passable (like when you place NOBUILD overlay on a rock in DTA).
In addition to this WAE should also mark objects (terrain objects, structures and ideally also units).
Indestructible objects (check for Immune=yes) should be marked in red just like impassable terrain is, while destructible objects could instead be marked in yellow.
Maybe some special cases such as units that are both crushable and immune and indestructible trees that infantry can still walk through could be marked in orange (any terrain object that does have not a TemperateOccupationBits or SnowOccupationBits key/value at all or has a value of 7 is impassable for all units, while values from 0 to 6 make them passable for infantry only).
Edit:
Added FloatBeach to the examples to take YR into consideration (this wouldn't have any effect in TS).
- 主要言語
- C#
- スター
- 148
- フォーク
- 49
- 平均マージ
- 4日 9時間
- マージ済み PR（30日）
- 1
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
CnCNet/WorldAlteringEditor のほかの issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
CnCNet/WorldAlteringEditor#343 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
CnCNet/WorldAlteringEditor#276 ·
-
難易度 4/5 3〜5日 初心者へのやさしさ 43/100
CnCNet/WorldAlteringEditor#333 · コメント 1 件 ·
-
難易度 4/5 3〜5日 初心者へのやさしさ 45/100
CnCNet/WorldAlteringEditor#326 ·
-
HouseType Parameter for Trigger Actions 3, 37, 38, & 74 do not Match Final Alert 2 for RA2 Missionsオープン
難易度 3/5 1〜2日 初心者へのやさしさ 48/100
CnCNet/WorldAlteringEditor#318 · コメント 4 件 ·
CnCNet/WorldAlteringEditor の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
メンテナーはふだん 1 日以内に返信
-
bug 優先: 低
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
メンテナーはふだん 1 日以内に返信
-
難易度 1/5 1時間未満 初心者へのやさしさ 92/100
-
.NET area: storage bug good first issue
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
Larson-Logan/medal-sync#61 ·
メンテナーはふだん 1 日以内に返信
-
難易度 1/5 1時間未満 初心者へのやさしさ 88/100
メンテナーはふだん 1 日以内に返信