/shop delete destroys the store's stock instead of returning it

オープン
  • 何か問題がありますか？
#62 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
72/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
java
領域
backend

調査の方向性

Start with DeleteCommand, where the issue says the inventory check and unfinished TODO already exist, then inspect the delete command tests and the wiki's Commands page. Trace how finite stock and negative quantities are handled, and run the relevant tests. Done when a plain delete returns finite stock or leaves the store unchanged if inventory is insufficient, force flags still discard stock, and the wiki matches.

索引モデルが issue の本文から書いたものです。

説明

bug

Problem

DeleteCommand checks that the player has room for the store's items, then deletes the store without giving them the items. All remaining stock is lost, even on a plain /shop delete <store> with no flags.

The inventory check implies the items should be returned, and so does STORE_DELETE_INSUFFICIENT_INV_PLAYER, which tells players to clear space or use -f to ignore inventory. A TODO in DeleteCommand also notes that removing all items is unfinished. The balance is refunded correctly unless -F is used.

The existing -f and -F tests only cover the forced paths, where an empty inventory is expected.

Steps to reproduce

  1. Create a store and add items to it.
  2. Run /shop delete <store> with enough free inventory space.
  3. The store is deleted, but the items aren't in the player's inventory.

Scope

  • Give the store's stock to the player when deleting without a force flag.
  • Keep -f and -F discarding stock, and make sure the behavior is clear in the command's messages.
  • Handle items with infinite stock (negative quantity) so they don't create items or fail the inventory check.

Done when

  • A plain delete moves all finite stock to the player's inventory.
  • A plain delete with too little space is refused and the store is unchanged.
  • Tests cover the plain delete with stock, and -f and -F still discard it.
  • The wiki's Commands page, which currently warns that stock isn't returned, matches the fix.
  • Fixed before the 0.4.0 full release.
主要言語
Java
スター
1
フォーク
0
平均マージ
2時間 35分
マージ済み PR（30日）
14

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

BrendonButler/Shops のほかの issue

BrendonButler/Shops の issue をすべて見る

似ている issue

Java の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。