ENH: Remove the filter index -1 report of a failed final pipeline snapshot
メンテナーはふだん 6 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 35/100
調査の方向性
Start by reading Pipeline::executeFrom() in src/simplnx/Pipeline/Pipeline.cpp and list every reader of AbstractPipelineNode::getDataStructure() on a Pipeline. Trace how the final snapshot is used for local execution, nested pipelines, disabled filters, early stops, and empty pipelines. Done means removing the copy and keeping those readers correct, with the requested C++ and Python coverage and index -1 handling removed where no longer needed.
索引モデルが issue の本文から書いたものです。
説明
Summary
Remove the "filter index -1" report for a failed final pipeline snapshot. The preferred change is to remove the final snapshot copy, so that this failure cannot occur. This is a follow-up to the out-of-core review PR tree. It starts at #1933 ("BUG: Report store flush, pipeline completion and recovery failures"), and that PR keeps index -1 for now.
How it works in #1933
At the end of a run, Pipeline::executeFrom() copies the DataStructure into the pipeline node with setDataStructure(). This copy is the final pipeline snapshot (Pipeline.cpp#L376-L396). If the copy throws, the errors are -272 (memory allocation) or -6071. No filter owns this failure, and the pipeline node has no place to keep errors. Also, no pipeline-level signal carries error text: PipelineFaultSignal sends only a FaultState. So the errors are sent with the per-filter signal and a filter index that is not real:
sendFilterFaultDetailMessage(-1, {}, snapshotErrors);
Each listener must know that -1 means "the pipeline itself":
- nxrunner prints the errors as "Pipeline completion errors" (CliObserver.cpp#L25).
- DREAM3D-NX (the companion PR tree) shows index -1 in the Issues list as "Pipeline: name".
- The Python
Pipeline.execute()binding does not handle it.ExecutePipeline()builds its result from the stored fault state of each filter and sub-pipeline node (simplnxpy.cpp#L522-L573). The snapshot errors are only sent, not stored, so a failure of only the final snapshot gives an invalid result with an empty error list. This was found by reading the code. No test was run.
On develop, the same copy has no try. The exception leaves Pipeline::execute(), and nxrunner and DREAM3D-NX catch it and report a failure. This failure is not a persistence or flush failure. It occurs only when the copy runs out of memory or a DataObject copy throws. No test covers it.
Why it is needed
Index -1 gives an existing signal a second meaning. Every current and future listener must handle it, and one listener (Python) already does not. The design was questioned during review of #1933.
Requested change (preferred: remove the copy)
The final snapshot copies the same DataStructure that the last executed filter node copied a moment before, in AbstractPipelineNode::endExecutionChecked() (AbstractPipelineNode.cpp#L137). If the pipeline's result is the snapshot of its last executed node, or a shared reference to it, then the final copy, its failure path and index -1 can all be removed. DREAM3D-NX already reads the last filter's snapshot, not the pipeline's. Python reads the DataStructure that it passes in.
These readers depend on the pipeline's own snapshot today, and the change must keep them correct:
Pipeline::execute(const std::atomic_bool&)runs on a local DataStructure, so its result exists only in the pipeline snapshot (Pipeline.cpp#L193-L197).- A pipeline nested in another pipeline:
executeFrom(index)readsat(index - 1)->getDataStructure(), and that node can be a sub-pipeline (Pipeline.cpp#L416). - Disabled filters at the end of the pipeline, a run that stops early (an error or a cancel), and an empty pipeline.
All readers of AbstractPipelineNode::getDataStructure() on a Pipeline must be listed before the change.
Fallback: pipeline-level errors
If removing the copy cannot keep those readers correct, give the pipeline its own errors:
- The pipeline stores its completion errors and warnings.
- A pipeline-level signal sends them, for example a new fault-detail signal without a filter index, or errors added to
PipelineFaultSignal. - nxrunner, DREAM3D-NX and Python read them from the pipeline, with no special index.
The signal design for the fallback is still open.
Tests
- C++: a test where only the final pipeline step fails (for example, a
DataObjectwhose copy throws), if that failure path remains. It checks the result ofPipeline::execute(), the stored errors and the signals. - Python: one test of
Pipeline.execute()for the same case, which checks that the result contains the error, or that the case can no longer occur. - Remove the index -1 handling from nxrunner
CliObserver, DREAM3D-NX and their tests, if the change makes it unnecessary.
- 主要言語
- C++
- スター
- 18
- フォーク
- 15
- 平均マージ
- 4日 23時間
- マージ済み PR(30日)
- 42
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
BlueQuartzSoftware/simplnx のほかの issue
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
BlueQuartzSoftware/simplnx#1987 ·
メンテナーはふだん 6 日以内に返信
-
documentation
難易度 2/5 1〜3時間 初心者へのやさしさ 74/100
BlueQuartzSoftware/simplnx#1980 ·
メンテナーはふだん 6 日以内に返信
-
Testing
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
BlueQuartzSoftware/simplnx#1979 ·
メンテナーはふだん 6 日以内に返信
-
documentation
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
BlueQuartzSoftware/simplnx#1978 ·
メンテナーはふだん 6 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
BlueQuartzSoftware/simplnx#1945 ·
メンテナーはふだん 6 日以内に返信
BlueQuartzSoftware/simplnx の issue をすべて見る
似ている issue
-
bug triage
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
メンテナーはふだん 1 日以内に返信
-
26.04 bug dark-mode Easy Hack impress symptom: visual
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
CollaboraOnline/online#16421 · コメント 1 件 ·
-
area/cs bug
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
ydb-platform/ydb#59881 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 64/100
メンテナーはふだん 1 日以内に返信
-
documentation enhancement lua server
難易度 2/5 1〜3時間 初心者へのやさしさ 66/100