ENH: Use one fast exact duplicate-vertex finder in all duplicate-vertex code
メンテナーはふだん 6 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 35/100
- issue の種類
- 機能追加
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- cpp
- 領域
- backend, data, performance
調査の方向性
Start by reading GeometryUtilities::EliminateDuplicateNodes in src/simplnx/Utilities/GeometryUtilities.cpp and MeshingUtilities::OrderSharedVertices / HasDuplicateVertices in src/simplnx/Utilities/Meshing/VertexUtilities.cpp, along with issue #1908 item L19. The issue leaves the algorithm and memory budget open, so first compare the existing paths against the exact-equality, parallel, cancellable, out-of-core requirements. Done means one shared finder is used by all listed filters and keeps the first vertex in each duplicate group.
索引モデルが issue の本文から書いたものです。
説明
Summary
Request: one shared, fast duplicate-vertex finder that every filter which looks for duplicate vertices uses. It should find vertices whose X, Y and Z coordinates are exactly equal, run in parallel, scale with the number of vertices, and work with out-of-core (OOC) data.
Why it is needed
simplnx has two separate duplicate-vertex finders. They have different weaknesses:
GeometryUtilities::EliminateDuplicateNodes(GeometryUtilities.hpp:119, FindUniqueIdsImpl) puts each vertex into a spatial bin and compares, in parallel, every pair of vertices inside each bin with exact==. It is fast for typical STL files, but:- The grid always has 100 × 100 × 100 bins, whatever the number of vertices. The comparison inside a bin is O(k²). A flat mesh uses only one layer of 100 × 100 bins, and dense lattice meshes (surface meshes made from voxel data) put many vertices into each bin.
- The bins (one
std::vectorper bin, about 24 MB when empty) and theInt64DataStoreof unique IDs are always in memory, so the memory use is about 16 bytes or more per vertex, with no OOC path. - A NaN coordinate makes the bin index cast undefined behavior, and an infinite coordinate breaks the bounding box. Neither case is checked.
MeshingUtilities::OrderSharedVertices/HasDuplicateVertices(VertexUtilities.cpp) sort the vertex indices and compare neighbors. Issue #1908 item L19 (same defect as #1783) changes this code to exact equality with a sort on (x, y, z, input index). That sort is O(N log N), single threaded, and reads each coordinate through the DataStore's virtual accessor. With an OOC store, these reads come in random order through the chunk cache, because the sort compares vertices in random order.
Filters affected
- Through
EliminateDuplicateNodes: Read STL File, Combine STL Files (it runs Read STL File for each file), Slice Triangle Geometry and Extract Feature Boundaries 2D. - Through
OrderSharedVertices/HasDuplicateVertices: Identify Duplicate Vertices and Verify Triangle Winding.
Expected behavior (the rule chosen for L19)
- Two vertices are duplicates only when X, Y and Z are exactly equal (
==, so -0.0 equals +0.0). A vertex with a NaN coordinate is never a duplicate. - In each group of equal vertices, the first vertex in input order is kept.
- The run can be cancelled.
Measurements (from the L19 review, macOS ARM64, in memory, one thread, about 4 million vertices on a 200³ lattice in random order, no duplicates): the old one-axis sort took 0.42 s (but it misses duplicates), and the L19 sort takes 1.30 s. A scan that compares all vertices with the same primary coordinate took about 117 s.
Still open: the algorithm (hash on the exact coordinate bits, bins sized from the vertex count, or a sort that runs on chunks and then merges them for OOC data) and the memory budget that is allowed.
- 主要言語
- C++
- スター
- 18
- フォーク
- 15
- 平均マージ
- 4日 23時間
- マージ済み PR(30日)
- 42
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
BlueQuartzSoftware/simplnx のほかの issue
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
BlueQuartzSoftware/simplnx#1987 ·
メンテナーはふだん 6 日以内に返信
-
documentation
難易度 2/5 1〜3時間 初心者へのやさしさ 74/100
BlueQuartzSoftware/simplnx#1980 ·
メンテナーはふだん 6 日以内に返信
-
Testing
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
BlueQuartzSoftware/simplnx#1979 ·
メンテナーはふだん 6 日以内に返信
-
documentation
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
BlueQuartzSoftware/simplnx#1978 ·
メンテナーはふだん 6 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
BlueQuartzSoftware/simplnx#1945 ·
メンテナーはふだん 6 日以内に返信
BlueQuartzSoftware/simplnx の issue をすべて見る
似ている issue
-
bug triage
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
メンテナーはふだん 1 日以内に返信
-
26.04 bug dark-mode Easy Hack impress symptom: visual
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
CollaboraOnline/online#16421 · コメント 1 件 ·
-
area/cs bug
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
ydb-platform/ydb#59881 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 64/100
メンテナーはふだん 1 日以内に返信
-
documentation enhancement lua server
難易度 2/5 1〜3時間 初心者へのやさしさ 66/100