[BUG]App Configuration pull refresh runs synchronously on the servlet request thread (Mono.just(refreshStores())); a slow or unavailable store blocks user requests

オープン
  • 何か問題がありますか？
#51,215 コメント 1 件 リアクション 2 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
57/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
java, spring-boot
領域
backend, performance

調査の方向性

Start by reading AppConfigurationEventListener and AppConfigurationPullRefresh.refreshConfigurations() in the App Configuration config modules; the issue identifies the eager Mono.just(refreshStores()) call and the servlet event that triggers it. Trace the existing refresh tests and how they invoke store calls. Done means refresh checks no longer hold servlet request threads during slow store calls, with coverage showing the request can complete independently.

索引モデルが issue の本文から書いたものです。

説明

needs-triage

With spring-cloud-azure-appconfiguration-config-web on the classpath and monitoring.enabled: true,
AppConfigurationEventListener handles every ServletRequestHandledEvent by calling
appConfigurationRefresh.refreshConfigurations().subscribe().

AppConfigurationPullRefresh.refreshConfigurations() is implemented as:

public Mono<Boolean> refreshConfigurations() {
    return Mono.just(refreshStores());
}

Mono.just(...) evaluates its argument eagerly, so refreshStores() (which makes blocking HTTP calls to the
store) runs synchronously on the Tomcat request thread before .subscribe() is reached.
ServletRequestHandledEvent is published inside FrameworkServlet.processRequest before the response is
completed, so the client waits for the refresh too.

When the store is slow or unavailable, whichever user request happens to trigger the refresh check is held for
the full duration of the store call (up to the HTTP client's 60 s response timeout).

This looks like the same issue as #37018 (reported against 5.x). That issue was closed as stale, with a note that
v6 should fix it and to open a new issue if it didn't. It is still present in 7.4.0.

Versions

  • spring-cloud-azure-appconfiguration-config(-web): observed on 7.0.0, same code in 7.4.0 (latest)
  • Spring Boot 3.x, servlet stack (Tomcat), Java 21

Observed in production

  • Normal: refresh check median ~20 ms, so the cost is invisible.
  • Store returned HTTP 503 for ~40 min: each refresh check took 5–15 s (some 60 s). User-facing requests that
    triggered the check took 18–32 s instead of milliseconds, even though the controller had already finished.
  • One case: the controller completed in ~33 ms and the response was sent after ~61 s (refresh timed out after 60 s).

To Reproduce

  1. Spring Boot servlet app with spring-cloud-azure-starter-appconfiguration-config, monitoring enabled: 
    spring.cloud.azure.appconfiguration.stores[0]:
  endpoint: https://<store>.azconfig.io
  monitoring:
    enabled: true
    refresh-interval: 30s
    triggers:
      - key: sentinel
  2. Start the app, then make the store unreachable (e.g. drop outbound traffic to the store's IP, or point the hostname at a non-routable address).
  3. Wait >30 s, then call any endpoint (GET /anything).
  4. The response takes as long as the store call times out (~60 s), although the handler returned immediately.

Expected behavior
The refresh check must not block request threads. Either make the call actually asynchronous
(Mono.fromCallable(this::refreshStores).subscribeOn(Schedulers.boundedElastic()), or dispatch to an executor),
or run the check from a scheduler rather than from ServletRequestHandledEvent. A short, configurable timeout for
refresh calls would also help.

主要言語
Java
スター
2.6k
フォーク
2.2k
平均マージ
1日 17時間
マージ済み PR（30日）
259

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Azure/azure-sdk-for-java のほかの issue

Azure/azure-sdk-for-java の issue をすべて見る

似ている issue

Java の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。