POST site search forms (e.g. CMS search blocks) are not core/search; on /giving pages they classify as donation and fail the import

オープン
#6,503 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
68/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
php, wordpress
領域
backend, web-dev

調査の方向性

Read SearchBlockConverter::searchBlockFromForm() and FormRuntimeRequirementAnalyzer::intent(), then compare their search signals with SearchBlockConversionContext::hasSearchFormSignal(). Trace the existing tests for POST search forms and donation detection. Done means qualifying POST searches become core/search, including on giving pages, while real donation forms remain classified as donations.

索引モデルが issue の本文から書いたものです。

説明

Summary

A site search form that submits with method="post" is not recognized as search. This is common with CMS search blocks such as Drupal's search-block-form. On a page whose action path looks like a donation URL (/giving, /donate), the same form is classified as a donation form.

Results:

  • On most pages, FormRuntimeRequirementAnalyzer::intent() returns unknown, and the single text field counts as contact evidence. SSI then materializes the header search as a Jetpack contact form, so a visitor's search becomes a feedback submission.
  • On /giving/ the intent is donation, jetpack/donations refuses it (donation_amounts_unrecognized), and the form stays a core/html fallback. That fails the import quality gate, so the whole import fails.

Production: https://physics.uci.edu/ (static_site_capture_build_failed). After working around https://github.com/Automattic/static-site-importer/issues/3097 locally, the import fails with static_site_importer_quality_failed: 1 unsupported_html_fallback, which is the header search on /giving/.

Reduced reproduction (neutral)

index.html and giving/index.html both have this in <header>, with action set to the page's own path:

<form action="/giving" method="post" id="search-block-form" accept-charset="UTF-8"><div class="container-inline">
  <h2 class="element-invisible">Search form</h2>
  <div class="form-item"><label class="element-invisible" for="edit-search">Search </label>
  <input title="Enter the terms you wish to search for." type="text" id="edit-search" name="search_block_form" value="" size="15" maxlength="128" class="form-text"></div>
  <div class="form-actions"><input type="submit" id="edit-submit" name="op" value="Search" class="form-submit"></div>
  <input type="hidden" name="form_build_id" value="form-abc123"><input type="hidden" name="form_id" value="search_block_form">
</div></form>

studio create --from <dir> (SSI 1.34.137) fails with static_site_importer_quality_failed: 1 unsupported_html_fallback, 1 core_html_block. The home page content holds jetpack/contact-form + jetpack/field-text + two jetpack/field-hidden.

Root cause

  1. SearchBlockConverter::searchBlockFromForm() returns null for any non-GET method, even though core/search replaces the source's search handler entirely. The source method has no bearing on the WordPress result.
  2. FormRuntimeRequirementAnalyzer::intent() checks $donate (set from the path regex give|giving|donat…) before search. Its search signal is also narrower than SearchBlockConversionContext::hasSearchFormSignal(): it only accepts the form's role=search, an input with type=search, or names q/s/search/query, and only for GET.

Expected

A form with one free-text input, one submit, and only hidden server tokens besides those becomes core/search regardless of method, provided hasSearchFormSignal() holds (here id="search-block-form" and the "Search" submit). The intent analyzer should agree, reporting search ahead of the path-only donation rule. A real donation form (amount choices, or a Donate/Give submit) must still be classified as donation.

主要言語
PHP
スター
28
フォーク
5
平均マージ
2時間 53分
マージ済み PR(30日)
938

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Automattic/blocks-engine のほかの issue

Automattic/blocks-engine の issue をすべて見る

似ている issue

PHP の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。