ArduPilot/ardupilot

Remove mavlink enum dependencies on non related library

Open

#23,320 opened on 2023年3月24日

GitHub で見る
 (14 comments) (0 reactions) (1 assignee)C++ (9,336 stars) (15,603 forks)batch import
Enhancementgood first issue

説明

Feature request

Is your feature request related to a problem? Please describe. In numerous place, we were using mavlink enum. Those are well defined and conveniant but they bring a hard link to mavlink that can be harmfull codewise.

Therefore, we got a recent effort to reduce this dependency : see https://github.com/ArduPilot/ardupilot/pull/23229 . In this PR, we decouple the GPS status from the mavlink enum. That lower our inclusion mess.

Describe the solution you'd like We should now update our codebase to remove the mavlink GPS enum in favor of the GPS_Status enum.

Some other work could be done to make the same for EKF and other mavlink enums !

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Platform [ X ] All [ ] AntennaTracker [ ] Copter [ ] Plane [ ] Rover [ ] Submarine

Additional context Add any other context or screenshots about the feature request here.

コントリビューターガイド

技術スタック
cpp
領域
backend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
blocked
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
C++ knowledgeArduPilot codebasePR #23229 understanding
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
Start by reviewing the decoupling changes made in PR #23229 to understand the new GPS Status enum. Then search the codebase for remaining uses of mavlink GPS enum and replace them with the new GPS Status enum. Ensure consistency with the existing patterns used in the PR. After completing the GPS enum replacements, consider extending similar decoupling to other mavlink enums like EKF, as suggested in the issue.