A full skill allowance still admits three retrieved skills

internal/session/skillturn.go の 102 行目と 140 行目から開始し、次に room zero を使って決定論的な fillSkillRoom ケースを実行します。codeaf chat に添付された skill が正確に 4 つあること、および skills notice に取得された追加の skill がないことを確認します。skills manual の上限を検証し、以前のオーバーフローを invalidates に記録します。

Found on santos/dev2 at 008363c98 (#1410). It reaches dev when #1410 merges.

What happened

When attachments and explicitly named skills fill the four-skill turn allowance, room is zero. fillSkillRoom returns the entire retrieved list for zero, so a turn can carry up to three more skills and reach seven. This bypasses the allowance precisely when a person has filled it deliberately.

Replication

Deterministic (no model). In internal/session, test fillSkillRoom([]string{"extra-one", "extra-two", "extra-three"}, 0). Today it returns all three. Build a turn with four attached or pinned skills and matching retrieval candidates; the · skills · notice names more than four.

Field (real models). Put seven distinct valid skills in a fresh home, attach four through /skill, then send a message that matches three other descriptions. Use OPENROUTER_API_KEY and deepseek/deepseek-v4-flash; budget about a minute and a small charge. Inspect the turn's skills notice.

Where

internal/session/skillturn.go:102 computes the remaining room; fillSkillRoom at :140 returns retrieved when room <= 0.

The fix

Return no retrieved names when room is zero. Keep attached names first, then explicitly named names, then retrieval only in remaining seats.

Acceptance

• e2e: codeaf chat with four attached skills carries exactly those four on the next turn; the skills notice names no retrieved extras.
• Unit: room zero returns an empty slice; every composition path stays within the declared cap.
• State the cap in the skills manual and record the old overflow in invalidates.